[INFO] fetching crate rusty-cli 0.1.0... [INFO] checking rusty-cli-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rusty-cli 0.1.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate rusty-cli 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rusty-cli 0.1.0 [INFO] finished tweaking crates.io crate rusty-cli 0.1.0 [INFO] tweaked toml for crates.io crate rusty-cli 0.1.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate rusty-cli 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ea547b7b9cbde8c20e942698d36aa402bdcf765c016edbf5756175b6e28d86e3 [INFO] running `Command { std: "docker" "start" "-a" "ea547b7b9cbde8c20e942698d36aa402bdcf765c016edbf5756175b6e28d86e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ea547b7b9cbde8c20e942698d36aa402bdcf765c016edbf5756175b6e28d86e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ea547b7b9cbde8c20e942698d36aa402bdcf765c016edbf5756175b6e28d86e3", kill_on_drop: false }` [INFO] [stdout] ea547b7b9cbde8c20e942698d36aa402bdcf765c016edbf5756175b6e28d86e3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b0ef6d4f537951a2882e276ea8a5829d974a14ced6009c6826d6e6e551965334 [INFO] running `Command { std: "docker" "start" "-a" "b0ef6d4f537951a2882e276ea8a5829d974a14ced6009c6826d6e6e551965334", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking zeroize v1.5.6 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking dirs-next v1.0.2 [INFO] [stderr] Checking platform-dirs v0.3.0 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking console v0.15.0 [INFO] [stderr] Checking dialoguer v0.10.1 [INFO] [stderr] Checking rusty-cli v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/inputs/text_input.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 9 | let mut input = Input::::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | input.interact().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/inputs/text_input.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 9 | let mut input = Input::::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | input.interact().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/file_reader.rs:25:32 [INFO] [stdout] | [INFO] [stdout] 25 | fs::create_dir(path.clone()).expect("Cannot create root data directory"); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 25 - fs::create_dir(path.clone()).expect("Cannot create root data directory"); [INFO] [stdout] 25 + fs::create_dir(path).expect("Cannot create root data directory"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/file_reader.rs:25:32 [INFO] [stdout] | [INFO] [stdout] 25 | fs::create_dir(path.clone()).expect("Cannot create root data directory"); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 25 - fs::create_dir(path.clone()).expect("Cannot create root data directory"); [INFO] [stdout] 25 + fs::create_dir(path).expect("Cannot create root data directory"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty-cli` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rusty-cli` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "b0ef6d4f537951a2882e276ea8a5829d974a14ced6009c6826d6e6e551965334", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0ef6d4f537951a2882e276ea8a5829d974a14ced6009c6826d6e6e551965334", kill_on_drop: false }` [INFO] [stdout] b0ef6d4f537951a2882e276ea8a5829d974a14ced6009c6826d6e6e551965334