[INFO] fetching crate rusty-blockparser 0.11.0... [INFO] checking rusty-blockparser-0.11.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rusty-blockparser 0.11.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate rusty-blockparser 0.11.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rusty-blockparser 0.11.0 [INFO] finished tweaking crates.io crate rusty-blockparser 0.11.0 [INFO] tweaked toml for crates.io crate rusty-blockparser 0.11.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate rusty-blockparser 0.11.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1fa971f4b7c610864a250ab3fc67753e6472e934a5fa375d17f6e739d21fdd26 [INFO] running `Command { std: "docker" "start" "-a" "1fa971f4b7c610864a250ab3fc67753e6472e934a5fa375d17f6e739d21fdd26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1fa971f4b7c610864a250ab3fc67753e6472e934a5fa375d17f6e739d21fdd26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1fa971f4b7c610864a250ab3fc67753e6472e934a5fa375d17f6e739d21fdd26", kill_on_drop: false }` [INFO] [stdout] 1fa971f4b7c610864a250ab3fc67753e6472e934a5fa375d17f6e739d21fdd26 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d94a0ff14cc5235291ac28d9e97eff2fb461ec760e4b01031b39588fe8bbc320 [INFO] running `Command { std: "docker" "start" "-a" "d94a0ff14cc5235291ac28d9e97eff2fb461ec760e4b01031b39588fe8bbc320", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling rustix v0.38.3 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling cc v1.0.79 [INFO] [stderr] Compiling bitcoin-private v0.1.0 [INFO] [stderr] Checking linux-raw-sys v0.4.3 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling build_const v0.2.2 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Compiling snap v1.1.0 [INFO] [stderr] Compiling hex_lit v0.1.1 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Compiling crc v1.8.1 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling rustix v0.37.23 [INFO] [stderr] Compiling bitcoin v0.30.0 [INFO] [stderr] Compiling tempfile v3.6.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Checking integer-encoding v3.0.4 [INFO] [stderr] Checking bitcoin_hashes v0.12.0 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking seek_bufread v1.2.2 [INFO] [stderr] Compiling secp256k1-sys v0.8.1 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking chrono v0.4.26 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking errno v0.2.8 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking clap_builder v4.3.11 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking rusty-leveldb v1.0.8 [INFO] [stderr] Checking clap v4.3.11 [INFO] [stderr] Checking secp256k1 v0.27.0 [INFO] [stderr] Checking rusty-blockparser v0.11.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `size` is never read [INFO] [stdout] --> src/blockchain/parser/blkfile.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct BlkFile { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 18 | pub path: PathBuf, [INFO] [stdout] 19 | pub size: u64, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BlkFile` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:174:11 [INFO] [stdout] | [INFO] [stdout] 141 | let options = match parse_args(command().get_matches()) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | Ok(o) => o, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | Err(desc) => { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let chain_storage = match ChainStorage::new(&options) { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | Ok(storage) => storage, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | let mut parser = BlockchainParser::new(options, chain_storage); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | match parser.start() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:194:54 [INFO] [stdout] | [INFO] [stdout] 194 | .map_or_else(|| CoinType::from(Bitcoin), |v| v.parse().unwrap()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:124:19 [INFO] [stdout] | [INFO] [stdout] 123 | fn from(err: io::Error) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | Self::new(OpErrorKind::IoError(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:142:19 [INFO] [stdout] | [INFO] [stdout] 141 | fn from(_: sync::PoisonError) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | Self::new(OpErrorKind::PoisonError) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:148:19 [INFO] [stdout] | [INFO] [stdout] 147 | fn from(_: sync::mpsc::SendError) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | Self::new(OpErrorKind::SendError) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty-blockparser` (bin "rusty-blockparser") due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `size` is never read [INFO] [stdout] --> src/blockchain/parser/blkfile.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct BlkFile { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 18 | pub path: PathBuf, [INFO] [stdout] 19 | pub size: u64, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BlkFile` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:174:11 [INFO] [stdout] | [INFO] [stdout] 141 | let options = match parse_args(command().get_matches()) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | Ok(o) => o, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | Err(desc) => { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let chain_storage = match ChainStorage::new(&options) { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | Ok(storage) => storage, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | let mut parser = BlockchainParser::new(options, chain_storage); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | match parser.start() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:194:54 [INFO] [stdout] | [INFO] [stdout] 194 | .map_or_else(|| CoinType::from(Bitcoin), |v| v.parse().unwrap()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:124:19 [INFO] [stdout] | [INFO] [stdout] 123 | fn from(err: io::Error) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | Self::new(OpErrorKind::IoError(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:142:19 [INFO] [stdout] | [INFO] [stdout] 141 | fn from(_: sync::PoisonError) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | Self::new(OpErrorKind::PoisonError) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:148:19 [INFO] [stdout] | [INFO] [stdout] 147 | fn from(_: sync::mpsc::SendError) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | Self::new(OpErrorKind::SendError) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty-blockparser` (bin "rusty-blockparser" test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "d94a0ff14cc5235291ac28d9e97eff2fb461ec760e4b01031b39588fe8bbc320", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d94a0ff14cc5235291ac28d9e97eff2fb461ec760e4b01031b39588fe8bbc320", kill_on_drop: false }` [INFO] [stdout] d94a0ff14cc5235291ac28d9e97eff2fb461ec760e4b01031b39588fe8bbc320