[INFO] fetching crate rusty-axml 0.1.0... [INFO] checking rusty-axml-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rusty-axml 0.1.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate rusty-axml 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rusty-axml 0.1.0 [INFO] finished tweaking crates.io crate rusty-axml 0.1.0 [INFO] tweaked toml for crates.io crate rusty-axml 0.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate rusty-axml 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5adfdc5625c8e554bcf1f7a3c61d5fa63bfcb225ef50f8db57a7bdbd3f185b5f [INFO] running `Command { std: "docker" "start" "-a" "5adfdc5625c8e554bcf1f7a3c61d5fa63bfcb225ef50f8db57a7bdbd3f185b5f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5adfdc5625c8e554bcf1f7a3c61d5fa63bfcb225ef50f8db57a7bdbd3f185b5f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5adfdc5625c8e554bcf1f7a3c61d5fa63bfcb225ef50f8db57a7bdbd3f185b5f", kill_on_drop: false }` [INFO] [stdout] 5adfdc5625c8e554bcf1f7a3c61d5fa63bfcb225ef50f8db57a7bdbd3f185b5f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2bdc04469ea42f66e848b6d3e9f1dca00016a06925f3bc9b17fa3c2e5e86db93 [INFO] running `Command { std: "docker" "start" "-a" "2bdc04469ea42f66e848b6d3e9f1dca00016a06925f3bc9b17fa3c2e5e86db93", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling cc v1.1.13 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking flate2 v1.0.32 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking quick-xml v0.31.0 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking zip v0.5.13 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking rusty-axml v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `element_name` [INFO] [stdout] --> src/parser.rs:285:25 [INFO] [stdout] | [INFO] [stdout] 285 | let element_name = parse_end_element(&mut axml_cursor, &global_strings).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_element_name` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `enabled_state` is assigned to, but never used [INFO] [stdout] --> src/lib.rs:216:13 [INFO] [stdout] | [INFO] [stdout] 216 | let mut enabled_state = ComponentState::DefaultTrue; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_enabled_state` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `enabled_state` is never read [INFO] [stdout] --> src/lib.rs:223:13 [INFO] [stdout] | [INFO] [stdout] 223 | enabled_state = ComponentState::ExplicitTrue; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `REAL_get_manifest_contents` is never used [INFO] [stdout] --> src/lib.rs:104:4 [INFO] [stdout] | [INFO] [stdout] 104 | fn REAL_get_manifest_contents(mut axml_cursor: Cursor>) -> ManifestContents { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `REAL_get_manifest_contents` should have a snake case name [INFO] [stdout] --> src/lib.rs:104:4 [INFO] [stdout] | [INFO] [stdout] 104 | fn REAL_get_manifest_contents(mut axml_cursor: Cursor>) -> ManifestContents { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `real_get_manifest_contents` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `NEW_parse_start_element` should have a snake case name [INFO] [stdout] --> src/parser.rs:160:8 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn NEW_parse_start_element(axml_buff: &mut Cursor>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `new_parse_start_element` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/string_pool.rs:138:34 [INFO] [stdout] | [INFO] [stdout] 138 | .map(|_| axml_buff.read_u16::().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty-axml` (lib) due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `element_name` [INFO] [stdout] --> src/parser.rs:285:25 [INFO] [stdout] | [INFO] [stdout] 285 | let element_name = parse_end_element(&mut axml_cursor, &global_strings).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_element_name` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `enabled_state` is assigned to, but never used [INFO] [stdout] --> src/lib.rs:216:13 [INFO] [stdout] | [INFO] [stdout] 216 | let mut enabled_state = ComponentState::DefaultTrue; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_enabled_state` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `enabled_state` is never read [INFO] [stdout] --> src/lib.rs:223:13 [INFO] [stdout] | [INFO] [stdout] 223 | enabled_state = ComponentState::ExplicitTrue; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `REAL_get_manifest_contents` is never used [INFO] [stdout] --> src/lib.rs:104:4 [INFO] [stdout] | [INFO] [stdout] 104 | fn REAL_get_manifest_contents(mut axml_cursor: Cursor>) -> ManifestContents { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `REAL_get_manifest_contents` should have a snake case name [INFO] [stdout] --> src/lib.rs:104:4 [INFO] [stdout] | [INFO] [stdout] 104 | fn REAL_get_manifest_contents(mut axml_cursor: Cursor>) -> ManifestContents { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `real_get_manifest_contents` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `NEW_parse_start_element` should have a snake case name [INFO] [stdout] --> src/parser.rs:160:8 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn NEW_parse_start_element(axml_buff: &mut Cursor>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `new_parse_start_element` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/string_pool.rs:138:34 [INFO] [stdout] | [INFO] [stdout] 138 | .map(|_| axml_buff.read_u16::().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty-axml` (lib test) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2bdc04469ea42f66e848b6d3e9f1dca00016a06925f3bc9b17fa3c2e5e86db93", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2bdc04469ea42f66e848b6d3e9f1dca00016a06925f3bc9b17fa3c2e5e86db93", kill_on_drop: false }` [INFO] [stdout] 2bdc04469ea42f66e848b6d3e9f1dca00016a06925f3bc9b17fa3c2e5e86db93