[INFO] fetching crate rustwide 0.17.0... [INFO] checking rustwide-0.17.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rustwide 0.17.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate rustwide 0.17.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rustwide 0.17.0 [INFO] finished tweaking crates.io crate rustwide 0.17.0 [INFO] tweaked toml for crates.io crate rustwide 0.17.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate rustwide 0.17.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e9379492ff2b486aa195bbfdf6c44eb3ec51e3350eaa500c2e55ddcd5dd91106 [INFO] running `Command { std: "docker" "start" "-a" "e9379492ff2b486aa195bbfdf6c44eb3ec51e3350eaa500c2e55ddcd5dd91106", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e9379492ff2b486aa195bbfdf6c44eb3ec51e3350eaa500c2e55ddcd5dd91106", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9379492ff2b486aa195bbfdf6c44eb3ec51e3350eaa500c2e55ddcd5dd91106", kill_on_drop: false }` [INFO] [stdout] e9379492ff2b486aa195bbfdf6c44eb3ec51e3350eaa500c2e55ddcd5dd91106 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d1e73e72373be57f22ce1c43150abb7753397c1aa15dc90fe30d939f86e440c2 [INFO] running `Command { std: "docker" "start" "-a" "d1e73e72373be57f22ce1c43150abb7753397c1aa15dc90fe30d939f86e440c2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking tinyvec v1.6.1 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking object v0.36.1 [INFO] [stderr] Checking cvt v0.1.2 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Compiling serde_json v1.0.119 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Compiling rustwide v0.17.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking normpath v1.2.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking ascii v1.1.0 [INFO] [stderr] Checking chunked_transfer v1.5.0 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking tiny_http v0.12.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking rustix v0.38.34 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling cc v1.0.103 [INFO] [stderr] Checking tar v0.4.41 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking fs_at v0.1.10 [INFO] [stderr] Checking remove_dir_all v0.8.2 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling libz-sys v1.1.18 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.17.0+1.8.1 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking thiserror v1.0.61 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking serde v1.0.203 [INFO] [stderr] Checking attohttpc v0.28.0 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking toml_edit v0.22.14 [INFO] [stderr] Checking git2 v0.19.0 [INFO] [stderr] Checking toml v0.8.14 [INFO] [stdout] warning: unexpected `cfg` condition name: `docs_rs` [INFO] [stdout] --> src/lib.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | #![cfg_attr(docs_rs, feature(doc_cfg))] [INFO] [stdout] | ^^^^^^^ help: there is a config with a similar name: `docsrs` [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(docs_rs)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(docs_rs)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `docs_rs` [INFO] [stdout] --> src/cmd/mod.rs:129:16 [INFO] [stdout] | [INFO] [stdout] 129 | #[cfg_attr(docs_rs, doc(cfg(unix)))] [INFO] [stdout] | ^^^^^^^ help: there is a config with a similar name: `docsrs` [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(docs_rs)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(docs_rs)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `docs_rs` [INFO] [stdout] --> src/lib.rs:4:13 [INFO] [stdout] | [INFO] [stdout] 4 | #![cfg_attr(docs_rs, feature(doc_cfg))] [INFO] [stdout] | ^^^^^^^ help: there is a config with a similar name: `docsrs` [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(docs_rs)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(docs_rs)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `docs_rs` [INFO] [stdout] --> src/cmd/mod.rs:129:16 [INFO] [stdout] | [INFO] [stdout] 129 | #[cfg_attr(docs_rs, doc(cfg(unix)))] [INFO] [stdout] | ^^^^^^^ help: there is a config with a similar name: `docsrs` [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(docs_rs)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(docs_rs)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/sandbox.rs:36:63 [INFO] [stdout] | [INFO] [stdout] 36 | .map_err(|e| CommandError::SandboxImagePullFailed(Box::new(e)))?; [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/sandbox.rs:51:60 [INFO] [stdout] | [INFO] [stdout] 51 | .map_err(|e| CommandError::SandboxImageMissing(Box::new(e)))?; [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logging.rs:155:20 [INFO] [stdout] | [INFO] [stdout] 153 | let inner = self.inner.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | LogStorage { [INFO] [stdout] 155 | inner: Arc::new(Mutex::new(inner.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logging.rs:260:26 [INFO] [stdout] | [INFO] [stdout] 259 | let storage = Box::new(storage.clone()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | SCOPED.with(|scoped| scoped.borrow_mut().push(storage)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 101 | fn improve_remove_error(error: std::io::Error, path: &Path) -> std::io::Error { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | / RemoveError { [INFO] [stdout] 105 | | underlying: error, [INFO] [stdout] 106 | | path: path.to_path_buf(), [INFO] [stdout] 107 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustwide` (lib) due to 6 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/sandbox.rs:36:63 [INFO] [stdout] | [INFO] [stdout] 36 | .map_err(|e| CommandError::SandboxImagePullFailed(Box::new(e)))?; [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/sandbox.rs:51:60 [INFO] [stdout] | [INFO] [stdout] 51 | .map_err(|e| CommandError::SandboxImageMissing(Box::new(e)))?; [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logging.rs:155:20 [INFO] [stdout] | [INFO] [stdout] 153 | let inner = self.inner.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | LogStorage { [INFO] [stdout] 155 | inner: Arc::new(Mutex::new(inner.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logging.rs:260:26 [INFO] [stdout] | [INFO] [stdout] 259 | let storage = Box::new(storage.clone()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | SCOPED.with(|scoped| scoped.borrow_mut().push(storage)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 101 | fn improve_remove_error(error: std::io::Error, path: &Path) -> std::io::Error { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | / RemoveError { [INFO] [stdout] 105 | | underlying: error, [INFO] [stdout] 106 | | path: path.to_path_buf(), [INFO] [stdout] 107 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustwide` (lib test) due to 6 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d1e73e72373be57f22ce1c43150abb7753397c1aa15dc90fe30d939f86e440c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d1e73e72373be57f22ce1c43150abb7753397c1aa15dc90fe30d939f86e440c2", kill_on_drop: false }` [INFO] [stdout] d1e73e72373be57f22ce1c43150abb7753397c1aa15dc90fe30d939f86e440c2