[INFO] fetching crate rustrc 0.3.0... [INFO] checking rustrc-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rustrc 0.3.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate rustrc 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rustrc 0.3.0 [INFO] finished tweaking crates.io crate rustrc 0.3.0 [INFO] tweaked toml for crates.io crate rustrc 0.3.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate rustrc 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7ef5f2656ce79facbdbd099d903225d6834ece13d2e93fca8d98202d0c7c1014 [INFO] running `Command { std: "docker" "start" "-a" "7ef5f2656ce79facbdbd099d903225d6834ece13d2e93fca8d98202d0c7c1014", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7ef5f2656ce79facbdbd099d903225d6834ece13d2e93fca8d98202d0c7c1014", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ef5f2656ce79facbdbd099d903225d6834ece13d2e93fca8d98202d0c7c1014", kill_on_drop: false }` [INFO] [stdout] 7ef5f2656ce79facbdbd099d903225d6834ece13d2e93fca8d98202d0c7c1014 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c5fda33f15ce810219a85084f6b402375ec5a213209d7209e9d6b8955b8ba634 [INFO] running `Command { std: "docker" "start" "-a" "c5fda33f15ce810219a85084f6b402375ec5a213209d7209e9d6b8955b8ba634", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling buffertk v0.8.0 [INFO] [stderr] Checking zerror v0.5.0 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking biometrics v0.8.0 [INFO] [stderr] Checking utf8path v0.4.0 [INFO] [stderr] Checking shvar v0.3.0 [INFO] [stderr] Checking minimal_signals v0.3.0 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking unix_sock v0.5.0 [INFO] [stderr] Compiling derive_util v0.4.0 [INFO] [stderr] Compiling prototk_derive v0.8.0 [INFO] [stderr] Compiling arrrg_derive v0.4.0 [INFO] [stderr] Checking arrrg v0.4.0 [INFO] [stderr] Checking rc_conf v0.4.0 [INFO] [stderr] Checking prototk v0.8.0 [INFO] [stderr] Checking one_two_eight v0.5.0 [INFO] [stderr] Checking tatl v0.7.0 [INFO] [stderr] Checking indicio v0.5.0 [INFO] [stderr] Checking rustrc v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:620:12 [INFO] [stdout] | [INFO] [stdout] 602 | let config = Arc::new(Pid1Configuration::from_options(&options)?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 603 | let state = Arc::new(Mutex::new(Pid1State::new(config))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 604 | let coord = Arc::new(Pid1Coordination::default()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 605 | let (reclaim, recv) = sync_channel(1); [INFO] [stdout] | ------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 606 | let reclaim_state = Arc::clone(&state); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 607 | let reclaim_coord = Arc::clone(&coord); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 608 | let reclaimer = std::thread::Builder::new() [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 612 | let converge_reclaim = reclaim.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 613 | let converge_state = Arc::clone(&state); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 614 | let converge_coord = Arc::clone(&coord); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 615 | let converger = std::thread::Builder::new() [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 620 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 621 | | options, [INFO] [stdout] 622 | | state, [INFO] [stdout] 623 | | coord, [INFO] [stdout] ... | [INFO] [stdout] 626 | | converger, [INFO] [stdout] 627 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:620:12 [INFO] [stdout] | [INFO] [stdout] 602 | let config = Arc::new(Pid1Configuration::from_options(&options)?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 603 | let state = Arc::new(Mutex::new(Pid1State::new(config))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 604 | let coord = Arc::new(Pid1Coordination::default()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 605 | let (reclaim, recv) = sync_channel(1); [INFO] [stdout] | ------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 606 | let reclaim_state = Arc::clone(&state); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 607 | let reclaim_coord = Arc::clone(&coord); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 608 | let reclaimer = std::thread::Builder::new() [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 612 | let converge_reclaim = reclaim.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 613 | let converge_state = Arc::clone(&state); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 614 | let converge_coord = Arc::clone(&coord); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 615 | let converger = std::thread::Builder::new() [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 620 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 621 | | options, [INFO] [stdout] 622 | | state, [INFO] [stdout] 623 | | coord, [INFO] [stdout] ... | [INFO] [stdout] 626 | | converger, [INFO] [stdout] 627 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustrc` (lib test) due to 3 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1131:12 [INFO] [stdout] | [INFO] [stdout] 1102 | let path = CString::new(path.as_str())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1103 | // setup wrapper [INFO] [stdout] 1104 | let wrapper = config [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1111 | let argv = argv [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1116 | let mut env: Vec = vec![]; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1131 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 1132 | | path, [INFO] [stdout] 1133 | | wrapper, [INFO] [stdout] 1134 | | argv, [INFO] [stdout] 1135 | | env, [INFO] [stdout] 1136 | | started, [INFO] [stdout] 1137 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1131:12 [INFO] [stdout] | [INFO] [stdout] 1102 | let path = CString::new(path.as_str())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1103 | // setup wrapper [INFO] [stdout] 1104 | let wrapper = config [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1111 | let argv = argv [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1116 | let mut env: Vec = vec![]; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1131 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 1132 | | path, [INFO] [stdout] 1133 | | wrapper, [INFO] [stdout] 1134 | | argv, [INFO] [stdout] 1135 | | env, [INFO] [stdout] 1136 | | started, [INFO] [stdout] 1137 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustrc` (lib) due to 3 previous errors [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "c5fda33f15ce810219a85084f6b402375ec5a213209d7209e9d6b8955b8ba634", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5fda33f15ce810219a85084f6b402375ec5a213209d7209e9d6b8955b8ba634", kill_on_drop: false }` [INFO] [stdout] c5fda33f15ce810219a85084f6b402375ec5a213209d7209e9d6b8955b8ba634