[INFO] fetching crate rustrawi 0.1.2... [INFO] checking rustrawi-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rustrawi 0.1.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate rustrawi 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rustrawi 0.1.2 [INFO] finished tweaking crates.io crate rustrawi 0.1.2 [INFO] tweaked toml for crates.io crate rustrawi 0.1.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ff88d5f95cfdc12bc4c45b9231d27fbf6dd2d6dfd9f777a649f352981650eb4f [INFO] running `Command { std: "docker" "start" "-a" "ff88d5f95cfdc12bc4c45b9231d27fbf6dd2d6dfd9f777a649f352981650eb4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ff88d5f95cfdc12bc4c45b9231d27fbf6dd2d6dfd9f777a649f352981650eb4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff88d5f95cfdc12bc4c45b9231d27fbf6dd2d6dfd9f777a649f352981650eb4f", kill_on_drop: false }` [INFO] [stdout] ff88d5f95cfdc12bc4c45b9231d27fbf6dd2d6dfd9f777a649f352981650eb4f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 06e48ef80c83cf68adc477cb5416ed0f611713ef68e61d3f9de581f1f73f3e59 [INFO] running `Command { std: "docker" "start" "-a" "06e48ef80c83cf68adc477cb5416ed0f611713ef68e61d3f9de581f1f73f3e59", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking rustrawi v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::stemmer::context::visitor::dont_stem_short_word::DontStemShortWord` [INFO] [stdout] --> src/stemmer/context.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::stemmer::context::visitor::dont_stem_short_word::DontStemShortWord; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::stemmer::context::visitor::dont_stem_short_word::DontStemShortWord` [INFO] [stdout] --> src/stemmer/context.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::stemmer::context::visitor::dont_stem_short_word::DontStemShortWord; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/stemmer/context.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 66 | todo!("step 4, 5"); [INFO] [stdout] | ------------------ any code following this expression is unreachable [INFO] [stdout] 67 | todo!("step 2, 3"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] = note: this warning originates in the macro `$crate::panic` which comes from the expansion of the macro `todo` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `word` [INFO] [stdout] --> src/stemmer.rs:93:32 [INFO] [stdout] | [INFO] [stdout] 93 | fn stem_plural_word(&self, word: &str) -> String { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_word` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `prefix_visitors` and `suffix_visitors` are never read [INFO] [stdout] --> src/stemmer/context.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Context<'a> { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 18 | prefix_visitors: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 19 | suffix_visitors: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dictionary.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 57 | fn read_lines_from_file

(filename: P) -> io::Result>> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | where P: AsRef, { [INFO] [stdout] 59 | let file = File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Ok(io::BufReader::new(file).lines()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stemmer/context.rs:31:31 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(original_word: &'a str, dictionary: &'a Dictionary, visitor_configuration: Option) -> Self { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let mut visitor_configuration = visitor_configuration.unwrap_or(VisitorConfiguration::default()); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | general_visitors: std::mem::replace(&mut visitor_configuration.general_visitors, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stemmer/context.rs:32:30 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(original_word: &'a str, dictionary: &'a Dictionary, visitor_configuration: Option) -> Self { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let mut visitor_configuration = visitor_configuration.unwrap_or(VisitorConfiguration::default()); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | prefix_visitors: std::mem::replace(&mut visitor_configuration.prefix_visitors, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stemmer/context.rs:33:30 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(original_word: &'a str, dictionary: &'a Dictionary, visitor_configuration: Option) -> Self { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let mut visitor_configuration = visitor_configuration.unwrap_or(VisitorConfiguration::default()); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | suffix_visitors: std::mem::replace(&mut visitor_configuration.suffix_visitors, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/stemmer/context.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 66 | todo!("step 4, 5"); [INFO] [stdout] | ------------------ any code following this expression is unreachable [INFO] [stdout] 67 | todo!("step 2, 3"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] = note: this warning originates in the macro `$crate::panic` which comes from the expansion of the macro `todo` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustrawi` (lib) due to 5 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/stemmer/context/visitor/dont_stem_short_word.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | let mut context = Context::new("iya", &dictionary, None); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/stemmer/context/visitor/dont_stem_short_word.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | let mut context = Context::new("kambing", &dictionary, None); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `word` [INFO] [stdout] --> src/stemmer.rs:93:32 [INFO] [stdout] | [INFO] [stdout] 93 | fn stem_plural_word(&self, word: &str) -> String { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_word` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `prefix_visitors` and `suffix_visitors` are never read [INFO] [stdout] --> src/stemmer/context.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Context<'a> { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 18 | prefix_visitors: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 19 | suffix_visitors: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dictionary.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 57 | fn read_lines_from_file

(filename: P) -> io::Result>> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | where P: AsRef, { [INFO] [stdout] 59 | let file = File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Ok(io::BufReader::new(file).lines()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stemmer/context.rs:31:31 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(original_word: &'a str, dictionary: &'a Dictionary, visitor_configuration: Option) -> Self { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let mut visitor_configuration = visitor_configuration.unwrap_or(VisitorConfiguration::default()); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | general_visitors: std::mem::replace(&mut visitor_configuration.general_visitors, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stemmer/context.rs:32:30 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(original_word: &'a str, dictionary: &'a Dictionary, visitor_configuration: Option) -> Self { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let mut visitor_configuration = visitor_configuration.unwrap_or(VisitorConfiguration::default()); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | prefix_visitors: std::mem::replace(&mut visitor_configuration.prefix_visitors, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stemmer/context.rs:33:30 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(original_word: &'a str, dictionary: &'a Dictionary, visitor_configuration: Option) -> Self { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let mut visitor_configuration = visitor_configuration.unwrap_or(VisitorConfiguration::default()); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | suffix_visitors: std::mem::replace(&mut visitor_configuration.suffix_visitors, Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustrawi` (lib test) due to 5 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "06e48ef80c83cf68adc477cb5416ed0f611713ef68e61d3f9de581f1f73f3e59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "06e48ef80c83cf68adc477cb5416ed0f611713ef68e61d3f9de581f1f73f3e59", kill_on_drop: false }` [INFO] [stdout] 06e48ef80c83cf68adc477cb5416ed0f611713ef68e61d3f9de581f1f73f3e59