[INFO] fetching crate rustpi_io 0.1.0... [INFO] checking rustpi_io-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rustpi_io 0.1.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate rustpi_io 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rustpi_io 0.1.0 [INFO] finished tweaking crates.io crate rustpi_io 0.1.0 [INFO] tweaked toml for crates.io crate rustpi_io 0.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] [stderr] Adding bitflags v0.3.3 (latest: v2.6.0) [INFO] [stderr] Adding bitflags v0.4.0 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding nix v0.6.0 (latest: v0.29.0) [INFO] [stderr] Adding rustc_version v0.1.7 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.1.20 (latest: v1.0.23) [INFO] [stderr] Adding spidev v0.3.0 (latest: v0.6.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c56f145d46fbeb4e730e16a9f9233ccecbd6a962a3795a2c8909fce9b8435bfe [INFO] running `Command { std: "docker" "start" "-a" "c56f145d46fbeb4e730e16a9f9233ccecbd6a962a3795a2c8909fce9b8435bfe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c56f145d46fbeb4e730e16a9f9233ccecbd6a962a3795a2c8909fce9b8435bfe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c56f145d46fbeb4e730e16a9f9233ccecbd6a962a3795a2c8909fce9b8435bfe", kill_on_drop: false }` [INFO] [stdout] c56f145d46fbeb4e730e16a9f9233ccecbd6a962a3795a2c8909fce9b8435bfe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4a25b3c0dfa7b3be48e8b9ff9f358fc73121ad8823c252543d3823a22899e2bd [INFO] running `Command { std: "docker" "start" "-a" "4a25b3c0dfa7b3be48e8b9ff9f358fc73121ad8823c252543d3823a22899e2bd", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling semver v0.1.20 [INFO] [stderr] Checking bitflags v0.4.0 [INFO] [stderr] Checking bitflags v0.3.3 [INFO] [stderr] Compiling rustc_version v0.1.7 [INFO] [stderr] Compiling nix v0.6.0 [INFO] [stderr] Checking spidev v0.3.0 [INFO] [stderr] Checking rustpi_io v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/gpio.rs:65:31 [INFO] [stdout] | [INFO] [stdout] 65 | GPIOMode::Read => try!(direction.write_all("in".as_bytes())), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/gpio.rs:66:32 [INFO] [stdout] | [INFO] [stdout] 66 | GPIOMode::Write => try!(direction.write_all("out".as_bytes())), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/gpio.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | try!(value.read_to_end(&mut buffer)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/gpio.rs:99:25 [INFO] [stdout] | [INFO] [stdout] 99 | let mut value = try!( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/gpio.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | try!(direction.write_all(buffer.as_bytes())); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/serial.rs:212:9 [INFO] [stdout] | [INFO] [stdout] 212 | try!(spi.configure(&options)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/serial.rs:247:37 [INFO] [stdout] | [INFO] [stdout] 247 | let mut buffer_read_count = try!(self.read_buffer.as_slice().read(buf)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/serial.rs:251:53 [INFO] [stdout] | [INFO] [stdout] 251 | buffer_read_count = buffer_read_count + try!(self.device.read(rest_buffer)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/serial.rs:279:17 [INFO] [stdout] | [INFO] [stdout] 279 | try!(self.device.read(rest_buffer)) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/serial.rs:318:17 [INFO] [stdout] | [INFO] [stdout] 318 | try!(self.device.transfer(&mut transfer)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/gpio.rs:65:31 [INFO] [stdout] | [INFO] [stdout] 65 | GPIOMode::Read => try!(direction.write_all("in".as_bytes())), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/gpio.rs:66:32 [INFO] [stdout] | [INFO] [stdout] 66 | GPIOMode::Write => try!(direction.write_all("out".as_bytes())), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/gpio.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | try!(value.read_to_end(&mut buffer)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/gpio.rs:99:25 [INFO] [stdout] | [INFO] [stdout] 99 | let mut value = try!( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/gpio.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | try!(direction.write_all(buffer.as_bytes())); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/serial.rs:212:9 [INFO] [stdout] | [INFO] [stdout] 212 | try!(spi.configure(&options)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/serial.rs:247:37 [INFO] [stdout] | [INFO] [stdout] 247 | let mut buffer_read_count = try!(self.read_buffer.as_slice().read(buf)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/serial.rs:251:53 [INFO] [stdout] | [INFO] [stdout] 251 | buffer_read_count = buffer_read_count + try!(self.device.read(rest_buffer)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/serial.rs:279:17 [INFO] [stdout] | [INFO] [stdout] 279 | try!(self.device.read(rest_buffer)) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/serial.rs:318:17 [INFO] [stdout] | [INFO] [stdout] 318 | try!(self.device.transfer(&mut transfer)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message contains an unused formatting placeholder [INFO] [stdout] --> src/gpio.rs:149:33 [INFO] [stdout] | [INFO] [stdout] 149 | panic!("file error: {}") [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: this message is not used as a format string when given without arguments, but will be in Rust 2021 [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add the missing argument [INFO] [stdout] | [INFO] [stdout] 149 | panic!("file error: {}", ...) [INFO] [stdout] | +++++ [INFO] [stdout] help: or add a "{}" format string to use the message literally [INFO] [stdout] | [INFO] [stdout] 149 | panic!("{}", "file error: {}") [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serial.rs:213:12 [INFO] [stdout] | [INFO] [stdout] 191 | let mut spi = match device { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | Ok(device) => device, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | Ok(device) => device, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | Ok(SerialPi { [INFO] [stdout] | ____________^ [INFO] [stdout] 214 | | device: spi, [INFO] [stdout] 215 | | com_mode: communication_mode, [INFO] [stdout] 216 | | read_buffer: Vec::with_capacity(buffer_capacity), [INFO] [stdout] 217 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustpi_io` (lib test) due to 2 previous errors; 11 warnings emitted [INFO] [stdout] warning: panic message contains an unused formatting placeholder [INFO] [stdout] --> src/gpio.rs:149:33 [INFO] [stdout] | [INFO] [stdout] 149 | panic!("file error: {}") [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: this message is not used as a format string when given without arguments, but will be in Rust 2021 [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add the missing argument [INFO] [stdout] | [INFO] [stdout] 149 | panic!("file error: {}", ...) [INFO] [stdout] | +++++ [INFO] [stdout] help: or add a "{}" format string to use the message literally [INFO] [stdout] | [INFO] [stdout] 149 | panic!("{}", "file error: {}") [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serial.rs:213:12 [INFO] [stdout] | [INFO] [stdout] 191 | let mut spi = match device { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | Ok(device) => device, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | Ok(device) => device, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | Ok(SerialPi { [INFO] [stdout] | ____________^ [INFO] [stdout] 214 | | device: spi, [INFO] [stdout] 215 | | com_mode: communication_mode, [INFO] [stdout] 216 | | read_buffer: Vec::with_capacity(buffer_capacity), [INFO] [stdout] 217 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustpi_io` (lib) due to 2 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4a25b3c0dfa7b3be48e8b9ff9f358fc73121ad8823c252543d3823a22899e2bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4a25b3c0dfa7b3be48e8b9ff9f358fc73121ad8823c252543d3823a22899e2bd", kill_on_drop: false }` [INFO] [stdout] 4a25b3c0dfa7b3be48e8b9ff9f358fc73121ad8823c252543d3823a22899e2bd