[INFO] fetching crate rustman 0.6.0... [INFO] checking rustman-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rustman 0.6.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate rustman 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rustman 0.6.0 [INFO] finished tweaking crates.io crate rustman 0.6.0 [INFO] tweaked toml for crates.io crate rustman 0.6.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate rustman 0.6.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d5323ae02eaf92e09f581a27d4b6a843aabd32072d3a2b0d43c197375234e718 [INFO] running `Command { std: "docker" "start" "-a" "d5323ae02eaf92e09f581a27d4b6a843aabd32072d3a2b0d43c197375234e718", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d5323ae02eaf92e09f581a27d4b6a843aabd32072d3a2b0d43c197375234e718", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d5323ae02eaf92e09f581a27d4b6a843aabd32072d3a2b0d43c197375234e718", kill_on_drop: false }` [INFO] [stdout] d5323ae02eaf92e09f581a27d4b6a843aabd32072d3a2b0d43c197375234e718 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ce3f82d3ebaf21710b43b1541f6fbc350f07a135542fe4637e80d6d380f52add [INFO] running `Command { std: "docker" "start" "-a" "ce3f82d3ebaf21710b43b1541f6fbc350f07a135542fe4637e80d6d380f52add", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.95 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.72 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Checking pin-project-lite v0.2.6 [INFO] [stderr] Compiling futures-core v0.3.15 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling cc v1.0.68 [INFO] [stderr] Compiling futures-task v0.3.15 [INFO] [stderr] Checking futures-sink v0.3.15 [INFO] [stderr] Compiling futures-channel v0.3.15 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking once_cell v1.7.2 [INFO] [stderr] Checking futures-io v0.3.15 [INFO] [stderr] Checking slab v0.4.3 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking tracing-core v0.1.18 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling httparse v1.4.1 [INFO] [stderr] Checking http v0.2.4 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling futures-macro v0.3.15 [INFO] [stderr] Compiling tokio v1.6.1 [INFO] [stderr] Compiling futures-util v0.3.15 [INFO] [stderr] Compiling indexmap v1.6.2 [INFO] [stderr] Checking tinyvec v1.2.0 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking unicode-bidi v0.3.5 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Compiling encoding_rs v0.8.28 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking httpdate v1.0.1 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking tracing v0.1.26 [INFO] [stderr] Checking ipnet v2.3.0 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking mio v0.7.11 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking socket2 v0.4.0 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking unicode-normalization v0.1.18 [INFO] [stderr] Checking http-body v0.4.2 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking webpki v0.21.4 [INFO] [stderr] Checking sct v0.6.1 [INFO] [stderr] Checking rustls v0.19.1 [INFO] [stderr] Checking webpki-roots v0.21.1 [INFO] [stderr] Checking tokio-util v0.6.7 [INFO] [stderr] Compiling pin-project-internal v1.0.7 [INFO] [stderr] Checking pin-project v1.0.7 [INFO] [stderr] Checking tokio-rustls v0.22.0 [INFO] [stderr] Checking h2 v0.3.3 [INFO] [stderr] Checking futures-executor v0.3.15 [INFO] [stderr] Checking futures v0.3.15 [INFO] [stderr] Checking hyper v0.14.8 [INFO] [stderr] Checking serde_urlencoded v0.7.0 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking hyper-rustls v0.22.1 [INFO] [stderr] Checking reqwest v0.11.3 [INFO] [stderr] Checking rustman v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:154:26 [INFO] [stdout] | [INFO] [stdout] 143 | let hit_c = hit.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | let progress = Arc::new(Mutex::new(Progress::new(raw_hits.len())?)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | [INFO] [stdout] 146 | let client = reqwest::Client::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let hit = hit_c.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let progress = progress.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let client = client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | [INFO] [stdout] 154 | tokio::spawn(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 155 | | let maybe_err = match is_bin(client, &name, &version).await { [INFO] [stdout] 156 | | Ok(is_bin) => { [INFO] [stdout] 157 | | if is_bin { [INFO] [stdout] ... | [INFO] [stdout] 172 | | maybe_err [INFO] [stdout] 173 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:212:22 [INFO] [stdout] | [INFO] [stdout] 209 | let client = client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | let online_versions = online_versions.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | let progress = progress.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 213 | | let maybe_err = match search_one_pkg(client, &p.0).await { [INFO] [stdout] 214 | | Ok(p) => { [INFO] [stdout] 215 | | online_versions.lock().expect(MUTEX_LOCK_ERROR).push(p); [INFO] [stdout] ... | [INFO] [stdout] 223 | | maybe_err [INFO] [stdout] 224 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:553:12 [INFO] [stdout] | [INFO] [stdout] 546 | let mut printer = StandardStream::stdout(ColorChoice::Auto); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 553 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 554 | | width, [INFO] [stdout] 555 | | step, [INFO] [stdout] 556 | | current, [INFO] [stdout] 557 | | printer, [INFO] [stdout] 558 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:154:26 [INFO] [stdout] | [INFO] [stdout] 143 | let hit_c = hit.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | let progress = Arc::new(Mutex::new(Progress::new(raw_hits.len())?)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | [INFO] [stdout] 146 | let client = reqwest::Client::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let hit = hit_c.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let progress = progress.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let client = client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | [INFO] [stdout] 154 | tokio::spawn(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 155 | | let maybe_err = match is_bin(client, &name, &version).await { [INFO] [stdout] 156 | | Ok(is_bin) => { [INFO] [stdout] 157 | | if is_bin { [INFO] [stdout] ... | [INFO] [stdout] 172 | | maybe_err [INFO] [stdout] 173 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:212:22 [INFO] [stdout] | [INFO] [stdout] 209 | let client = client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | let online_versions = online_versions.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | let progress = progress.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 213 | | let maybe_err = match search_one_pkg(client, &p.0).await { [INFO] [stdout] 214 | | Ok(p) => { [INFO] [stdout] 215 | | online_versions.lock().expect(MUTEX_LOCK_ERROR).push(p); [INFO] [stdout] ... | [INFO] [stdout] 223 | | maybe_err [INFO] [stdout] 224 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:553:12 [INFO] [stdout] | [INFO] [stdout] 546 | let mut printer = StandardStream::stdout(ColorChoice::Auto); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 553 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 554 | | width, [INFO] [stdout] 555 | | step, [INFO] [stdout] 556 | | current, [INFO] [stdout] 557 | | printer, [INFO] [stdout] 558 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustman` (bin "rustman") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustman` (bin "rustman" test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "ce3f82d3ebaf21710b43b1541f6fbc350f07a135542fe4637e80d6d380f52add", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ce3f82d3ebaf21710b43b1541f6fbc350f07a135542fe4637e80d6d380f52add", kill_on_drop: false }` [INFO] [stdout] ce3f82d3ebaf21710b43b1541f6fbc350f07a135542fe4637e80d6d380f52add