[INFO] fetching crate rustdoc-index 0.7.1... [INFO] checking rustdoc-index-0.7.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rustdoc-index 0.7.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate rustdoc-index 0.7.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rustdoc-index 0.7.1 [INFO] finished tweaking crates.io crate rustdoc-index 0.7.1 [INFO] tweaked toml for crates.io crate rustdoc-index 0.7.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate rustdoc-index 0.7.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1b032fb45b7d9bb93922e2e55aaed765530dfd008cbc86bbd2531316d2c81081 [INFO] running `Command { std: "docker" "start" "-a" "1b032fb45b7d9bb93922e2e55aaed765530dfd008cbc86bbd2531316d2c81081", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1b032fb45b7d9bb93922e2e55aaed765530dfd008cbc86bbd2531316d2c81081", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b032fb45b7d9bb93922e2e55aaed765530dfd008cbc86bbd2531316d2c81081", kill_on_drop: false }` [INFO] [stdout] 1b032fb45b7d9bb93922e2e55aaed765530dfd008cbc86bbd2531316d2c81081 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8149bf2ed7c26d955acb4c10c8be2430f8d38074889ef4ac0e10f4e581f34a6f [INFO] running `Command { std: "docker" "start" "-a" "8149bf2ed7c26d955acb4c10c8be2430f8d38074889ef4ac0e10f4e581f34a6f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling serde_derive v1.0.138 [INFO] [stderr] Compiling serde v1.0.138 [INFO] [stderr] Compiling crossbeam-utils v0.8.10 [INFO] [stderr] Checking once_cell v1.12.1 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.9 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Compiling semver v1.0.12 [INFO] [stderr] Compiling unicode-segmentation v1.9.0 [INFO] [stderr] Compiling serde_json v1.0.82 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling camino v1.0.9 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Checking crossbeam-channel v0.5.5 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking either v1.7.0 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking regex-syntax v0.6.26 [INFO] [stderr] Checking unescape v0.1.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Compiling serde_repr v0.1.8 [INFO] [stderr] Checking tokio v1.19.2 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking cargo-platform v0.1.2 [INFO] [stderr] Checking cargo_metadata v0.15.0 [INFO] [stderr] Checking rustdoc-index v0.7.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `f` and `d` are never read [INFO] [stdout] --> src/doc.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Crate { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | f: F, [INFO] [stdout] | ^ [INFO] [stdout] 13 | q: Vec, [INFO] [stdout] 14 | d: Vec, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `Crate` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `generics`, and `kind` are never read [INFO] [stdout] --> src/doc.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct Type1_55_0 { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 53 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 54 | generics: Option>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 55 | kind: ItemType [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Type1_55_0` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `generics`, and `kind` are never read [INFO] [stdout] --> src/doc.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 67 | pub struct Type1_58_0 { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 68 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 69 | generics: Option>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 70 | kind: ItemType [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Type1_58_0` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 34 | src: P [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | ) -> Result>, Error> { [INFO] [stdout] 36 | let file = File::open(src.as_ref())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | // one crate per one line [INFO] [stdout] 39 | let mut lines = reader.lines(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | lines.next(); // remove first line [INFO] [stdout] 41 | Ok(lines [INFO] [stdout] | ________^ [INFO] [stdout] 42 | | .par_bridge() [INFO] [stdout] 43 | | .map(|l| l.map_err(Error::from)) [INFO] [stdout] 44 | | .filter(|l| { [INFO] [stdout] ... | [INFO] [stdout] 55 | | }) [INFO] [stdout] 56 | | .map(|l: Result| l.and_then(parse_line))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:85:11 [INFO] [stdout] | [INFO] [stdout] 85 | match serde_json::from_str(&body) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustdoc-index` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `f` and `d` are never read [INFO] [stdout] --> src/doc.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Crate { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | f: F, [INFO] [stdout] | ^ [INFO] [stdout] 13 | q: Vec, [INFO] [stdout] 14 | d: Vec, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `Crate` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `generics`, and `kind` are never read [INFO] [stdout] --> src/doc.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct Type1_55_0 { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 53 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 54 | generics: Option>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 55 | kind: ItemType [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Type1_55_0` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `generics`, and `kind` are never read [INFO] [stdout] --> src/doc.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 67 | pub struct Type1_58_0 { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 68 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 69 | generics: Option>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 70 | kind: ItemType [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Type1_58_0` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 34 | src: P [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | ) -> Result>, Error> { [INFO] [stdout] 36 | let file = File::open(src.as_ref())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | // one crate per one line [INFO] [stdout] 39 | let mut lines = reader.lines(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | lines.next(); // remove first line [INFO] [stdout] 41 | Ok(lines [INFO] [stdout] | ________^ [INFO] [stdout] 42 | | .par_bridge() [INFO] [stdout] 43 | | .map(|l| l.map_err(Error::from)) [INFO] [stdout] 44 | | .filter(|l| { [INFO] [stdout] ... | [INFO] [stdout] 55 | | }) [INFO] [stdout] 56 | | .map(|l: Result| l.and_then(parse_line))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:85:11 [INFO] [stdout] | [INFO] [stdout] 85 | match serde_json::from_str(&body) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/location.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 209 | let stdout = child.stdout.take().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | BufReader::new(stdout).lines() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/location.rs:219:27 [INFO] [stdout] | [INFO] [stdout] 219 | .find_map(|s| find(s, krate_name, tail, ty).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustdoc-index` (lib test) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8149bf2ed7c26d955acb4c10c8be2430f8d38074889ef4ac0e10f4e581f34a6f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8149bf2ed7c26d955acb4c10c8be2430f8d38074889ef4ac0e10f4e581f34a6f", kill_on_drop: false }` [INFO] [stdout] 8149bf2ed7c26d955acb4c10c8be2430f8d38074889ef4ac0e10f4e581f34a6f