[INFO] fetching crate rustc_span 0.1.2... [INFO] checking rustc_span-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rustc_span 0.1.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate rustc_span 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rustc_span 0.1.2 [INFO] finished tweaking crates.io crate rustc_span 0.1.2 [INFO] tweaked toml for crates.io crate rustc_span 0.1.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 75 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding memmap2 v0.2.3 (latest: v0.9.4) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding rustc-rayon v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding rustc-rayon-core v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d0757ef80bddafef494c6a71e567874ebb29fe9518b4e0cf09c30628c5767251 [INFO] running `Command { std: "docker" "start" "-a" "d0757ef80bddafef494c6a71e567874ebb29fe9518b4e0cf09c30628c5767251", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d0757ef80bddafef494c6a71e567874ebb29fe9518b4e0cf09c30628c5767251", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d0757ef80bddafef494c6a71e567874ebb29fe9518b4e0cf09c30628c5767251", kill_on_drop: false }` [INFO] [stdout] d0757ef80bddafef494c6a71e567874ebb29fe9518b4e0cf09c30628c5767251 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 71f82b1a9e0dc1c06dd63a994719ab5c3c65dfcad1f79bdda3c9ce72022cf774 [INFO] running `Command { std: "docker" "start" "-a" "71f82b1a9e0dc1c06dd63a994719ab5c3c65dfcad1f79bdda3c9ce72022cf774", kill_on_drop: false }` [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling rustc-rayon-core v0.3.2 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking jobserver v0.1.32 [INFO] [stderr] Checking memmap2 v0.2.3 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking rustc-rayon-core v0.5.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking sha-1 v0.10.1 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking rustc-rayon v0.3.2 [INFO] [stderr] Checking rustc-rayon v0.5.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking rustc_data_structures v0.1.2 [INFO] [stderr] Checking rustc_span v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/caching_source_map_view.rs:74:25 [INFO] [stdout] | [INFO] [stdout] 62 | let files = source_map.files(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let first_file = files[0].clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | let entry = CacheEntry { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | line_cache: [entry.clone(), entry.clone(), entry], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/caching_source_map_view.rs:111:14 [INFO] [stdout] | [INFO] [stdout] 102 | let new_file_and_idx = if !file_contains(&self.line_cache[oldest].file, pos) { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | Some(( [INFO] [stdout] | ______________^ [INFO] [stdout] 112 | | cache_entry.file.clone(), [INFO] [stdout] 113 | | cache_entry.line_number, [INFO] [stdout] 114 | | pos - cache_entry.line.start, [INFO] [stdout] 115 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/caching_source_map_view.rs:234:14 [INFO] [stdout] | [INFO] [stdout] 167 | let new_file_and_idx = if !file_contains(&self.line_cache[oldest].file, span_data.lo) { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | let new_file_and_idx = self.file_for_position(span_data.lo)?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | let new_file_and_idx = Some((lo.file.clone(), lo.file_index)); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | Some(( [INFO] [stdout] | ______________^ [INFO] [stdout] 235 | | lo.file.clone(), [INFO] [stdout] 236 | | lo.line_number, [INFO] [stdout] 237 | | span_data.lo - lo.line.start, [INFO] [stdout] 238 | | hi.line_number, [INFO] [stdout] 239 | | span_data.hi - hi.line.start, [INFO] [stdout] 240 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source_map.rs:186:20 [INFO] [stdout] | [INFO] [stdout] 180 | file_loader: Box, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | files: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source_map.rs:204:12 [INFO] [stdout] | [INFO] [stdout] 204 | Ok(self.new_source_file(filename, src)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source_map.rs:492:12 [INFO] [stdout] | [INFO] [stdout] 482 | let lo = self.lookup_char_pos(sp.lo()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 483 | trace!(?lo); [INFO] [stdout] 484 | let hi = self.lookup_char_pos(sp.hi()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 492 | Ok((lo, hi)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source_map.rs:553:12 [INFO] [stdout] | [INFO] [stdout] 509 | let (lo, hi) = self.is_valid_span(sp)?; [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 553 | Ok(FileLines { [INFO] [stdout] | ____________^ [INFO] [stdout] 554 | | file: lo.file, [INFO] [stdout] 555 | | lines, [INFO] [stdout] 556 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustc_span` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/caching_source_map_view.rs:74:25 [INFO] [stdout] | [INFO] [stdout] 62 | let files = source_map.files(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let first_file = files[0].clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | let entry = CacheEntry { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | line_cache: [entry.clone(), entry.clone(), entry], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/caching_source_map_view.rs:111:14 [INFO] [stdout] | [INFO] [stdout] 102 | let new_file_and_idx = if !file_contains(&self.line_cache[oldest].file, pos) { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | Some(( [INFO] [stdout] | ______________^ [INFO] [stdout] 112 | | cache_entry.file.clone(), [INFO] [stdout] 113 | | cache_entry.line_number, [INFO] [stdout] 114 | | pos - cache_entry.line.start, [INFO] [stdout] 115 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/caching_source_map_view.rs:234:14 [INFO] [stdout] | [INFO] [stdout] 167 | let new_file_and_idx = if !file_contains(&self.line_cache[oldest].file, span_data.lo) { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | let new_file_and_idx = self.file_for_position(span_data.lo)?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | let new_file_and_idx = Some((lo.file.clone(), lo.file_index)); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | Some(( [INFO] [stdout] | ______________^ [INFO] [stdout] 235 | | lo.file.clone(), [INFO] [stdout] 236 | | lo.line_number, [INFO] [stdout] 237 | | span_data.lo - lo.line.start, [INFO] [stdout] 238 | | hi.line_number, [INFO] [stdout] 239 | | span_data.hi - hi.line.start, [INFO] [stdout] 240 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source_map.rs:186:20 [INFO] [stdout] | [INFO] [stdout] 180 | file_loader: Box, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | files: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source_map.rs:204:12 [INFO] [stdout] | [INFO] [stdout] 204 | Ok(self.new_source_file(filename, src)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source_map.rs:492:12 [INFO] [stdout] | [INFO] [stdout] 482 | let lo = self.lookup_char_pos(sp.lo()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 483 | trace!(?lo); [INFO] [stdout] 484 | let hi = self.lookup_char_pos(sp.hi()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 492 | Ok((lo, hi)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source_map.rs:553:12 [INFO] [stdout] | [INFO] [stdout] 509 | let (lo, hi) = self.is_valid_span(sp)?; [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 553 | Ok(FileLines { [INFO] [stdout] | ____________^ [INFO] [stdout] 554 | | file: lo.file, [INFO] [stdout] 555 | | lines, [INFO] [stdout] 556 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustc_span` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "71f82b1a9e0dc1c06dd63a994719ab5c3c65dfcad1f79bdda3c9ce72022cf774", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "71f82b1a9e0dc1c06dd63a994719ab5c3c65dfcad1f79bdda3c9ce72022cf774", kill_on_drop: false }` [INFO] [stdout] 71f82b1a9e0dc1c06dd63a994719ab5c3c65dfcad1f79bdda3c9ce72022cf774