[INFO] fetching crate rustboy-core 0.2.0... [INFO] checking rustboy-core-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rustboy-core 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate rustboy-core 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rustboy-core 0.2.0 [INFO] finished tweaking crates.io crate rustboy-core 0.2.0 [INFO] tweaked toml for crates.io crate rustboy-core 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 93 packages to latest compatible versions [INFO] [stderr] Adding assert_hex v0.2.2 (latest: v0.4.1) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding mockall v0.11.4 (latest: v0.13.0) [INFO] [stderr] Adding mockall_derive v0.11.4 (latest: v0.13.0) [INFO] [stderr] Adding predicates v2.1.5 (latest: v3.1.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding termtree v0.4.1 (latest: v0.5.1) [INFO] [stderr] Adding test-case v1.2.3 (latest: v3.3.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d211c63e1a2c78c78d940cef2309bec966f50cf10f67c0525c8d58ec3aca9d4d [INFO] running `Command { std: "docker" "start" "-a" "d211c63e1a2c78c78d940cef2309bec966f50cf10f67c0525c8d58ec3aca9d4d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d211c63e1a2c78c78d940cef2309bec966f50cf10f67c0525c8d58ec3aca9d4d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d211c63e1a2c78c78d940cef2309bec966f50cf10f67c0525c8d58ec3aca9d4d", kill_on_drop: false }` [INFO] [stdout] d211c63e1a2c78c78d940cef2309bec966f50cf10f67c0525c8d58ec3aca9d4d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6d8c16a00cff216c99357b44d7b3a2178cc49306feee748763946956f3db75da [INFO] running `Command { std: "docker" "start" "-a" "6d8c16a00cff216c99357b44d7b3a2178cc49306feee748763946956f3db75da", kill_on_drop: false }` [INFO] [stderr] Checking predicates-core v1.0.8 [INFO] [stderr] Compiling test-case v1.2.3 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking assert_hex v0.2.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Compiling mockall_derive v0.11.4 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking predicates-tree v1.0.11 [INFO] [stderr] Checking predicates v2.1.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking mockall v0.11.4 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling serde_with_macros v3.9.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_with v3.9.0 [INFO] [stderr] Checking rustboy-core v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `get_lower_byte` is never used [INFO] [stdout] --> src/internal/util/bit_util.rs:92:6 [INFO] [stdout] | [INFO] [stdout] 84 | pub trait BitUtil { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 92 | fn get_lower_byte(&self) -> u8; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `reverse` is never used [INFO] [stdout] --> src/internal/util/bit_util.rs:99:6 [INFO] [stdout] | [INFO] [stdout] 97 | pub trait ByteUtil { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] 98 | fn interleave_with(&self, byte: u8) -> u16; [INFO] [stdout] 99 | fn reverse(&self) -> u8; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `set_high_byte` and `set_low_byte` are never used [INFO] [stdout] --> src/internal/util/bit_util.rs:105:6 [INFO] [stdout] | [INFO] [stdout] 102 | pub trait WordUtil { [INFO] [stdout] | -------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 105 | fn set_high_byte(&self, byte: u8) -> Self; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 106 | fn set_low_byte(&self, byte: u8) -> Self; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `load_byte` is never used [INFO] [stdout] --> src/internal/memory/mbc.rs:7:6 [INFO] [stdout] | [INFO] [stdout] 6 | pub trait Loadable { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] 7 | fn load_byte(&mut self, address: usize, value: u8); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `compatibility_byte`, `is_licensed_by_nintendo`, `fourth_title_letter`, `title_checksum`, and `cgb_mode` are never used [INFO] [stdout] --> src/internal/memory/mbc.rs:12:6 [INFO] [stdout] | [INFO] [stdout] 11 | pub trait MBC: Memory + Loadable { [INFO] [stdout] | --- methods in this trait [INFO] [stdout] 12 | fn compatibility_byte(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 16 | fn is_licensed_by_nintendo(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 29 | fn fourth_title_letter(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | fn title_checksum(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | fn cgb_mode(&self) -> CGBMode { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `interrupts_enabled`, `enable_interrupts`, `disable_interrupts`, and `clear_interrupt` are never used [INFO] [stdout] --> src/internal/cpu/interrupts.rs:52:6 [INFO] [stdout] | [INFO] [stdout] 50 | pub trait InterruptController { [INFO] [stdout] | ------------------- methods in this trait [INFO] [stdout] 51 | fn get_requested_interrupt(&self) -> Option; [INFO] [stdout] 52 | fn interrupts_enabled(&self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 53 | fn enable_interrupts(&mut self); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 54 | fn disable_interrupts(&mut self); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 55 | fn request_interrupt(&mut self, interrupt: Interrupt); [INFO] [stdout] 56 | fn clear_interrupt(&mut self, interrupt: Interrupt); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `AudioController` is never used [INFO] [stdout] --> src/internal/controllers/audio.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 19 | pub trait AudioController {} [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal/memory/vram.rs:206:69 [INFO] [stdout] | [INFO] [stdout] 206 | .flat_map(|(tile_index, Tile { chr_code, attributes })| tile_data_view [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 207 | | .get_tile_data(attributes.tile_bank_index(), chr_code) [INFO] [stdout] 208 | | .get_color_indices(pixel_row_offset, attributes.flip_horizontal(), attributes.flip_vertical()) [INFO] [stdout] 209 | | .skip(if tile_index == 0 { pixel_column_offset as usize } else { 0 }) [INFO] [stdout] | |_____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal/memory/vram.rs:234:55 [INFO] [stdout] | [INFO] [stdout] 234 | .flat_map(|Tile { chr_code, attributes }| tile_data_view [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 235 | | .get_tile_data(attributes.tile_bank_index(), chr_code) [INFO] [stdout] 236 | | .get_color_indices(pixel_row_offset, attributes.flip_horizontal(), attributes.flip_vertical()) [INFO] [stdout] | |______________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal/memory/vram.rs:268:9 [INFO] [stdout] | [INFO] [stdout] 260 | let bank_0_colors = (tile_offset..=(tile_offset + 15)) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 264 | let bank_1_colors = (tile_offset..=(tile_offset + 15)) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 268 | bank_0_colors.chain(bank_1_colors).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustboy-core` (lib) due to 4 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `get_lower_byte` is never used [INFO] [stdout] --> src/internal/util/bit_util.rs:92:6 [INFO] [stdout] | [INFO] [stdout] 84 | pub trait BitUtil { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 92 | fn get_lower_byte(&self) -> u8; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `reverse` is never used [INFO] [stdout] --> src/internal/util/bit_util.rs:99:6 [INFO] [stdout] | [INFO] [stdout] 97 | pub trait ByteUtil { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] 98 | fn interleave_with(&self, byte: u8) -> u16; [INFO] [stdout] 99 | fn reverse(&self) -> u8; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `set_high_byte` and `set_low_byte` are never used [INFO] [stdout] --> src/internal/util/bit_util.rs:105:6 [INFO] [stdout] | [INFO] [stdout] 102 | pub trait WordUtil { [INFO] [stdout] | -------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 105 | fn set_high_byte(&self, byte: u8) -> Self; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 106 | fn set_low_byte(&self, byte: u8) -> Self; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `compatibility_byte`, `is_licensed_by_nintendo`, `fourth_title_letter`, `title_checksum`, and `cgb_mode` are never used [INFO] [stdout] --> src/internal/memory/mbc.rs:12:6 [INFO] [stdout] | [INFO] [stdout] 11 | pub trait MBC: Memory + Loadable { [INFO] [stdout] | --- methods in this trait [INFO] [stdout] 12 | fn compatibility_byte(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 16 | fn is_licensed_by_nintendo(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 29 | fn fourth_title_letter(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | fn title_checksum(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | fn cgb_mode(&self) -> CGBMode { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `interrupts_enabled` is never used [INFO] [stdout] --> src/internal/cpu/interrupts.rs:52:6 [INFO] [stdout] | [INFO] [stdout] 50 | pub trait InterruptController { [INFO] [stdout] | ------------------- method in this trait [INFO] [stdout] 51 | fn get_requested_interrupt(&self) -> Option; [INFO] [stdout] 52 | fn interrupts_enabled(&self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `AudioController` is never used [INFO] [stdout] --> src/internal/controllers/audio.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 19 | pub trait AudioController {} [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal/memory/vram.rs:206:69 [INFO] [stdout] | [INFO] [stdout] 206 | .flat_map(|(tile_index, Tile { chr_code, attributes })| tile_data_view [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 207 | | .get_tile_data(attributes.tile_bank_index(), chr_code) [INFO] [stdout] 208 | | .get_color_indices(pixel_row_offset, attributes.flip_horizontal(), attributes.flip_vertical()) [INFO] [stdout] 209 | | .skip(if tile_index == 0 { pixel_column_offset as usize } else { 0 }) [INFO] [stdout] | |_____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal/memory/vram.rs:234:55 [INFO] [stdout] | [INFO] [stdout] 234 | .flat_map(|Tile { chr_code, attributes }| tile_data_view [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 235 | | .get_tile_data(attributes.tile_bank_index(), chr_code) [INFO] [stdout] 236 | | .get_color_indices(pixel_row_offset, attributes.flip_horizontal(), attributes.flip_vertical()) [INFO] [stdout] | |______________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal/memory/vram.rs:268:9 [INFO] [stdout] | [INFO] [stdout] 260 | let bank_0_colors = (tile_offset..=(tile_offset + 15)) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 264 | let bank_1_colors = (tile_offset..=(tile_offset + 15)) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 268 | bank_0_colors.chain(bank_1_colors).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustboy-core` (lib test) due to 4 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6d8c16a00cff216c99357b44d7b3a2178cc49306feee748763946956f3db75da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d8c16a00cff216c99357b44d7b3a2178cc49306feee748763946956f3db75da", kill_on_drop: false }` [INFO] [stdout] 6d8c16a00cff216c99357b44d7b3a2178cc49306feee748763946956f3db75da