[INFO] fetching crate rust_redlock 0.4.0... [INFO] checking rust_redlock-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rust_redlock 0.4.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate rust_redlock 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rust_redlock 0.4.0 [INFO] finished tweaking crates.io crate rust_redlock 0.4.0 [INFO] tweaked toml for crates.io crate rust_redlock 0.4.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] [stderr] Adding idna v0.1.5 (latest: v1.0.2) [INFO] [stderr] Adding lazy_static v0.2.11 (latest: v1.5.0) [INFO] [stderr] Adding percent-encoding v1.0.1 (latest: v2.3.1) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding rand v0.3.23 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding redis v0.5.4 (latest: v0.26.1) [INFO] [stderr] Adding sha1 v0.1.1 (latest: v0.10.6) [INFO] [stderr] Adding url v1.7.2 (latest: v2.5.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8c1f13ed527da853287ad772f1c9f7a769049ca8c4a57b81dfffc6a853260dd2 [INFO] running `Command { std: "docker" "start" "-a" "8c1f13ed527da853287ad772f1c9f7a769049ca8c4a57b81dfffc6a853260dd2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8c1f13ed527da853287ad772f1c9f7a769049ca8c4a57b81dfffc6a853260dd2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c1f13ed527da853287ad772f1c9f7a769049ca8c4a57b81dfffc6a853260dd2", kill_on_drop: false }` [INFO] [stdout] 8c1f13ed527da853287ad772f1c9f7a769049ca8c4a57b81dfffc6a853260dd2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 518dc3f5284e3c7505be63cbc2f16d7465afe8e2891e7ac6aec04943778b35c7 [INFO] running `Command { std: "docker" "start" "-a" "518dc3f5284e3c7505be63cbc2f16d7465afe8e2891e7ac6aec04943778b35c7", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking sha1 v0.1.1 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking redis v0.5.4 [INFO] [stderr] Checking rust_redlock v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/redlock.rs:113:33 [INFO] [stdout] | [INFO] [stdout] 113 | -> RedlockResult<(Lock)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 113 - -> RedlockResult<(Lock)> { [INFO] [stdout] 113 + -> RedlockResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/redlock.rs:113:33 [INFO] [stdout] | [INFO] [stdout] 113 | -> RedlockResult<(Lock)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 113 - -> RedlockResult<(Lock)> { [INFO] [stdout] 113 + -> RedlockResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/scripts.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / lazy_static! { [INFO] [stdout] 4 | | pub static ref LOCK: redis::Script = redis::Script::new(" [INFO] [stdout] 5 | | return redis.call(\"set\", KEYS[1], ARGV[1], \"NX\", \"PX\", ARGV[2]) [INFO] [stdout] 6 | | "); [INFO] [stdout] ... | [INFO] [stdout] 22 | | "); [INFO] [stdout] 23 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/scripts.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / lazy_static! { [INFO] [stdout] 4 | | pub static ref LOCK: redis::Script = redis::Script::new(" [INFO] [stdout] 5 | | return redis.call(\"set\", KEYS[1], ARGV[1], \"NX\", \"PX\", ARGV[2]) [INFO] [stdout] 6 | | "); [INFO] [stdout] ... | [INFO] [stdout] 22 | | "); [INFO] [stdout] 23 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/scripts.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / lazy_static! { [INFO] [stdout] 4 | | pub static ref LOCK: redis::Script = redis::Script::new(" [INFO] [stdout] 5 | | return redis.call(\"set\", KEYS[1], ARGV[1], \"NX\", \"PX\", ARGV[2]) [INFO] [stdout] 6 | | "); [INFO] [stdout] ... | [INFO] [stdout] 22 | | "); [INFO] [stdout] 23 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/redlock.rs:287:5 [INFO] [stdout] | [INFO] [stdout] 287 | / lazy_static! { [INFO] [stdout] 288 | | static ref REDLOCK: Redlock = Redlock::new::<&str>(Config { [INFO] [stdout] 289 | | addrs: vec!["redis://127.0.0.1"], [INFO] [stdout] 290 | | retry_count: 10, [INFO] [stdout] ... | [INFO] [stdout] 296 | | static ref REDIS_CLI: redis::Client = redis::Client::open("redis://127.0.0.1").unwrap(); [INFO] [stdout] 297 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/redlock.rs:287:5 [INFO] [stdout] | [INFO] [stdout] 287 | / lazy_static! { [INFO] [stdout] 288 | | static ref REDLOCK: Redlock = Redlock::new::<&str>(Config { [INFO] [stdout] 289 | | addrs: vec!["redis://127.0.0.1"], [INFO] [stdout] 290 | | retry_count: 10, [INFO] [stdout] ... | [INFO] [stdout] 296 | | static ref REDIS_CLI: redis::Client = redis::Client::open("redis://127.0.0.1").unwrap(); [INFO] [stdout] 297 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/scripts.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / lazy_static! { [INFO] [stdout] 4 | | pub static ref LOCK: redis::Script = redis::Script::new(" [INFO] [stdout] 5 | | return redis.call(\"set\", KEYS[1], ARGV[1], \"NX\", \"PX\", ARGV[2]) [INFO] [stdout] 6 | | "); [INFO] [stdout] ... | [INFO] [stdout] 22 | | "); [INFO] [stdout] 23 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/scripts.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / lazy_static! { [INFO] [stdout] 4 | | pub static ref LOCK: redis::Script = redis::Script::new(" [INFO] [stdout] 5 | | return redis.call(\"set\", KEYS[1], ARGV[1], \"NX\", \"PX\", ARGV[2]) [INFO] [stdout] 6 | | "); [INFO] [stdout] ... | [INFO] [stdout] 22 | | "); [INFO] [stdout] 23 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/scripts.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / lazy_static! { [INFO] [stdout] 4 | | pub static ref LOCK: redis::Script = redis::Script::new(" [INFO] [stdout] 5 | | return redis.call(\"set\", KEYS[1], ARGV[1], \"NX\", \"PX\", ARGV[2]) [INFO] [stdout] 6 | | "); [INFO] [stdout] ... | [INFO] [stdout] 22 | | "); [INFO] [stdout] 23 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redlock.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn new(config: Config) -> RedlockResult { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let mut clients = Vec::with_capacity(config.addrs.len()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(Redlock { [INFO] [stdout] | ____________^ [INFO] [stdout] 89 | | clients, [INFO] [stdout] 90 | | retry_count: config.retry_count, [INFO] [stdout] 91 | | retry_delay: config.retry_delay, [INFO] [stdout] ... | [INFO] [stdout] 94 | | quorum, [INFO] [stdout] 95 | | }) [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redlock.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn new(config: Config) -> RedlockResult { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let mut clients = Vec::with_capacity(config.addrs.len()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(Redlock { [INFO] [stdout] | ____________^ [INFO] [stdout] 89 | | clients, [INFO] [stdout] 90 | | retry_count: config.retry_count, [INFO] [stdout] 91 | | retry_delay: config.retry_delay, [INFO] [stdout] ... | [INFO] [stdout] 94 | | quorum, [INFO] [stdout] 95 | | }) [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Result::::is_ok` that must be used [INFO] [stdout] --> src/redlock.rs:165:25 [INFO] [stdout] | [INFO] [stdout] 165 | lock.unlock().is_ok(); // Just ingore the result [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you intended to assert that this is ok, consider `.unwrap()` instead [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 165 | let _ = lock.unlock().is_ok(); // Just ingore the result [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Result::::is_ok` that must be used [INFO] [stdout] --> src/redlock.rs:174:29 [INFO] [stdout] | [INFO] [stdout] 174 | ... lock.unlock().is_ok(); // Just ingore the result [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you intended to assert that this is ok, consider `.unwrap()` instead [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 174 | let _ = lock.unlock().is_ok(); // Just ingore the result [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Result::::is_ok` that must be used [INFO] [stdout] --> src/redlock.rs:165:25 [INFO] [stdout] | [INFO] [stdout] 165 | lock.unlock().is_ok(); // Just ingore the result [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you intended to assert that this is ok, consider `.unwrap()` instead [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 165 | let _ = lock.unlock().is_ok(); // Just ingore the result [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Result::::is_ok` that must be used [INFO] [stdout] --> src/redlock.rs:174:29 [INFO] [stdout] | [INFO] [stdout] 174 | ... lock.unlock().is_ok(); // Just ingore the result [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you intended to assert that this is ok, consider `.unwrap()` instead [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 174 | let _ = lock.unlock().is_ok(); // Just ingore the result [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_redlock` (lib) due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rust_redlock` (lib test) due to 2 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "518dc3f5284e3c7505be63cbc2f16d7465afe8e2891e7ac6aec04943778b35c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "518dc3f5284e3c7505be63cbc2f16d7465afe8e2891e7ac6aec04943778b35c7", kill_on_drop: false }` [INFO] [stdout] 518dc3f5284e3c7505be63cbc2f16d7465afe8e2891e7ac6aec04943778b35c7