[INFO] fetching crate rust_mc_proto 0.1.16... [INFO] checking rust_mc_proto-0.1.16 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rust_mc_proto 0.1.16 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate rust_mc_proto 0.1.16 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rust_mc_proto 0.1.16 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate rust_mc_proto 0.1.16 [INFO] tweaked toml for crates.io crate rust_mc_proto 0.1.16 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate rust_mc_proto 0.1.16 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e5e8d31aba35c54f63b5199b098c74ca4089557d0e4bfee00f8a237488162832 [INFO] running `Command { std: "docker" "start" "-a" "e5e8d31aba35c54f63b5199b098c74ca4089557d0e4bfee00f8a237488162832", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e5e8d31aba35c54f63b5199b098c74ca4089557d0e4bfee00f8a237488162832", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5e8d31aba35c54f63b5199b098c74ca4089557d0e4bfee00f8a237488162832", kill_on_drop: false }` [INFO] [stdout] e5e8d31aba35c54f63b5199b098c74ca4089557d0e4bfee00f8a237488162832 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7223868f6ad5368437efae7d9ff81e51fa0930d71d6276ba78376fccd3895e54 [INFO] running `Command { std: "docker" "start" "-a" "7223868f6ad5368437efae7d9ff81e51fa0930d71d6276ba78376fccd3895e54", kill_on_drop: false }` [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking bytebuffer v2.3.0 [INFO] [stderr] Checking flate2 v1.0.32 [INFO] [stderr] Checking rust_mc_proto v0.1.16 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 73 | let stream: TcpStream = match TcpStream::connect(&addr) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | Ok(i) => i, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Ok(MinecraftConnection { [INFO] [stdout] | ____________^ [INFO] [stdout] 79 | | stream, [INFO] [stdout] 80 | | #[cfg(feature = "atomic_compression")] [INFO] [stdout] 81 | | compression: Arc::new(AtomicUsize::new(usize::MAX)), [INFO] [stdout] ... | [INFO] [stdout] 84 | | compression_type: 1, [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:131:26 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn new(stream: T) -> MinecraftConnection { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | compression: Arc::new(AtomicUsize::new(usize::MAX)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:248:5 [INFO] [stdout] | [INFO] [stdout] 246 | let mut encoder = ZlibEncoder::new(Vec::new(), Compression::new(compression)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | encoder.write_all(bytes).or(Err(ProtocolError::ZlibError))?; [INFO] [stdout] 248 | encoder.finish().or(Err(ProtocolError::ZlibError)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_mc_proto` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 73 | let stream: TcpStream = match TcpStream::connect(&addr) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | Ok(i) => i, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Ok(MinecraftConnection { [INFO] [stdout] | ____________^ [INFO] [stdout] 79 | | stream, [INFO] [stdout] 80 | | #[cfg(feature = "atomic_compression")] [INFO] [stdout] 81 | | compression: Arc::new(AtomicUsize::new(usize::MAX)), [INFO] [stdout] ... | [INFO] [stdout] 84 | | compression_type: 1, [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:131:26 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn new(stream: T) -> MinecraftConnection { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | compression: Arc::new(AtomicUsize::new(usize::MAX)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:248:5 [INFO] [stdout] | [INFO] [stdout] 246 | let mut encoder = ZlibEncoder::new(Vec::new(), Compression::new(compression)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | encoder.write_all(bytes).or(Err(ProtocolError::ZlibError))?; [INFO] [stdout] 248 | encoder.finish().or(Err(ProtocolError::ZlibError)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_mc_proto` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "7223868f6ad5368437efae7d9ff81e51fa0930d71d6276ba78376fccd3895e54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7223868f6ad5368437efae7d9ff81e51fa0930d71d6276ba78376fccd3895e54", kill_on_drop: false }` [INFO] [stdout] 7223868f6ad5368437efae7d9ff81e51fa0930d71d6276ba78376fccd3895e54