[INFO] fetching crate rust_bundler_cp 0.3.16... [INFO] checking rust_bundler_cp-0.3.16 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rust_bundler_cp 0.3.16 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate rust_bundler_cp 0.3.16 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rust_bundler_cp 0.3.16 [INFO] finished tweaking crates.io crate rust_bundler_cp 0.3.16 [INFO] tweaked toml for crates.io crate rust_bundler_cp 0.3.16 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate rust_bundler_cp 0.3.16 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1ed26ac7552055c147cc43699534921679f19c279e6f1ec86caabb184623b09f [INFO] running `Command { std: "docker" "start" "-a" "1ed26ac7552055c147cc43699534921679f19c279e6f1ec86caabb184623b09f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1ed26ac7552055c147cc43699534921679f19c279e6f1ec86caabb184623b09f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ed26ac7552055c147cc43699534921679f19c279e6f1ec86caabb184623b09f", kill_on_drop: false }` [INFO] [stdout] 1ed26ac7552055c147cc43699534921679f19c279e6f1ec86caabb184623b09f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 942cb98bc67968217d2afc504232c8074cb896406a4b130436186ba3e67a97e0 [INFO] running `Command { std: "docker" "start" "-a" "942cb98bc67968217d2afc504232c8074cb896406a4b130436186ba3e67a97e0", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling serde_json v1.0.81 [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling semver v1.0.10 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Compiling camino v1.0.9 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking regex-syntax v0.6.26 [INFO] [stderr] Compiling quote v1.0.19 [INFO] [stderr] Compiling unicode-xid v0.2.3 [INFO] [stderr] Checking gimli v0.26.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking object v0.28.4 [INFO] [stderr] Compiling backtrace v0.3.65 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking simple-string-builder v0.2.0 [INFO] [stderr] Checking colored v1.9.3 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking environment v0.1.1 [INFO] [stderr] Checking goldenfile v1.3.0 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking addr2line v0.17.0 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking cargo-platform v0.1.2 [INFO] [stderr] Checking cargo_metadata v0.14.2 [INFO] [stderr] Checking assert_cli v0.6.3 [INFO] [stderr] Checking rust_bundler_cp v0.3.16 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo_loader/mod.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 12 | fn get_metadata>(package_path: P) -> cargo_metadata::Metadata{ [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | cmd.exec().unwrap() [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_bundler_cp` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `expander` [INFO] [stdout] --> src/lib.rs:415:17 [INFO] [stdout] | [INFO] [stdout] 415 | let mut expander = create_expander(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_expander` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:415:13 [INFO] [stdout] | [INFO] [stdout] 415 | let mut expander = create_expander(); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file` [INFO] [stdout] --> src/lib.rs:419:17 [INFO] [stdout] | [INFO] [stdout] 419 | let mut file = read_source_code(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_file` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:419:13 [INFO] [stdout] | [INFO] [stdout] 419 | let mut file = read_source_code(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:428:13 [INFO] [stdout] | [INFO] [stdout] 428 | let mut expander = crate::Expander::new(base_path, "", crate_name); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:437:13 [INFO] [stdout] | [INFO] [stdout] 437 | let mut file = syn::parse_file(&syntax_tree).expect("failed to parse binary target source"); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo_loader/mod.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 12 | fn get_metadata>(package_path: P) -> cargo_metadata::Metadata{ [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | cmd.exec().unwrap() [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_bundler_cp` (lib test) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "942cb98bc67968217d2afc504232c8074cb896406a4b130436186ba3e67a97e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "942cb98bc67968217d2afc504232c8074cb896406a4b130436186ba3e67a97e0", kill_on_drop: false }` [INFO] [stdout] 942cb98bc67968217d2afc504232c8074cb896406a4b130436186ba3e67a97e0