[INFO] fetching crate rust-unixfs 0.4.1... [INFO] checking rust-unixfs-0.4.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rust-unixfs 0.4.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate rust-unixfs 0.4.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rust-unixfs 0.4.1 [INFO] finished tweaking crates.io crate rust-unixfs 0.4.1 [INFO] tweaked toml for crates.io crate rust-unixfs 0.4.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate rust-unixfs 0.4.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2bda5504d94c70fede938b8e6ea52705e879c061f0f0c39c981c988fe5fa4e65 [INFO] running `Command { std: "docker" "start" "-a" "2bda5504d94c70fede938b8e6ea52705e879c061f0f0c39c981c988fe5fa4e65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2bda5504d94c70fede938b8e6ea52705e879c061f0f0c39c981c988fe5fa4e65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2bda5504d94c70fede938b8e6ea52705e879c061f0f0c39c981c988fe5fa4e65", kill_on_drop: false }` [INFO] [stdout] 2bda5504d94c70fede938b8e6ea52705e879c061f0f0c39c981c988fe5fa4e65 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4571fd591ab1dff3e915a8b41572292d6f385771ff43291834d95d78bd5b1037 [INFO] running `Command { std: "docker" "start" "-a" "4571fd591ab1dff3e915a8b41572292d6f385771ff43291834d95d78bd5b1037", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Compiling unicode-xid v0.2.4 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Compiling data-encoding v2.5.0 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Checking base-x v0.2.11 [INFO] [stderr] Checking unsigned-varint v0.7.2 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking quick-protobuf v0.8.1 [INFO] [stderr] Checking blake2b_simd v1.0.2 [INFO] [stderr] Checking blake2s_simd v1.0.2 [INFO] [stderr] Checking half v2.3.1 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Compiling hex-literal v0.3.4 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking tar v0.4.40 [INFO] [stderr] Compiling blake3 v1.5.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Compiling data-encoding-macro-internal v0.1.12 [INFO] [stderr] Checking data-encoding-macro v0.1.14 [INFO] [stderr] Checking multibase v0.9.1 [INFO] [stderr] Compiling proc-macro-crate v1.1.3 [INFO] [stderr] Compiling multihash-derive v0.8.1 [INFO] [stderr] Compiling libipld-cbor-derive v0.16.0 [INFO] [stderr] Checking multihash v0.18.1 [INFO] [stderr] Checking cid v0.10.1 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking libipld-core v0.16.0 [INFO] [stderr] Checking libipld-cbor v0.16.0 [INFO] [stderr] Checking libipld-macro v0.16.0 [INFO] [stderr] Checking libipld-pb v0.16.0 [INFO] [stderr] Checking libipld-json v0.16.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking libipld v0.16.0 [INFO] [stderr] Checking criterion v0.4.0 [INFO] [stderr] Checking rust-unixfs v0.4.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `unwrap_borrowed` is never used [INFO] [stdout] --> src/file.rs:156:8 [INFO] [stdout] | [INFO] [stdout] 154 | pub(crate) trait UnwrapBorrowedExt<'a> { [INFO] [stdout] | ----------------- method in this trait [INFO] [stdout] 155 | /// Does not default but requires there to be an borrowed inner value. [INFO] [stdout] 156 | fn unwrap_borrowed(self) -> &'a [u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:82:60 [INFO] [stdout] | [INFO] [stdout] 82 | Cid::try_from(hash).map_err(|e| InvalidCidInLink::from((nth, link, e))) [INFO] [stdout] | - ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:145:30 [INFO] [stdout] | [INFO] [stdout] 144 | fn from(e: InvalidCidInLink) -> ResolveError { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | ResolveError::Lookup(e.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:151:30 [INFO] [stdout] | [INFO] [stdout] 150 | fn from(e: MultipleMatchingLinks) -> ResolveError { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | ResolveError::Lookup(e.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir/sharded_lookup.rs:213:30 [INFO] [stdout] | [INFO] [stdout] 212 | fn from(e: PartitioningError) -> ResolveError { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | ResolveError::Lookup(LookupError::from(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pb.rs:135:15 [INFO] [stdout] | [INFO] [stdout] 135 | match UnixFs::try_from(data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dagpb.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn wrap_node_data(block: T) -> Result, quick_protobuf::Error> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Ok(NodeData { [INFO] [stdout] | ________^ [INFO] [stdout] 29 | | inner: block, [INFO] [stdout] 30 | | range, [INFO] [stdout] 31 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-unixfs` (lib) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "4571fd591ab1dff3e915a8b41572292d6f385771ff43291834d95d78bd5b1037", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4571fd591ab1dff3e915a8b41572292d6f385771ff43291834d95d78bd5b1037", kill_on_drop: false }` [INFO] [stdout] 4571fd591ab1dff3e915a8b41572292d6f385771ff43291834d95d78bd5b1037