[INFO] fetching crate rust-query 0.1.2... [INFO] checking rust-query-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rust-query 0.1.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate rust-query 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rust-query 0.1.2 [INFO] finished tweaking crates.io crate rust-query 0.1.2 [INFO] tweaked toml for crates.io crate rust-query 0.1.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 30 packages to latest compatible versions [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding libsqlite3-sys v0.28.0 (latest: v0.30.1) [INFO] [stderr] Adding rusqlite v0.31.0 (latest: v0.32.1) [INFO] [stderr] Adding sea-query v0.30.7 (latest: v0.31.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 32c99a83a07997f88e637818d922000332443a615c84a00e36dd2d7f7e761c37 [INFO] running `Command { std: "docker" "start" "-a" "32c99a83a07997f88e637818d922000332443a615c84a00e36dd2d7f7e761c37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "32c99a83a07997f88e637818d922000332443a615c84a00e36dd2d7f7e761c37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32c99a83a07997f88e637818d922000332443a615c84a00e36dd2d7f7e761c37", kill_on_drop: false }` [INFO] [stdout] 32c99a83a07997f88e637818d922000332443a615c84a00e36dd2d7f7e761c37 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cf7c116954d7c28c70bd14ed3e82dae7a3434158bb5df2686777518209442a68 [INFO] running `Command { std: "docker" "start" "-a" "cf7c116954d7c28c70bd14ed3e82dae7a3434158bb5df2686777518209442a68", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking heck v0.5.0 [INFO] [stderr] Checking elsa v1.10.0 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling inherent v1.0.11 [INFO] [stderr] Compiling sea-query-derive v0.4.1 [INFO] [stderr] Checking sea-query v0.30.7 [INFO] [stderr] Checking rust-query v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `ncol`, `wr`, and `strict` are never read [INFO] [stdout] --> src/pragma.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct TableListDummy<'a> { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 9 | pub ncol: Db<'a, i64>, [INFO] [stdout] | ^^^^ [INFO] [stdout] 10 | pub wr: Db<'a, i64>, [INFO] [stdout] | ^^ [INFO] [stdout] 11 | pub strict: Db<'a, i64>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `to` is never read [INFO] [stdout] --> src/pragma.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 60 | pub struct ForeignKeyListDummy<'a> { [INFO] [stdout] | ------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 63 | pub to: Db<'a, String>, [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:261:9 [INFO] [stdout] | [INFO] [stdout] 252 | let select = self.ast.simple(self.offset, self.limit); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | let mut statement = self.conn.prepare(&sql).unwrap(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | let mut rows = statement.query([]).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | rows.next().unwrap().unwrap().get_unwrap(idx) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/group.rs:47:19 [INFO] [stdout] | [INFO] [stdout] 41 | val: impl Value<'inner, Typ = T>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | on: impl Value<'outer, Typ = T>, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | .push(Box::new((val.build_expr(), alias, on.build_expr()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/insert.rs:22:25 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn col(&self, name: &'static str, val: impl Value<'a>) { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let field = Field::Str(name); [INFO] [stdout] 21 | let expr = val.build_expr(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | self.parts.push(Box::new((expr, field))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mymap.rs:14:10 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn get_or_init(&self, k: K, f: impl FnOnce() -> V) -> &V { [INFO] [stdout] | ---- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | &self.inner.push_get(Box::new((k, f()))).1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `ncol`, `wr`, and `strict` are never read [INFO] [stdout] --> src/pragma.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct TableListDummy<'a> { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 9 | pub ncol: Db<'a, i64>, [INFO] [stdout] | ^^^^ [INFO] [stdout] 10 | pub wr: Db<'a, i64>, [INFO] [stdout] | ^^ [INFO] [stdout] 11 | pub strict: Db<'a, i64>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `to` is never read [INFO] [stdout] --> src/pragma.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 60 | pub struct ForeignKeyListDummy<'a> { [INFO] [stdout] | ------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 63 | pub to: Db<'a, String>, [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:261:9 [INFO] [stdout] | [INFO] [stdout] 252 | let select = self.ast.simple(self.offset, self.limit); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | let mut statement = self.conn.prepare(&sql).unwrap(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | let mut rows = statement.query([]).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | rows.next().unwrap().unwrap().get_unwrap(idx) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:390:21 [INFO] [stdout] | [INFO] [stdout] 379 | let table = MyTable { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 390 | Rc::new(T::build(Builder::new(&table.joins))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/group.rs:47:19 [INFO] [stdout] | [INFO] [stdout] 41 | val: impl Value<'inner, Typ = T>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | on: impl Value<'outer, Typ = T>, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | .push(Box::new((val.build_expr(), alias, on.build_expr()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/insert.rs:22:25 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn col(&self, name: &'static str, val: impl Value<'a>) { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let field = Field::Str(name); [INFO] [stdout] 21 | let expr = val.build_expr(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | self.parts.push(Box::new((expr, field))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mymap.rs:14:10 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn get_or_init(&self, k: K, f: impl FnOnce() -> V) -> &V { [INFO] [stdout] | ---- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | &self.inner.push_get(Box::new((k, f()))).1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:390:21 [INFO] [stdout] | [INFO] [stdout] 379 | let table = MyTable { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 390 | Rc::new(T::build(Builder::new(&table.joins))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-query` (lib test) due to 6 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rust-query` (lib) due to 6 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "cf7c116954d7c28c70bd14ed3e82dae7a3434158bb5df2686777518209442a68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf7c116954d7c28c70bd14ed3e82dae7a3434158bb5df2686777518209442a68", kill_on_drop: false }` [INFO] [stdout] cf7c116954d7c28c70bd14ed3e82dae7a3434158bb5df2686777518209442a68