[INFO] fetching crate rust-oop 0.1.2... [INFO] checking rust-oop-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rust-oop 0.1.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate rust-oop 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rust-oop 0.1.2 [INFO] finished tweaking crates.io crate rust-oop 0.1.2 [INFO] tweaked toml for crates.io crate rust-oop 0.1.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0ea219d15d4de3cb4fab9985eb44a10fd57bcfcd574a22c2010a51d1b5cdbf18 [INFO] running `Command { std: "docker" "start" "-a" "0ea219d15d4de3cb4fab9985eb44a10fd57bcfcd574a22c2010a51d1b5cdbf18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0ea219d15d4de3cb4fab9985eb44a10fd57bcfcd574a22c2010a51d1b5cdbf18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ea219d15d4de3cb4fab9985eb44a10fd57bcfcd574a22c2010a51d1b5cdbf18", kill_on_drop: false }` [INFO] [stdout] 0ea219d15d4de3cb4fab9985eb44a10fd57bcfcd574a22c2010a51d1b5cdbf18 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] affce64ea373602c137d49123141b04cb8a1d79df759b5be992232e5e0aad00b [INFO] running `Command { std: "docker" "start" "-a" "affce64ea373602c137d49123141b04cb8a1d79df759b5be992232e5e0aad00b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking rust-oop v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/info.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 26 | let parent: Ident = input.parse()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | extend_token, [INFO] [stdout] 35 | | parent, [INFO] [stdout] 36 | | end [INFO] [stdout] 37 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/info.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 110 | let _parent: Option = if lookahead.peek(kw::extends) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let _struct: Option = input.parse().ok(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | let mut _impl: Option = None; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | let mut _trait_impl: HashMap, Box> = HashMap::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 139 | | _parent, [INFO] [stdout] 140 | | _struct, [INFO] [stdout] 141 | | _impl, [INFO] [stdout] 142 | | _trait_impl, [INFO] [stdout] 143 | | real_trait: None [INFO] [stdout] 144 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_class.rs:15:40 [INFO] [stdout] | [INFO] [stdout] 15 | method.attrs.iter().filter_map(|x| x.parse_meta().ok()).map(|x| x.to_token_stream().to_string()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_class.rs:15:69 [INFO] [stdout] | [INFO] [stdout] 15 | method.attrs.iter().filter_map(|x| x.parse_meta().ok()).map(|x| x.to_token_stream().to_string()).collect() [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_class.rs:272:90 [INFO] [stdout] | [INFO] [stdout] 272 | let mut mapped: Vec = override_methods.iter().map(|x| ImplItem::Method(x.to_owned())).collect(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-oop` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/info.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 26 | let parent: Ident = input.parse()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | extend_token, [INFO] [stdout] 35 | | parent, [INFO] [stdout] 36 | | end [INFO] [stdout] 37 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/info.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 110 | let _parent: Option = if lookahead.peek(kw::extends) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let _struct: Option = input.parse().ok(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | let mut _impl: Option = None; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | let mut _trait_impl: HashMap, Box> = HashMap::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 139 | | _parent, [INFO] [stdout] 140 | | _struct, [INFO] [stdout] 141 | | _impl, [INFO] [stdout] 142 | | _trait_impl, [INFO] [stdout] 143 | | real_trait: None [INFO] [stdout] 144 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_class.rs:15:40 [INFO] [stdout] | [INFO] [stdout] 15 | method.attrs.iter().filter_map(|x| x.parse_meta().ok()).map(|x| x.to_token_stream().to_string()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_class.rs:15:69 [INFO] [stdout] | [INFO] [stdout] 15 | method.attrs.iter().filter_map(|x| x.parse_meta().ok()).map(|x| x.to_token_stream().to_string()).collect() [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_class.rs:272:90 [INFO] [stdout] | [INFO] [stdout] 272 | let mut mapped: Vec = override_methods.iter().map(|x| ImplItem::Method(x.to_owned())).collect(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-oop` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "affce64ea373602c137d49123141b04cb8a1d79df759b5be992232e5e0aad00b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "affce64ea373602c137d49123141b04cb8a1d79df759b5be992232e5e0aad00b", kill_on_drop: false }` [INFO] [stdout] affce64ea373602c137d49123141b04cb8a1d79df759b5be992232e5e0aad00b