[INFO] fetching crate rust-govhost 0.1.0... [INFO] checking rust-govhost-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rust-govhost 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate rust-govhost 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rust-govhost 0.1.0 [INFO] finished tweaking crates.io crate rust-govhost 0.1.0 [INFO] tweaked toml for crates.io crate rust-govhost 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e2608484330d850504741c1c319d6c39e307d4427d923f5c252d3039ece1b8e4 [INFO] running `Command { std: "docker" "start" "-a" "e2608484330d850504741c1c319d6c39e307d4427d923f5c252d3039ece1b8e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e2608484330d850504741c1c319d6c39e307d4427d923f5c252d3039ece1b8e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e2608484330d850504741c1c319d6c39e307d4427d923f5c252d3039ece1b8e4", kill_on_drop: false }` [INFO] [stdout] e2608484330d850504741c1c319d6c39e307d4427d923f5c252d3039ece1b8e4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5cc96e6862db2e45393a064e6efefc334be565a58f48cc1e56e271cc700fd459 [INFO] running `Command { std: "docker" "start" "-a" "5cc96e6862db2e45393a064e6efefc334be565a58f48cc1e56e271cc700fd459", kill_on_drop: false }` [INFO] [stderr] Checking rust-govhost v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(mut stream: TcpStream) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let buffer = Arc::new(Mutex::new(Cursor::new(Vec::new()))); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | Ok(SharedConn { [INFO] [stdout] | ____________^ [INFO] [stdout] 36 | | stream, [INFO] [stdout] 37 | | buffer, [INFO] [stdout] 38 | | sni, [INFO] [stdout] 39 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-govhost` (lib test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `SharedConn` is never constructed [INFO] [stdout] --> src/lib.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 14 | pub(crate) struct SharedConn { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `get_sni` are never used [INFO] [stdout] --> src/lib.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 21 | impl SharedConn { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 22 | pub fn new(mut stream: TcpStream) -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 42 | pub fn get_sni(&self) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_sni` is never used [INFO] [stdout] --> src/lib.rs:70:4 [INFO] [stdout] | [INFO] [stdout] 70 | fn parse_sni(buf: &[u8], n: usize) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(mut stream: TcpStream) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let buffer = Arc::new(Mutex::new(Cursor::new(Vec::new()))); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | Ok(SharedConn { [INFO] [stdout] | ____________^ [INFO] [stdout] 36 | | stream, [INFO] [stdout] 37 | | buffer, [INFO] [stdout] 38 | | sni, [INFO] [stdout] 39 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-govhost` (lib) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5cc96e6862db2e45393a064e6efefc334be565a58f48cc1e56e271cc700fd459", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5cc96e6862db2e45393a064e6efefc334be565a58f48cc1e56e271cc700fd459", kill_on_drop: false }` [INFO] [stdout] 5cc96e6862db2e45393a064e6efefc334be565a58f48cc1e56e271cc700fd459