[INFO] fetching crate rust-analyzer-salsa 0.17.0-pre.6... [INFO] checking rust-analyzer-salsa-0.17.0-pre.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rust-analyzer-salsa 0.17.0-pre.6 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate rust-analyzer-salsa 0.17.0-pre.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rust-analyzer-salsa 0.17.0-pre.6 [INFO] finished tweaking crates.io crate rust-analyzer-salsa 0.17.0-pre.6 [INFO] tweaked toml for crates.io crate rust-analyzer-salsa 0.17.0-pre.6 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate rust-analyzer-salsa 0.17.0-pre.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 853543d6115d1c967aa2648f9afce8bf39ab90dba3981025dda9a8e2dd86da13 [INFO] running `Command { std: "docker" "start" "-a" "853543d6115d1c967aa2648f9afce8bf39ab90dba3981025dda9a8e2dd86da13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "853543d6115d1c967aa2648f9afce8bf39ab90dba3981025dda9a8e2dd86da13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "853543d6115d1c967aa2648f9afce8bf39ab90dba3981025dda9a8e2dd86da13", kill_on_drop: false }` [INFO] [stdout] 853543d6115d1c967aa2648f9afce8bf39ab90dba3981025dda9a8e2dd86da13 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 14fb83a7b81872b4f8d53d0686983abec26ffb6dfd6a876a3c8c3195aed0e662 [INFO] running `Command { std: "docker" "start" "-a" "14fb83a7b81872b4f8d53d0686983abec26ffb6dfd6a876a3c8c3195aed0e662", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking similar v2.4.0 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking insta v1.34.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand_distr v0.2.2 [INFO] [stderr] Checking triomphe v0.1.11 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling rust-analyzer-salsa-macros v0.17.0-pre.6 [INFO] [stderr] Compiling test-log-macros v0.2.14 [INFO] [stderr] Checking test-log v0.2.14 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking rust-analyzer-salsa v0.17.0-pre.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:631:15 [INFO] [stdout] | [INFO] [stdout] 627 | pub fn catch(f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 631 | match panic::catch_unwind(f) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:686:35 [INFO] [stdout] | [INFO] [stdout] 684 | pub(crate) fn throw(self) -> ! { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 685 | tracing::debug!("throwing cycle {:?}", self); [INFO] [stdout] 686 | std::panic::resume_unwind(Box::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:690:15 [INFO] [stdout] | [INFO] [stdout] 689 | pub(crate) fn catch(execute: impl FnOnce() -> T) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 690 | match std::panic::catch_unwind(AssertUnwindSafe(execute)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derived.rs:112:41 [INFO] [stdout] | [INFO] [stdout] 112 | .or_insert_with(|| Arc::new(Slot::new(key.clone(), database_key_index))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derived/slot.rs:116:20 [INFO] [stdout] | [INFO] [stdout] 112 | pub(super) fn new(key: Q::Key, database_key_index: DatabaseKeyIndex) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | state: RwLock::new(QueryState::NotComputed), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derived/slot.rs:242:58 [INFO] [stdout] | [INFO] [stdout] 242 | let value = match Cycle::catch(|| Q::execute(db, self.key.clone())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derived/slot.rs:498:15 [INFO] [stdout] | [INFO] [stdout] 491 | state: StateGuard, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 498 | match self.probe(db, state, runtime, revision_now) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:199:19 [INFO] [stdout] | [INFO] [stdout] 162 | fn set(&self, runtime: &mut Runtime, key: &Q::Key, value: Q::Value, durability: Durability) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let mut slots = self.slots.write(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | let stamped_value = StampedValue { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | match slots.entry(key.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interned.rs:162:22 [INFO] [stdout] | [INFO] [stdout] 137 | let owned_key2 = owned_key1.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | Arc::new(Slot { [INFO] [stdout] | ______________________^ [INFO] [stdout] 163 | | database_key_index, [INFO] [stdout] 164 | | value: owned_key2, [INFO] [stdout] 165 | | interned_at: revision_now, [INFO] [stdout] 166 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:94:29 [INFO] [stdout] | [INFO] [stdout] 86 | let revision_guard = RevisionGuard::new(&self.shared_state); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | revision_guard: Some(revision_guard), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:95:27 [INFO] [stdout] | [INFO] [stdout] 86 | let revision_guard = RevisionGuard::new(&self.shared_state); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | shared_state: self.shared_state.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:96:26 [INFO] [stdout] | [INFO] [stdout] 86 | let revision_guard = RevisionGuard::new(&self.shared_state); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | local_state: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/local_state.rs:76:11 [INFO] [stdout] | [INFO] [stdout] 75 | fn with_query_stack(&self, c: impl FnOnce(&mut Vec) -> R) -> R { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | c(self [INFO] [stdout] | ___________^ [INFO] [stdout] 77 | | .query_stack [INFO] [stdout] 78 | | .borrow_mut() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/local_state.rs:224:39 [INFO] [stdout] | [INFO] [stdout] 224 | .with_query_stack(|stack| stack.last_mut()?.cycle.take()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-analyzer-salsa` (lib test) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:631:15 [INFO] [stdout] | [INFO] [stdout] 627 | pub fn catch(f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 631 | match panic::catch_unwind(f) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:686:35 [INFO] [stdout] | [INFO] [stdout] 684 | pub(crate) fn throw(self) -> ! { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 685 | tracing::debug!("throwing cycle {:?}", self); [INFO] [stdout] 686 | std::panic::resume_unwind(Box::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:690:15 [INFO] [stdout] | [INFO] [stdout] 689 | pub(crate) fn catch(execute: impl FnOnce() -> T) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 690 | match std::panic::catch_unwind(AssertUnwindSafe(execute)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derived.rs:112:41 [INFO] [stdout] | [INFO] [stdout] 112 | .or_insert_with(|| Arc::new(Slot::new(key.clone(), database_key_index))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derived/slot.rs:116:20 [INFO] [stdout] | [INFO] [stdout] 112 | pub(super) fn new(key: Q::Key, database_key_index: DatabaseKeyIndex) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | state: RwLock::new(QueryState::NotComputed), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derived/slot.rs:242:58 [INFO] [stdout] | [INFO] [stdout] 242 | let value = match Cycle::catch(|| Q::execute(db, self.key.clone())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derived/slot.rs:498:15 [INFO] [stdout] | [INFO] [stdout] 491 | state: StateGuard, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 498 | match self.probe(db, state, runtime, revision_now) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:199:19 [INFO] [stdout] | [INFO] [stdout] 162 | fn set(&self, runtime: &mut Runtime, key: &Q::Key, value: Q::Value, durability: Durability) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let mut slots = self.slots.write(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | let stamped_value = StampedValue { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | match slots.entry(key.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interned.rs:162:22 [INFO] [stdout] | [INFO] [stdout] 137 | let owned_key2 = owned_key1.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | Arc::new(Slot { [INFO] [stdout] | ______________________^ [INFO] [stdout] 163 | | database_key_index, [INFO] [stdout] 164 | | value: owned_key2, [INFO] [stdout] 165 | | interned_at: revision_now, [INFO] [stdout] 166 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:94:29 [INFO] [stdout] | [INFO] [stdout] 86 | let revision_guard = RevisionGuard::new(&self.shared_state); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | revision_guard: Some(revision_guard), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:95:27 [INFO] [stdout] | [INFO] [stdout] 86 | let revision_guard = RevisionGuard::new(&self.shared_state); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | shared_state: self.shared_state.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:96:26 [INFO] [stdout] | [INFO] [stdout] 86 | let revision_guard = RevisionGuard::new(&self.shared_state); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | local_state: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/local_state.rs:76:11 [INFO] [stdout] | [INFO] [stdout] 75 | fn with_query_stack(&self, c: impl FnOnce(&mut Vec) -> R) -> R { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | c(self [INFO] [stdout] | ___________^ [INFO] [stdout] 77 | | .query_stack [INFO] [stdout] 78 | | .borrow_mut() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/local_state.rs:224:39 [INFO] [stdout] | [INFO] [stdout] 224 | .with_query_stack(|stack| stack.last_mut()?.cycle.take()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-analyzer-salsa` (lib) due to 15 previous errors [INFO] running `Command { std: "docker" "inspect" "14fb83a7b81872b4f8d53d0686983abec26ffb6dfd6a876a3c8c3195aed0e662", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "14fb83a7b81872b4f8d53d0686983abec26ffb6dfd6a876a3c8c3195aed0e662", kill_on_drop: false }` [INFO] [stdout] 14fb83a7b81872b4f8d53d0686983abec26ffb6dfd6a876a3c8c3195aed0e662