[INFO] fetching crate rust-adb 0.1.0... [INFO] checking rust-adb-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rust-adb 0.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate rust-adb 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rust-adb 0.1.0 [INFO] finished tweaking crates.io crate rust-adb 0.1.0 [INFO] tweaked toml for crates.io crate rust-adb 0.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c8d5adda5ddf1edcfdf7d99e9c4a3d3edcb2b29c2e8509dcc19825fdbcbada8e [INFO] running `Command { std: "docker" "start" "-a" "c8d5adda5ddf1edcfdf7d99e9c4a3d3edcb2b29c2e8509dcc19825fdbcbada8e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c8d5adda5ddf1edcfdf7d99e9c4a3d3edcb2b29c2e8509dcc19825fdbcbada8e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c8d5adda5ddf1edcfdf7d99e9c4a3d3edcb2b29c2e8509dcc19825fdbcbada8e", kill_on_drop: false }` [INFO] [stdout] c8d5adda5ddf1edcfdf7d99e9c4a3d3edcb2b29c2e8509dcc19825fdbcbada8e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b164d2242492e14ab660c9adeb0d2167c3edbc5fe01602c29ff5bf1caa6dc93a [INFO] running `Command { std: "docker" "start" "-a" "b164d2242492e14ab660c9adeb0d2167c3edbc5fe01602c29ff5bf1caa6dc93a", kill_on_drop: false }` [INFO] [stderr] Checking rust-adb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `length` is never read [INFO] [stdout] --> src/adb_device/mod.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 31 | pub struct SyncDeviceProtocol { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] 32 | pub length: usize, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `length` is never read [INFO] [stdout] --> src/adb_host/mod.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 26 | pub struct SyncHostResponse { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 27 | pub length: usize, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SyncHostResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adb_device/mod.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 90 | mut tcp_stream: TcpStream, command: String, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | Err(AdbError::ResponseStatusError { [INFO] [stdout] | _________^ [INFO] [stdout] 108 | | content: String::from("unknown response status ") + &*status, [INFO] [stdout] 109 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adb_device/mod.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | Err(AdbError::ResponseStatusError { [INFO] [stdout] | _________^ [INFO] [stdout] 136 | | content: String::from("unknown response status ") + &*status, [INFO] [stdout] 137 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adb_device/device_reboot.rs:14:15 [INFO] [stdout] | [INFO] [stdout] 13 | let mut tcp_stream = device_connection(&self.connection_info)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | match exec_device_command(&mut tcp_stream, "reboot:".to_string()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `length` is never read [INFO] [stdout] --> src/adb_device/mod.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 31 | pub struct SyncDeviceProtocol { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] 32 | pub length: usize, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `length` is never read [INFO] [stdout] --> src/adb_host/mod.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 26 | pub struct SyncHostResponse { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 27 | pub length: usize, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SyncHostResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adb_host/mod.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 95 | mut tcp_stream: TcpStream, command: String, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | Err(AdbError::ResponseStatusError { [INFO] [stdout] | _________^ [INFO] [stdout] 113 | | content: String::from("unknown response status ") + &*status, [INFO] [stdout] 114 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adb_host/mod.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 134 | Err(AdbError::ResponseStatusError { [INFO] [stdout] | _________^ [INFO] [stdout] 135 | | content: String::from("unknown response status ") + &*status, [INFO] [stdout] 136 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adb_device/mod.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 90 | mut tcp_stream: TcpStream, command: String, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | Err(AdbError::ResponseStatusError { [INFO] [stdout] | _________^ [INFO] [stdout] 108 | | content: String::from("unknown response status ") + &*status, [INFO] [stdout] 109 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adb_device/mod.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | Err(AdbError::ResponseStatusError { [INFO] [stdout] | _________^ [INFO] [stdout] 136 | | content: String::from("unknown response status ") + &*status, [INFO] [stdout] 137 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adb_device/device_reboot.rs:14:15 [INFO] [stdout] | [INFO] [stdout] 13 | let mut tcp_stream = device_connection(&self.connection_info)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | match exec_device_command(&mut tcp_stream, "reboot:".to_string()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adb_host/mod.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 95 | mut tcp_stream: TcpStream, command: String, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | Err(AdbError::ResponseStatusError { [INFO] [stdout] | _________^ [INFO] [stdout] 113 | | content: String::from("unknown response status ") + &*status, [INFO] [stdout] 114 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adb_host/mod.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 134 | Err(AdbError::ResponseStatusError { [INFO] [stdout] | _________^ [INFO] [stdout] 135 | | content: String::from("unknown response status ") + &*status, [INFO] [stdout] 136 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-adb` (lib test) due to 6 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rust-adb` (lib) due to 6 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b164d2242492e14ab660c9adeb0d2167c3edbc5fe01602c29ff5bf1caa6dc93a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b164d2242492e14ab660c9adeb0d2167c3edbc5fe01602c29ff5bf1caa6dc93a", kill_on_drop: false }` [INFO] [stdout] b164d2242492e14ab660c9adeb0d2167c3edbc5fe01602c29ff5bf1caa6dc93a