[INFO] fetching crate ruscii 0.4.0... [INFO] checking ruscii-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ruscii 0.4.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ruscii 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ruscii 0.4.0 [INFO] finished tweaking crates.io crate ruscii 0.4.0 [INFO] tweaked toml for crates.io crate ruscii 0.4.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate ruscii 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 91d53d1a1ff95181c140033f15840bae77b029047db59cd0ae4dbfce3a39a8f1 [INFO] running `Command { std: "docker" "start" "-a" "91d53d1a1ff95181c140033f15840bae77b029047db59cd0ae4dbfce3a39a8f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "91d53d1a1ff95181c140033f15840bae77b029047db59cd0ae4dbfce3a39a8f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91d53d1a1ff95181c140033f15840bae77b029047db59cd0ae4dbfce3a39a8f1", kill_on_drop: false }` [INFO] [stdout] 91d53d1a1ff95181c140033f15840bae77b029047db59cd0ae4dbfce3a39a8f1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 397805f7b2ee8f0b2e33bc01d52dc4ea57db468b45c5a906b9015bc5a217c08a [INFO] running `Command { std: "docker" "start" "-a" "397805f7b2ee8f0b2e33bc01d52dc4ea57db468b45c5a906b9015bc5a217c08a", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Compiling pkg-config v0.3.26 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling signal-hook v0.3.15 [INFO] [stderr] Compiling parking_lot_core v0.9.7 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Compiling lock_api v0.4.9 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling x11 v2.21.0 [INFO] [stderr] Compiling device_query v1.1.3 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking getrandom v0.2.9 [INFO] [stderr] Checking mio v0.8.6 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking num-complex v0.4.3 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.26.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num v0.4.0 [INFO] [stderr] Checking ruscii v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keyboard.rs:287:27 [INFO] [stdout] | [INFO] [stdout] 219 | let thread_running = Arc::new(AtomicBool::new(true)); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | [INFO] [stdout] 221 | let (acc_sender, acc_receiver): (Sender, Receiver) = mpsc::channel(); [INFO] [stdout] | ---------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | let (event_sender, event_receiver): (Sender, Receiver) = [INFO] [stdout] | ------------ -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | let acc_thread_running = thread_running.clone(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | let pressed_event_sender = event_sender.clone(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let acc_thread = thread::spawn(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | let event_thread_running = thread_running.clone(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | let released_event_sender = event_sender; [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | let event_thread = thread::spawn(move || { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 287 | event_thread: Some(event_thread), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keyboard.rs:288:25 [INFO] [stdout] | [INFO] [stdout] 219 | let thread_running = Arc::new(AtomicBool::new(true)); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | [INFO] [stdout] 221 | let (acc_sender, acc_receiver): (Sender, Receiver) = mpsc::channel(); [INFO] [stdout] | ---------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | let (event_sender, event_receiver): (Sender, Receiver) = [INFO] [stdout] | ------------ -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | let acc_thread_running = thread_running.clone(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | let pressed_event_sender = event_sender.clone(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let acc_thread = thread::spawn(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | let event_thread_running = thread_running.clone(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | let released_event_sender = event_sender; [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | let event_thread = thread::spawn(move || { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 288 | acc_thread: Some(acc_thread), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ruscii` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keyboard.rs:287:27 [INFO] [stdout] | [INFO] [stdout] 219 | let thread_running = Arc::new(AtomicBool::new(true)); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | [INFO] [stdout] 221 | let (acc_sender, acc_receiver): (Sender, Receiver) = mpsc::channel(); [INFO] [stdout] | ---------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | let (event_sender, event_receiver): (Sender, Receiver) = [INFO] [stdout] | ------------ -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | let acc_thread_running = thread_running.clone(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | let pressed_event_sender = event_sender.clone(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let acc_thread = thread::spawn(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | let event_thread_running = thread_running.clone(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | let released_event_sender = event_sender; [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | let event_thread = thread::spawn(move || { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 287 | event_thread: Some(event_thread), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keyboard.rs:288:25 [INFO] [stdout] | [INFO] [stdout] 219 | let thread_running = Arc::new(AtomicBool::new(true)); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | [INFO] [stdout] 221 | let (acc_sender, acc_receiver): (Sender, Receiver) = mpsc::channel(); [INFO] [stdout] | ---------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | let (event_sender, event_receiver): (Sender, Receiver) = [INFO] [stdout] | ------------ -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | let acc_thread_running = thread_running.clone(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | let pressed_event_sender = event_sender.clone(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let acc_thread = thread::spawn(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | let event_thread_running = thread_running.clone(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | let released_event_sender = event_sender; [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | let event_thread = thread::spawn(move || { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 288 | acc_thread: Some(acc_thread), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ruscii` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "397805f7b2ee8f0b2e33bc01d52dc4ea57db468b45c5a906b9015bc5a217c08a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "397805f7b2ee8f0b2e33bc01d52dc4ea57db468b45c5a906b9015bc5a217c08a", kill_on_drop: false }` [INFO] [stdout] 397805f7b2ee8f0b2e33bc01d52dc4ea57db468b45c5a906b9015bc5a217c08a