[INFO] fetching crate runfile 0.1.1... [INFO] checking runfile-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate runfile 0.1.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate runfile 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-0-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate runfile 0.1.1 [INFO] finished tweaking crates.io crate runfile 0.1.1 [INFO] tweaked toml for crates.io crate runfile 0.1.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate runfile 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 76aed8bfe846270a2dacd9dfbf5737fe339ff7d26b1bc09130da976d326008f2 [INFO] running `Command { std: "docker" "start" "-a" "76aed8bfe846270a2dacd9dfbf5737fe339ff7d26b1bc09130da976d326008f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "76aed8bfe846270a2dacd9dfbf5737fe339ff7d26b1bc09130da976d326008f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76aed8bfe846270a2dacd9dfbf5737fe339ff7d26b1bc09130da976d326008f2", kill_on_drop: false }` [INFO] [stdout] 76aed8bfe846270a2dacd9dfbf5737fe339ff7d26b1bc09130da976d326008f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 569e315f8211a9dbbf86bd76339e65376e9d7028f778e1f6946366ca4e3f2015 [INFO] running `Command { std: "docker" "start" "-a" "569e315f8211a9dbbf86bd76339e65376e9d7028f778e1f6946366ca4e3f2015", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking anstyle v1.0.5 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Compiling peg-runtime v0.8.2 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking app_dirs2 v2.5.5 [INFO] [stderr] Checking ariadne v0.4.0 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking indexmap v2.2.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking xxhash-rust v0.8.8 [INFO] [stderr] Compiling peg-macros v0.8.2 [INFO] [stderr] Checking read_pipe v0.1.2 [INFO] [stderr] Checking beef v0.5.2 [INFO] [stderr] Checking clap v4.4.18 [INFO] [stderr] Checking clap_complete v4.4.10 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking which v6.0.0 [INFO] [stderr] Checking yansi v1.0.0-rc.1 [INFO] [stderr] Checking peg v0.8.2 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling enum_dispatch v0.3.12 [INFO] [stderr] Checking runfile v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait `Check` is never used [INFO] [stdout] --> src/utils.rs:1:18 [INFO] [stdout] | [INFO] [stdout] 1 | pub(crate) trait Check { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `bye`, `byefmt`, `bye_and`, and `check` are never used [INFO] [stdout] --> src/utils.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 17 | pub trait Goodbye [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 23 | fn bye(self, msg: impl AsRef) -> T { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | fn byefmt>(self, msg: impl Fn() -> S) -> T { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 43 | fn bye_and(self, and: impl FnOnce()) -> T { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 51 | fn check(self) -> Option; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `drop_and` is never used [INFO] [stdout] --> src/utils.rs:82:8 [INFO] [stdout] | [INFO] [stdout] 76 | pub trait OptionExt { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 82 | fn drop_and(self, and: U) -> Option; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `BoolExt` is never used [INFO] [stdout] --> src/utils.rs:103:11 [INFO] [stdout] | [INFO] [stdout] 103 | pub trait BoolExt: Check<()> [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clap.rs:58:34 [INFO] [stdout] | [INFO] [stdout] 58 | .map(|a| clap::Arg::new(a.to_string()).required(true)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:207:30 [INFO] [stdout] | [INFO] [stdout] 191 | let patterns = args_names.chain(vars_names).chain([ [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let replace_with = args_values.chain(vars_values).chain([ [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | let ac = aho_corasick::AhoCorasick::builder() [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | ac.replace_all(&script, &replace_with.collect::>()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmt/strlist.rs:145:23 [INFO] [stdout] | [INFO] [stdout] 143 | fn from((separator, v): (Separator, I)) -> Self { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | Self { [INFO] [stdout] 145 | elements: std::iter::once(separator.into()) [INFO] [stdout] | _______________________^ [INFO] [stdout] 146 | | .chain(v.into_iter().map(|s| s.into())) [INFO] [stdout] 147 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/mod.rs:42:29 [INFO] [stdout] | [INFO] [stdout] 41 | fn execute(&self, input: &str, args: impl AsRef<[String]>) -> Result<(), Str<'_>> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | execute_interpreted(self.program()?, input, args) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/mod.rs:51:30 [INFO] [stdout] | [INFO] [stdout] 51 | .or_else(|error| crate::nix::nix_shell(self.nix_packages(), self.binary()).ok_or(error)) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/mod.rs:92:11 [INFO] [stdout] | [INFO] [stdout] 91 | fn wait_for_child(mut child: std::process::Child) -> Result<(), Str<'static>> { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | match child.wait() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/c.rs:34:30 [INFO] [stdout] | [INFO] [stdout] 34 | .or_else(|error| crate::nix::nix_shell(["gcc"], "gcc").ok_or(error)) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/c.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 37 | fn execute(&self, input: &str, args: impl AsRef<[String]>) -> Result<(), Str<'_>> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | self.program()?.args(["main.c", "-o", "main"]), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/c.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 37 | fn execute(&self, input: &str, args: impl AsRef<[String]>) -> Result<(), Str<'_>> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | &mut std::process::Command::new("./main"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/cpp.rs:34:30 [INFO] [stdout] | [INFO] [stdout] 34 | .or_else(|error| crate::nix::nix_shell(["gcc"], "g++").ok_or(error)) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/cpp.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 37 | fn execute(&self, input: &str, args: impl AsRef<[String]>) -> Result<(), Str<'_>> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | self.program()?.args(["main.cpp", "-o", "main"]), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/cpp.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 37 | fn execute(&self, input: &str, args: impl AsRef<[String]>) -> Result<(), Str<'_>> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | &mut std::process::Command::new("./main"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/csharp.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 20 | args: impl AsRef<[String]>, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | self.program()? [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/csharp.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 20 | args: impl AsRef<[String]>, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | self.program()?.arg("build"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/csharp.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 20 | args: impl AsRef<[String]>, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | self.program()?.args(["run", "--no-build"]), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/rust.rs:29:30 [INFO] [stdout] | [INFO] [stdout] 29 | .or_else(|error| crate::nix::nix_shell([BINARY, "gcc"], BINARY).ok_or(error)) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/rust.rs:39:18 [INFO] [stdout] | [INFO] [stdout] 32 | fn execute(&self, input: &str, args: impl AsRef<[String]>) -> Result<(), Str<'_>> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Some(self.program()?.args(["init", "--name", "runfile"])), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/rust.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 32 | fn execute(&self, input: &str, args: impl AsRef<[String]>) -> Result<(), Str<'_>> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | self.program()?.args(["build", "--color", "always"]), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/rust.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 32 | fn execute(&self, input: &str, args: impl AsRef<[String]>) -> Result<(), Str<'_>> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | self.program()?.args(["run", "-q", "--"]), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing/parser.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 124 | pub rule runfile(dir: &std::path::Path) -> Result, Vec> = __ elements:(var()/include(dir)/subcommand(dir)/... [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let mut commands = HashMap::with_hasher(xxhash_rust::xxh3::Xxh3Builder::new()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let mut subcommands = HashMap::with_hasher(xxhash_rust::xxh3::Xxh3Builder::new()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let mut includes = HashMap::with_hasher(xxhash_rust::xxh3::Xxh3Builder::new()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let mut vars = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | let mut errors = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | / Runfile { [INFO] [stdout] 159 | | doc: String::new(), [INFO] [stdout] 160 | | commands, [INFO] [stdout] 161 | | subcommands, [INFO] [stdout] 162 | | includes, [INFO] [stdout] 163 | | vars [INFO] [stdout] 164 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 20 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `runfile` (bin "run") due to 21 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: trait `Check` is never used [INFO] [stdout] --> src/utils.rs:1:18 [INFO] [stdout] | [INFO] [stdout] 1 | pub(crate) trait Check { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `bye`, `byefmt`, `bye_and`, and `check` are never used [INFO] [stdout] --> src/utils.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 17 | pub trait Goodbye [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 23 | fn bye(self, msg: impl AsRef) -> T { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | fn byefmt>(self, msg: impl Fn() -> S) -> T { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 43 | fn bye_and(self, and: impl FnOnce()) -> T { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 51 | fn check(self) -> Option; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `drop_and` is never used [INFO] [stdout] --> src/utils.rs:82:8 [INFO] [stdout] | [INFO] [stdout] 76 | pub trait OptionExt { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 82 | fn drop_and(self, and: U) -> Option; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `BoolExt` is never used [INFO] [stdout] --> src/utils.rs:103:11 [INFO] [stdout] | [INFO] [stdout] 103 | pub trait BoolExt: Check<()> [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clap.rs:58:34 [INFO] [stdout] | [INFO] [stdout] 58 | .map(|a| clap::Arg::new(a.to_string()).required(true)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:207:30 [INFO] [stdout] | [INFO] [stdout] 191 | let patterns = args_names.chain(vars_names).chain([ [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let replace_with = args_values.chain(vars_values).chain([ [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | let ac = aho_corasick::AhoCorasick::builder() [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | ac.replace_all(&script, &replace_with.collect::>()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmt/strlist.rs:145:23 [INFO] [stdout] | [INFO] [stdout] 143 | fn from((separator, v): (Separator, I)) -> Self { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | Self { [INFO] [stdout] 145 | elements: std::iter::once(separator.into()) [INFO] [stdout] | _______________________^ [INFO] [stdout] 146 | | .chain(v.into_iter().map(|s| s.into())) [INFO] [stdout] 147 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/mod.rs:42:29 [INFO] [stdout] | [INFO] [stdout] 41 | fn execute(&self, input: &str, args: impl AsRef<[String]>) -> Result<(), Str<'_>> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | execute_interpreted(self.program()?, input, args) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/mod.rs:51:30 [INFO] [stdout] | [INFO] [stdout] 51 | .or_else(|error| crate::nix::nix_shell(self.nix_packages(), self.binary()).ok_or(error)) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/mod.rs:92:11 [INFO] [stdout] | [INFO] [stdout] 91 | fn wait_for_child(mut child: std::process::Child) -> Result<(), Str<'static>> { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | match child.wait() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/c.rs:34:30 [INFO] [stdout] | [INFO] [stdout] 34 | .or_else(|error| crate::nix::nix_shell(["gcc"], "gcc").ok_or(error)) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/c.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 37 | fn execute(&self, input: &str, args: impl AsRef<[String]>) -> Result<(), Str<'_>> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | self.program()?.args(["main.c", "-o", "main"]), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/c.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 37 | fn execute(&self, input: &str, args: impl AsRef<[String]>) -> Result<(), Str<'_>> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | &mut std::process::Command::new("./main"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/cpp.rs:34:30 [INFO] [stdout] | [INFO] [stdout] 34 | .or_else(|error| crate::nix::nix_shell(["gcc"], "g++").ok_or(error)) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/cpp.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 37 | fn execute(&self, input: &str, args: impl AsRef<[String]>) -> Result<(), Str<'_>> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | self.program()?.args(["main.cpp", "-o", "main"]), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/cpp.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 37 | fn execute(&self, input: &str, args: impl AsRef<[String]>) -> Result<(), Str<'_>> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | &mut std::process::Command::new("./main"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/csharp.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 20 | args: impl AsRef<[String]>, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | self.program()? [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/csharp.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 20 | args: impl AsRef<[String]>, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | self.program()?.arg("build"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/csharp.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 20 | args: impl AsRef<[String]>, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | self.program()?.args(["run", "--no-build"]), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/rust.rs:29:30 [INFO] [stdout] | [INFO] [stdout] 29 | .or_else(|error| crate::nix::nix_shell([BINARY, "gcc"], BINARY).ok_or(error)) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/rust.rs:39:18 [INFO] [stdout] | [INFO] [stdout] 32 | fn execute(&self, input: &str, args: impl AsRef<[String]>) -> Result<(), Str<'_>> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Some(self.program()?.args(["init", "--name", "runfile"])), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/rust.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 32 | fn execute(&self, input: &str, args: impl AsRef<[String]>) -> Result<(), Str<'_>> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | self.program()?.args(["build", "--color", "always"]), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lang/rust.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 32 | fn execute(&self, input: &str, args: impl AsRef<[String]>) -> Result<(), Str<'_>> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | self.program()?.args(["run", "-q", "--"]), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing/parser.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 124 | pub rule runfile(dir: &std::path::Path) -> Result, Vec> = __ elements:(var()/include(dir)/subcommand(dir)/... [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let mut commands = HashMap::with_hasher(xxhash_rust::xxh3::Xxh3Builder::new()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let mut subcommands = HashMap::with_hasher(xxhash_rust::xxh3::Xxh3Builder::new()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let mut includes = HashMap::with_hasher(xxhash_rust::xxh3::Xxh3Builder::new()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let mut vars = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | let mut errors = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | / Runfile { [INFO] [stdout] 159 | | doc: String::new(), [INFO] [stdout] 160 | | commands, [INFO] [stdout] 161 | | subcommands, [INFO] [stdout] 162 | | includes, [INFO] [stdout] 163 | | vars [INFO] [stdout] 164 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 20 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `runfile` (bin "run" test) due to 21 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "569e315f8211a9dbbf86bd76339e65376e9d7028f778e1f6946366ca4e3f2015", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "569e315f8211a9dbbf86bd76339e65376e9d7028f778e1f6946366ca4e3f2015", kill_on_drop: false }` [INFO] [stdout] 569e315f8211a9dbbf86bd76339e65376e9d7028f778e1f6946366ca4e3f2015