[INFO] fetching crate run_shell 0.1.13... [INFO] checking run_shell-0.1.13 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate run_shell 0.1.13 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate run_shell 0.1.13 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate run_shell 0.1.13 [INFO] finished tweaking crates.io crate run_shell 0.1.13 [INFO] tweaked toml for crates.io crate run_shell 0.1.13 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate run_shell 0.1.13 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6f9d45806009d70e3f2b5b456dc73d2f884d8fe330ad286cea15018db2c7ffd7 [INFO] running `Command { std: "docker" "start" "-a" "6f9d45806009d70e3f2b5b456dc73d2f884d8fe330ad286cea15018db2c7ffd7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6f9d45806009d70e3f2b5b456dc73d2f884d8fe330ad286cea15018db2c7ffd7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f9d45806009d70e3f2b5b456dc73d2f884d8fe330ad286cea15018db2c7ffd7", kill_on_drop: false }` [INFO] [stdout] 6f9d45806009d70e3f2b5b456dc73d2f884d8fe330ad286cea15018db2c7ffd7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f3d637f469819c043de44b95f6a7ddb3fe6f1e80b2c932c8a5d8f102e2bfff60 [INFO] running `Command { std: "docker" "start" "-a" "f3d637f469819c043de44b95f6a7ddb3fe6f1e80b2c932c8a5d8f102e2bfff60", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking ucd-util v0.1.9 [INFO] [stderr] Checking utf8-ranges v1.0.5 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking errno v0.2.8 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking run_shell v0.1.13 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:102:8 [INFO] [stdout] | [INFO] [stdout] 97 | let mut command = Command::new(&vec[0]); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Ok(ShellCommand::new(line, command)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/local_shell.rs:71:29 [INFO] [stdout] | [INFO] [stdout] 67 | let mut lock = PROCESS_MANAGER.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | LocalShellScope(id, arc.clone()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell_child.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn new(line: String, mut command: Command) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let shell = current_shell(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let mut lock = shell.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let child = command.spawn()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let process = Arc::new(RwLock::new(Some(ShellChildCore::new(line, child)))); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | lock.add_process(&process); [INFO] [stdout] 88 | Ok(ShellChild(process)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell_command.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn run(self) -> ShellResult { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | self.spawn().and_then(|job| job.wait()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell_command.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn stdout_utf8(mut self) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | self.command.stdout(Stdio::piped()); [INFO] [stdout] 30 | self.spawn()?.stdout_utf8() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `run_shell` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:102:8 [INFO] [stdout] | [INFO] [stdout] 97 | let mut command = Command::new(&vec[0]); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Ok(ShellCommand::new(line, command)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/local_shell.rs:71:29 [INFO] [stdout] | [INFO] [stdout] 67 | let mut lock = PROCESS_MANAGER.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | LocalShellScope(id, arc.clone()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell_child.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn new(line: String, mut command: Command) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let shell = current_shell(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let mut lock = shell.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let child = command.spawn()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let process = Arc::new(RwLock::new(Some(ShellChildCore::new(line, child)))); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | lock.add_process(&process); [INFO] [stdout] 88 | Ok(ShellChild(process)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell_command.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn run(self) -> ShellResult { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | self.spawn().and_then(|job| job.wait()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell_command.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn stdout_utf8(mut self) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | self.command.stdout(Stdio::piped()); [INFO] [stdout] 30 | self.spawn()?.stdout_utf8() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `run_shell` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "f3d637f469819c043de44b95f6a7ddb3fe6f1e80b2c932c8a5d8f102e2bfff60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f3d637f469819c043de44b95f6a7ddb3fe6f1e80b2c932c8a5d8f102e2bfff60", kill_on_drop: false }` [INFO] [stdout] f3d637f469819c043de44b95f6a7ddb3fe6f1e80b2c932c8a5d8f102e2bfff60