[INFO] fetching crate run-clang-tidy 0.3.0... [INFO] checking run-clang-tidy-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate run-clang-tidy 0.3.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate run-clang-tidy 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate run-clang-tidy 0.3.0 [INFO] finished tweaking crates.io crate run-clang-tidy 0.3.0 [INFO] tweaked toml for crates.io crate run-clang-tidy 0.3.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate run-clang-tidy 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9b3ae798bedb768141d9b2067539e6f12661aad53f6ba3aaf429ab227a7c9180 [INFO] running `Command { std: "docker" "start" "-a" "9b3ae798bedb768141d9b2067539e6f12661aad53f6ba3aaf429ab227a7c9180", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9b3ae798bedb768141d9b2067539e6f12661aad53f6ba3aaf429ab227a7c9180", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9b3ae798bedb768141d9b2067539e6f12661aad53f6ba3aaf429ab227a7c9180", kill_on_drop: false }` [INFO] [stdout] 9b3ae798bedb768141d9b2067539e6f12661aad53f6ba3aaf429ab227a7c9180 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cedba04c1464298f1dcb1d9caea9f784b806f59b65202a276aecbb504d903cea [INFO] running `Command { std: "docker" "start" "-a" "cedba04c1464298f1dcb1d9caea9f784b806f59b65202a276aecbb504d903cea", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Compiling schemars v0.8.16 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Compiling run-clang-tidy v0.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking color-spantrace v0.2.1 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking rayon v1.9.0 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Compiling serde_derive_internals v0.26.0 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Compiling schemars_derive v0.8.16 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking color-eyre v0.6.2 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking globmatch v0.3.0 [INFO] [stderr] Checking clap v4.5.2 [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/cli/handlers.rs:7:40 [INFO] [stdout] | [INFO] [stdout] 7 | fn display(&self, pi: &std::panic::PanicInfo<'_>, f: &mut fmt::Formatter<'_>) -> fmt::Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/cli/handlers.rs:7:40 [INFO] [stdout] | [INFO] [stdout] 7 | fn display(&self, pi: &std::panic::PanicInfo<'_>, f: &mut fmt::Formatter<'_>) -> fmt::Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:200:43 [INFO] [stdout] | [INFO] [stdout] 200 | let paths = paths.into_iter().map(|p| p.canonicalize().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/mod.rs:251:9 [INFO] [stdout] | [INFO] [stdout] 250 | let schema = schema_for!(JsonModel); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | serde_json::to_string_pretty(&schema).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/utils.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 176 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | root: Option

, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | let mut checks = vec![filename_or_exists(path_buf, root_buf.clone())]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | Err(checks.remove(0).unwrap_err()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/globs.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | fn wrap_result(result: eyre::Result, field: &str, file: &str) -> eyre::Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | / result [INFO] [stdout] 8 | | .wrap_err(format!("Error while parsing '{field}'")) [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/globs.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 16 | root: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | globmatch::wrappers::build_matchers(&globs, root).map_err(|err| eyre!(err)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `run-clang-tidy` (lib test) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:200:43 [INFO] [stdout] | [INFO] [stdout] 200 | let paths = paths.into_iter().map(|p| p.canonicalize().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/mod.rs:251:9 [INFO] [stdout] | [INFO] [stdout] 250 | let schema = schema_for!(JsonModel); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | serde_json::to_string_pretty(&schema).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/utils.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 176 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | root: Option

, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | let mut checks = vec![filename_or_exists(path_buf, root_buf.clone())]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | Err(checks.remove(0).unwrap_err()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/globs.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | fn wrap_result(result: eyre::Result, field: &str, file: &str) -> eyre::Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | / result [INFO] [stdout] 8 | | .wrap_err(format!("Error while parsing '{field}'")) [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/globs.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 16 | root: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | globmatch::wrappers::build_matchers(&globs, root).map_err(|err| eyre!(err)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `run-clang-tidy` (lib) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "cedba04c1464298f1dcb1d9caea9f784b806f59b65202a276aecbb504d903cea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cedba04c1464298f1dcb1d9caea9f784b806f59b65202a276aecbb504d903cea", kill_on_drop: false }` [INFO] [stdout] cedba04c1464298f1dcb1d9caea9f784b806f59b65202a276aecbb504d903cea