[INFO] fetching crate rumq-client 0.1.0-alpha.10... [INFO] checking rumq-client-0.1.0-alpha.10 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rumq-client 0.1.0-alpha.10 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate rumq-client 0.1.0-alpha.10 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rumq-client 0.1.0-alpha.10 [INFO] finished tweaking crates.io crate rumq-client 0.1.0-alpha.10 [INFO] tweaked toml for crates.io crate rumq-client 0.1.0-alpha.10 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate rumq-client 0.1.0-alpha.10 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4f2e28e70445c30ecd5407a67f5bf79ce13d10561ac7fa9af1dceeb51e3f6862 [INFO] running `Command { std: "docker" "start" "-a" "4f2e28e70445c30ecd5407a67f5bf79ce13d10561ac7fa9af1dceeb51e3f6862", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4f2e28e70445c30ecd5407a67f5bf79ce13d10561ac7fa9af1dceeb51e3f6862", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f2e28e70445c30ecd5407a67f5bf79ce13d10561ac7fa9af1dceeb51e3f6862", kill_on_drop: false }` [INFO] [stdout] 4f2e28e70445c30ecd5407a67f5bf79ce13d10561ac7fa9af1dceeb51e3f6862 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f64a8b14c2f2abd58b8def0067c5c6ab14c12d782e85f691e0f8d51089ca01ba [INFO] running `Command { std: "docker" "start" "-a" "f64a8b14c2f2abd58b8def0067c5c6ab14c12d782e85f691e0f8d51089ca01ba", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.69 [INFO] [stderr] Compiling proc-macro2 v1.0.10 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking untrusted v0.7.0 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking futures-core v0.3.4 [INFO] [stderr] Checking arc-swap v0.4.5 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Compiling serde v1.0.106 [INFO] [stderr] Checking bytes v0.5.4 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking pin-project-lite v0.1.4 [INFO] [stderr] Checking base64 v0.11.0 [INFO] [stderr] Checking smallvec v1.3.0 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Compiling ryu v1.0.3 [INFO] [stderr] Compiling proc-macro-nested v0.1.4 [INFO] [stderr] Checking arrayvec v0.5.1 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking futures-sink v0.3.4 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking lazycell v1.2.1 [INFO] [stderr] Compiling proc-macro-hack v0.5.15 [INFO] [stderr] Checking plain v0.2.3 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking gimli v0.20.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking pin-utils v0.1.0-alpha.4 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking futures-task v0.3.4 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Compiling ring v0.16.12 [INFO] [stderr] Compiling backtrace-sys v0.1.35 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking findshlibs v0.5.0 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Checking crossbeam-channel v0.4.2 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking regex v1.3.6 [INFO] [stderr] Checking simple_asn1 v0.4.0 [INFO] [stderr] Checking addr2line v0.11.0 [INFO] [stderr] Checking pem v0.7.0 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking sct v0.6.0 [INFO] [stderr] Checking webpki v0.21.2 [INFO] [stderr] Checking rustls v0.17.0 [INFO] [stderr] Compiling tokio-macros v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.106 [INFO] [stderr] Compiling scroll_derive v0.10.1 [INFO] [stderr] Compiling thiserror-impl v1.0.15 [INFO] [stderr] Compiling async-trait v0.1.30 [INFO] [stderr] Compiling async-stream-impl v0.2.1 [INFO] [stderr] Compiling futures-macro v0.3.4 [INFO] [stderr] Checking async-stream v0.2.1 [INFO] [stderr] Checking tokio v0.2.18 [INFO] [stderr] Checking scroll v0.10.1 [INFO] [stderr] Checking futures-util v0.3.4 [INFO] [stderr] Checking goblin v0.2.1 [INFO] [stderr] Checking thiserror v1.0.15 [INFO] [stderr] Checking tokio-util v0.3.1 [INFO] [stderr] Checking tokio-rustls v0.13.0 [INFO] [stderr] Checking backtrace v0.3.46 [INFO] [stderr] Checking rumq-core v0.1.0-alpha.10 [INFO] [stderr] Checking color-backtrace v0.3.0 [INFO] [stderr] Checking rumq-client v0.1.0-alpha.10 (/opt/rustwide/workdir) [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/lib.rs:111:24 [INFO] [stdout] | [INFO] [stdout] 111 | use rumq_core::mqtt4::{MqttRead, MqttWrite, Packet}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `MqttRead` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/lib.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | pub use rumq_core::mqtt4::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/lib.rs:111:24 [INFO] [stdout] | [INFO] [stdout] 111 | use rumq_core::mqtt4::{MqttRead, MqttWrite, Packet}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/lib.rs:111:34 [INFO] [stdout] | [INFO] [stdout] 111 | use rumq_core::mqtt4::{MqttRead, MqttWrite, Packet}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `MqttWrite` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/lib.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | pub use rumq_core::mqtt4::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/lib.rs:111:34 [INFO] [stdout] | [INFO] [stdout] 111 | use rumq_core::mqtt4::{MqttRead, MqttWrite, Packet}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/lib.rs:111:45 [INFO] [stdout] | [INFO] [stdout] 111 | use rumq_core::mqtt4::{MqttRead, MqttWrite, Packet}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `Packet` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/lib.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | pub use rumq_core::mqtt4::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/lib.rs:111:45 [INFO] [stdout] | [INFO] [stdout] 111 | use rumq_core::mqtt4::{MqttRead, MqttWrite, Packet}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eventloop.rs:77:19 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn eventloop(options: MqttOptions, requests: impl Requests + 'static) -> MqttEventLoop { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | requests: Box::new(requests), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 87 | let notification = None; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | Ok((notification, request)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:156:12 [INFO] [stdout] | [INFO] [stdout] 155 | let notification = Some(Notification::Suback(suback)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | Ok((notification, request)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:162:12 [INFO] [stdout] | [INFO] [stdout] 161 | let notification = Some(Notification::Unsuback(pkid)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | Ok((notification, request)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rumq-client` (lib) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "f64a8b14c2f2abd58b8def0067c5c6ab14c12d782e85f691e0f8d51089ca01ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f64a8b14c2f2abd58b8def0067c5c6ab14c12d782e85f691e0f8d51089ca01ba", kill_on_drop: false }` [INFO] [stdout] f64a8b14c2f2abd58b8def0067c5c6ab14c12d782e85f691e0f8d51089ca01ba