[INFO] fetching crate rumq-broker 0.1.0-alpha.10... [INFO] checking rumq-broker-0.1.0-alpha.10 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rumq-broker 0.1.0-alpha.10 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate rumq-broker 0.1.0-alpha.10 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rumq-broker 0.1.0-alpha.10 [INFO] finished tweaking crates.io crate rumq-broker 0.1.0-alpha.10 [INFO] tweaked toml for crates.io crate rumq-broker 0.1.0-alpha.10 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 73 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.11.0 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytes v0.5.6 (latest: v1.7.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding miow v0.3.7 (latest: v0.6.0) [INFO] [stderr] Adding pin-project-lite v0.1.12 (latest: v0.2.14) [INFO] [stderr] Adding ring v0.16.20 (latest: v0.17.8) [INFO] [stderr] Adding rustls v0.17.0 (latest: v0.23.12) [INFO] [stderr] Adding sct v0.6.1 (latest: v0.7.1) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tokio v0.2.25 (latest: v1.40.0) [INFO] [stderr] Adding tokio-macros v0.2.6 (latest: v2.4.0) [INFO] [stderr] Adding tokio-rustls v0.13.1 (latest: v0.26.0) [INFO] [stderr] Adding tokio-util v0.3.1 (latest: v0.7.11) [INFO] [stderr] Adding untrusted v0.7.1 (latest: v0.9.0) [INFO] [stderr] Adding webpki v0.21.4 (latest: v0.22.4) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2a7bbd46c92b149a8ce3e3634034c347ce84370f3e28d6ca1ede79ba311e25e7 [INFO] running `Command { std: "docker" "start" "-a" "2a7bbd46c92b149a8ce3e3634034c347ce84370f3e28d6ca1ede79ba311e25e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2a7bbd46c92b149a8ce3e3634034c347ce84370f3e28d6ca1ede79ba311e25e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2a7bbd46c92b149a8ce3e3634034c347ce84370f3e28d6ca1ede79ba311e25e7", kill_on_drop: false }` [INFO] [stdout] 2a7bbd46c92b149a8ce3e3634034c347ce84370f3e28d6ca1ede79ba311e25e7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 77848c2380d5749072f16e087a08cf7c6a39769e01d397b98001c9e9d47348f6 [INFO] running `Command { std: "docker" "start" "-a" "77848c2380d5749072f16e087a08cf7c6a39769e01d397b98001c9e9d47348f6", kill_on_drop: false }` [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking pin-project-lite v0.1.12 [INFO] [stderr] Checking base64 v0.11.0 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling tokio-macros v0.2.6 [INFO] [stderr] Checking tokio v0.2.25 [INFO] [stderr] Checking webpki v0.21.4 [INFO] [stderr] Checking sct v0.6.1 [INFO] [stderr] Checking rustls v0.17.0 [INFO] [stderr] Checking tokio-util v0.3.1 [INFO] [stderr] Checking tokio-rustls v0.13.1 [INFO] [stderr] Checking rumq-core v0.1.0-alpha.10 [INFO] [stderr] Checking rumq-broker v0.1.0-alpha.10 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `last_outgoing` is never read [INFO] [stdout] --> src/state.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 50 | pub struct MqttState { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 54 | last_outgoing: Instant, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MqttState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `AllSendersDown` is never constructed [INFO] [stdout] --> src/router.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub enum Error { [INFO] [stdout] | ----- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 19 | AllSendersDown, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:144:23 [INFO] [stdout] | [INFO] [stdout] 130 | let config = connection_config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | let router_tx = router_tx.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | let framed = Framed::new(stream, codec::MqttCodec::new(config.max_payload_size)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | task::spawn( async { [INFO] [stdout] 144 | match connection::eventloop(config, framed, router_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:152:23 [INFO] [stdout] | [INFO] [stdout] 130 | let config = connection_config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | let router_tx = router_tx.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let framed = Framed::new(stream, codec::MqttCodec::new(config.max_payload_size)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | task::spawn( async { [INFO] [stdout] 152 | match connection::eventloop(config, framed, router_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:188:12 [INFO] [stdout] | [INFO] [stdout] 187 | let routermessage = RouterMessage::Packet(packet); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | Ok(Some(routermessage)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 193 | let routermessage = RouterMessage::Packet(packet); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | Ok(Some(routermessage)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:50:21 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(connect: Connect, handle: Sender) -> Connection { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | handle: Some(handle) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:126:33 [INFO] [stdout] | [INFO] [stdout] 124 | pub fn new(data_rx: Receiver<(String, RouterMessage)>) -> Self { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | Router { [INFO] [stdout] 126 | active_connections: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `last_outgoing` is never read [INFO] [stdout] --> src/state.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 50 | pub struct MqttState { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 54 | last_outgoing: Instant, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MqttState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `AllSendersDown` is never constructed [INFO] [stdout] --> src/router.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub enum Error { [INFO] [stdout] | ----- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 19 | AllSendersDown, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:144:23 [INFO] [stdout] | [INFO] [stdout] 130 | let config = connection_config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | let router_tx = router_tx.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | let framed = Framed::new(stream, codec::MqttCodec::new(config.max_payload_size)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | task::spawn( async { [INFO] [stdout] 144 | match connection::eventloop(config, framed, router_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:152:23 [INFO] [stdout] | [INFO] [stdout] 130 | let config = connection_config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | let router_tx = router_tx.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let framed = Framed::new(stream, codec::MqttCodec::new(config.max_payload_size)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | task::spawn( async { [INFO] [stdout] 152 | match connection::eventloop(config, framed, router_tx).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:188:12 [INFO] [stdout] | [INFO] [stdout] 187 | let routermessage = RouterMessage::Packet(packet); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | Ok(Some(routermessage)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 193 | let routermessage = RouterMessage::Packet(packet); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | Ok(Some(routermessage)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:50:21 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(connect: Connect, handle: Sender) -> Connection { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | handle: Some(handle) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:126:33 [INFO] [stdout] | [INFO] [stdout] 124 | pub fn new(data_rx: Receiver<(String, RouterMessage)>) -> Self { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | Router { [INFO] [stdout] 126 | active_connections: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rumq-broker` (lib) due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rumq-broker` (lib test) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "77848c2380d5749072f16e087a08cf7c6a39769e01d397b98001c9e9d47348f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "77848c2380d5749072f16e087a08cf7c6a39769e01d397b98001c9e9d47348f6", kill_on_drop: false }` [INFO] [stdout] 77848c2380d5749072f16e087a08cf7c6a39769e01d397b98001c9e9d47348f6