[INFO] fetching crate rufi_core 15.1.1... [INFO] checking rufi_core-15.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rufi_core 15.1.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate rufi_core 15.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rufi_core 15.1.1 [INFO] finished tweaking crates.io crate rufi_core 15.1.1 [INFO] tweaked toml for crates.io crate rufi_core 15.1.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 16 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f4c51f4adf4422564b97c8070eb6382aa2cf2914b9f07df52368f3fbd3034ed1 [INFO] running `Command { std: "docker" "start" "-a" "f4c51f4adf4422564b97c8070eb6382aa2cf2914b9f07df52368f3fbd3034ed1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f4c51f4adf4422564b97c8070eb6382aa2cf2914b9f07df52368f3fbd3034ed1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4c51f4adf4422564b97c8070eb6382aa2cf2914b9f07df52368f3fbd3034ed1", kill_on_drop: false }` [INFO] [stdout] f4c51f4adf4422564b97c8070eb6382aa2cf2914b9f07df52368f3fbd3034ed1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4ca4205a526092e18e07801aad3bc0798f14aec1fca0bea80d2a6cb54f6ec736 [INFO] running `Command { std: "docker" "start" "-a" "4ca4205a526092e18e07801aad3bc0798f14aec1fca0bea80d2a6cb54f6ec736", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rufi_core v15.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `init_vm` is never used [INFO] [stdout] --> src/core/lang/test/utils.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn init_vm() -> RoundVM { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `init_with_ctx` is never used [INFO] [stdout] --> src/core/lang/test/utils.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn init_with_ctx(ctx: Context) -> RoundVM { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `push_to_ctx` is never used [INFO] [stdout] --> src/core/lang/test/utils.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn push_to_ctx(mut ctx: Context, path: Path, val: A) -> Context { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `vm` is never used [INFO] [stdout] --> src/core/lang/test/utils.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn vm(self_id: i32, local_sensor: HashMap>>, nbr_sensor: HashMap>>>,... [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `compose` is never used [INFO] [stdout] --> src/core/lang/test/utils.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn compose(expr1: F, expr2: G) -> impl Fn(RoundVM) -> (RoundVM, A) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `combine` is never used [INFO] [stdout] --> src/core/lang/test/utils.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn combine(expr1: F, expr2: G, comb: H) -> impl Fn(RoundVM) -> (RoundVM, A) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `assert_equivalence` is never used [INFO] [stdout] --> src/core/lang/test/utils.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn assert_equivalence(exec_order: Vec, nbrs: HashMap>, program_1: F, program_2: G) -> bool [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `assert_equivalence_rec` is never used [INFO] [stdout] --> src/core/lang/test/utils.rs:75:4 [INFO] [stdout] | [INFO] [stdout] 75 | fn assert_equivalence_rec(mut exec_order: Vec, states: HashMap, program_1: F, program_2: G) -> bool [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `fully_connected_topology_map` is never used [INFO] [stdout] --> src/core/lang/test/utils.rs:102:8 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn fully_connected_topology_map(elems: Vec) -> HashMap> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/core/vm/round_vm.rs:218:37 [INFO] [stdout] | [INFO] [stdout] 218 | .filter(|(id, _)| id.clone() != &self.self_id()) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `i32` does not implement `Clone`, so calling `clone` on `&i32` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/lang/test/utils.rs:53:16 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn combine(expr1: F, expr2: G, comb: H) -> impl Fn(RoundVM) -> (RoundVM, A) [INFO] [stdout] | ----- ----- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | move |vm| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let (vm_, res1) = expr1(vm); [INFO] [stdout] | --- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let (vm__, res2) = expr2(vm_); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | (vm__, comb(res1, res2)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/lang/test/utils.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 64 | let ex_1: HashMap = neighbors.iter().map(|nbr| (nbr.clone(), Export::new())).collect(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let ex_2: HashMap = neighbors.iter().map(|nbr| (nbr.clone(), Export::new())).collect(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | / (vm(curr.clone(), Default::default(), Default::default(), ex_1), [INFO] [stdout] 69 | | vm(curr.clone(), Default::default(), Default::default(), ex_2)) [INFO] [stdout] | |____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/lang/test/utils.rs:64:83 [INFO] [stdout] | [INFO] [stdout] 64 | let ex_1: HashMap = neighbors.iter().map(|nbr| (nbr.clone(), Export::new())).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/lang/test/utils.rs:65:83 [INFO] [stdout] | [INFO] [stdout] 65 | let ex_2: HashMap = neighbors.iter().map(|nbr| (nbr.clone(), Export::new())).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rufi_core` (lib) due to 5 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `fixture` [INFO] [stdout] --> src/core/lang/test/by_equivalence.rs:48:17 [INFO] [stdout] | [INFO] [stdout] 48 | let fixture = Fixture::new(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_fixture` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `gradient_1` [INFO] [stdout] --> src/core/lang/test/by_equivalence.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | let gradient_1 = [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_gradient_1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `compose` is never used [INFO] [stdout] --> src/core/lang/test/utils.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn compose(expr1: F, expr2: G) -> impl Fn(RoundVM) -> (RoundVM, A) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/core/vm/round_vm.rs:218:37 [INFO] [stdout] | [INFO] [stdout] 218 | .filter(|(id, _)| id.clone() != &self.self_id()) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `i32` does not implement `Clone`, so calling `clone` on `&i32` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary allocation, use `&` instead [INFO] [stdout] --> src/core/vm/round_vm.rs:346:26 [INFO] [stdout] | [INFO] [stdout] 346 | vm.register_root(Box::new(expr)()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_allocation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/core/lang/test/by_round.rs:260:68 [INFO] [stdout] | [INFO] [stdout] 260 | let val = vm.local_sense::<&str>(&sensor("b")).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/lang/test/utils.rs:53:16 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn combine(expr1: F, expr2: G, comb: H) -> impl Fn(RoundVM) -> (RoundVM, A) [INFO] [stdout] | ----- ----- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | move |vm| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let (vm_, res1) = expr1(vm); [INFO] [stdout] | --- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let (vm__, res2) = expr2(vm_); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | (vm__, comb(res1, res2)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/lang/test/utils.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 64 | let ex_1: HashMap = neighbors.iter().map(|nbr| (nbr.clone(), Export::new())).collect(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let ex_2: HashMap = neighbors.iter().map(|nbr| (nbr.clone(), Export::new())).collect(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | / (vm(curr.clone(), Default::default(), Default::default(), ex_1), [INFO] [stdout] 69 | | vm(curr.clone(), Default::default(), Default::default(), ex_2)) [INFO] [stdout] | |____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/lang/test/utils.rs:64:83 [INFO] [stdout] | [INFO] [stdout] 64 | let ex_1: HashMap = neighbors.iter().map(|nbr| (nbr.clone(), Export::new())).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/lang/test/utils.rs:65:83 [INFO] [stdout] | [INFO] [stdout] 65 | let ex_2: HashMap = neighbors.iter().map(|nbr| (nbr.clone(), Export::new())).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rufi_core` (lib test) due to 5 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4ca4205a526092e18e07801aad3bc0798f14aec1fca0bea80d2a6cb54f6ec736", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4ca4205a526092e18e07801aad3bc0798f14aec1fca0bea80d2a6cb54f6ec736", kill_on_drop: false }` [INFO] [stdout] 4ca4205a526092e18e07801aad3bc0798f14aec1fca0bea80d2a6cb54f6ec736