[INFO] fetching crate rudolfs 0.3.7... [INFO] checking rudolfs-0.3.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rudolfs 0.3.7 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate rudolfs 0.3.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rudolfs 0.3.7 [INFO] finished tweaking crates.io crate rudolfs 0.3.7 [INFO] tweaked toml for crates.io crate rudolfs 0.3.7 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate rudolfs 0.3.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_core` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_s3` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_sts` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fd5b6f6a87be504605c8d23fec07266fcd6e6c705388b70b708d47c57dbc3a90 [INFO] running `Command { std: "docker" "start" "-a" "fd5b6f6a87be504605c8d23fec07266fcd6e6c705388b70b708d47c57dbc3a90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fd5b6f6a87be504605c8d23fec07266fcd6e6c705388b70b708d47c57dbc3a90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fd5b6f6a87be504605c8d23fec07266fcd6e6c705388b70b708d47c57dbc3a90", kill_on_drop: false }` [INFO] [stdout] fd5b6f6a87be504605c8d23fec07266fcd6e6c705388b70b708d47c57dbc3a90 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d8ef28e1a034237490fb8234060f8cfa0bd0ea4274f65dbc313ff64dc61af0bc [INFO] running `Command { std: "docker" "start" "-a" "d8ef28e1a034237490fb8234060f8cfa0bd0ea4274f65dbc313ff64dc61af0bc", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_core` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_s3` dependency) [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `rusoto_sts` dependency) [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling serde v1.0.200 [INFO] [stderr] Compiling cc v1.0.96 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Compiling rustls v0.20.9 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking crypto-mac v0.11.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking md-5 v0.9.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking hmac v0.11.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling mime v0.3.17 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking quote v1.0.36 [INFO] [stderr] Compiling askama_escape v0.10.3 [INFO] [stderr] Checking xml-rs v0.8.20 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling rusoto_core v0.48.0 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking humansize v1.1.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking keystream v1.0.0 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking chacha v0.3.0 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking human-size v0.4.3 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking os_pipe v1.1.5 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking shared_child v1.0.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking duct v0.13.7 [INFO] [stderr] Checking rustix v0.38.34 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling serde_derive v1.0.200 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking webpki v0.22.4 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-rustls v0.23.4 [INFO] [stderr] Checking backoff v0.4.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking askama_shared v0.12.2 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Compiling askama_derive v0.11.2 [INFO] [stderr] Checking askama v0.11.1 [INFO] [stderr] Checking rusoto_credential v0.48.0 [INFO] [stderr] Checking hyper-rustls v0.23.2 [INFO] [stderr] Checking rusoto_signature v0.48.0 [INFO] [stderr] Checking rusoto_s3 v0.48.0 [INFO] [stderr] Checking rusoto_sts v0.48.0 [INFO] [stderr] Checking rudolfs v0.3.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Error as CacheError` [INFO] [stdout] --> src/storage/mod.rs:29:37 [INFO] [stdout] | [INFO] [stdout] 29 | pub use cached::{Backend as Cached, Error as CacheError}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error as CacheError` [INFO] [stdout] --> src/storage/mod.rs:29:37 [INFO] [stdout] | [INFO] [stdout] 29 | pub use cached::{Backend as Cached, Error as CacheError}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:307:5 [INFO] [stdout] | [INFO] [stdout] 291 | fn spawn_server(storage: S, addr: &SocketAddr) -> impl Server [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 297 | let storage = Arc::new(storage); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | [INFO] [stdout] 299 | let new_service = make_service_fn(move |socket: &AddrStream| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 307 | hyper::Server::bind(addr).serve(new_service) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:304:37 [INFO] [stdout] | [INFO] [stdout] 297 | let storage = Arc::new(storage); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 301 | let service = App::new(storage.clone()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | future::ok::<_, Infallible>(Logger::new(socket.remote_addr(), service)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 62 | Ok(bytes.into()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 90 | fn index(req: Request) -> Result, Error> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let template = IndexTemplate { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(Response::builder() [INFO] [stdout] | ____________^ [INFO] [stdout] 97 | | .status(StatusCode::OK) [INFO] [stdout] 98 | | .body(template.render()?.into())?) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 102 | fn not_found(_req: Request) -> Result, Error> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | Ok(Response::builder() [INFO] [stdout] | ____________^ [INFO] [stdout] 104 | | .status(StatusCode::NOT_FOUND) [INFO] [stdout] 105 | | .body("Not found".into())?) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:273:26 [INFO] [stdout] | [INFO] [stdout] 262 | let uri = uri.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 266 | let size = storage.size(&key).await; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | .await) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hyperext.rs:53:32 [INFO] [stdout] | [INFO] [stdout] 53 | .and_then(|scheme| Scheme::try_from(scheme.as_bytes()).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logger.rs:69:18 [INFO] [stdout] | [INFO] [stdout] 62 | fn call(&mut self, req: Request) -> Self::Future { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let method = req.method().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | let uri = req.uri().clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Box::pin(self.service.call(req).inspect( [INFO] [stdout] | __________________^ [INFO] [stdout] 70 | | move |response| match response { [INFO] [stdout] 71 | | Ok(response) => log::info!( [INFO] [stdout] 72 | | "[{}] {} {} - {} ({})", [INFO] [stdout] ... | [INFO] [stdout] 87 | | }, [INFO] [stdout] 88 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/mod.rs:259:34 [INFO] [stdout] | [INFO] [stdout] 258 | value: LFSObject, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | ) -> Result<(), Self::Error> { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 260 | | self.as_ref().put(key, value).await [INFO] [stdout] 261 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/cached.rs:294:34 [INFO] [stdout] | [INFO] [stdout] 293 | value: LFSObject, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 294 | ) -> Result<(), Self::Error> { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 295 | | let lru = self.lru.clone(); [INFO] [stdout] 296 | | let max_size = self.max_size; [INFO] [stdout] 297 | | let cache = self.cache.clone(); [INFO] [stdout] ... | [INFO] [stdout] 343 | | Ok(()) [INFO] [stdout] 344 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/disk.rs:93:34 [INFO] [stdout] | [INFO] [stdout] 92 | value: LFSObject, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | ) -> Result<(), Self::Error> { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 94 | | let path = self.key_to_path(&key); [INFO] [stdout] 95 | | let dir = path.parent().unwrap().to_path_buf(); [INFO] [stdout] ... | [INFO] [stdout] 128 | | } [INFO] [stdout] 129 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/disk.rs:197:18 [INFO] [stdout] | [INFO] [stdout] 177 | let objects = try_stream! { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | Box::pin(objects.filter_map(move |entry: io::Result<_>| { [INFO] [stdout] | __________________^ [INFO] [stdout] 198 | | // Helper function to be able to use the ?-operator on [INFO] [stdout] 199 | | // `Option` types. [INFO] [stdout] 200 | | fn do_it( [INFO] [stdout] ... | [INFO] [stdout] 249 | | } [INFO] [stdout] 250 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/encrypt.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 49 | stream.map(move |bytes| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let mut bytes = BytesMut::from(bytes?.as_ref()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(bytes.freeze()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/encrypt.rs:83:33 [INFO] [stdout] | [INFO] [stdout] 81 | Ok(self.storage.get(key).await?.map(move |obj| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let (len, stream) = obj.into_parts(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | LFSObject::new(len, Box::pin(xor_stream(chacha, stream))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/encrypt.rs:91:34 [INFO] [stdout] | [INFO] [stdout] 90 | value: LFSObject, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | ) -> Result<(), Self::Error> { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 92 | | // Use the first part of the SHA256 as the nonce. [INFO] [stdout] 93 | | let mut nonce: [u8; 24] = [0; 24]; [INFO] [stdout] 94 | | nonce.copy_from_slice(&key.oid().bytes()[0..24]); [INFO] [stdout] ... | [INFO] [stdout] 103 | | .await [INFO] [stdout] 104 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/retrying.rs:37:22 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(storage: S) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Backend { [INFO] [stdout] 37 | storage: Arc::new(storage), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/retrying.rs:63:34 [INFO] [stdout] | [INFO] [stdout] 62 | value: LFSObject, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | ) -> Result<(), Self::Error> { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 64 | | // Due to their streaming nature, this can't be retried by the server. [INFO] [stdout] 65 | | // The client should retry this if it fails. [INFO] [stdout] 66 | | self.storage.put(key, value).await [INFO] [stdout] 67 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/s3.rs:300:34 [INFO] [stdout] | [INFO] [stdout] 299 | value: LFSObject, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 300 | ) -> Result<(), Self::Error> { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 301 | | let (_len, stream) = value.into_parts(); [INFO] [stdout] 302 | | [INFO] [stdout] 303 | | let mu_response = retry(ExponentialBackoff::default(), || async { [INFO] [stdout] ... | [INFO] [stdout] 403 | | Ok(()) [INFO] [stdout] 404 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/verify.rs:57:22 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(storage: S) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Backend { [INFO] [stdout] 57 | storage: Arc::new(storage), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/verify.rs:106:67 [INFO] [stdout] | [INFO] [stdout] 101 | ... let storage = storage.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | ... async move { storage.delete(&key).await }, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/verify.rs:128:34 [INFO] [stdout] | [INFO] [stdout] 127 | value: LFSObject, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | ) -> Result<(), Self::Error> { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 129 | | let (len, stream) = value.into_parts(); [INFO] [stdout] 130 | | [INFO] [stdout] 131 | | let stream = [INFO] [stdout] ... | [INFO] [stdout] 142 | | .await [INFO] [stdout] 143 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rudolfs` (lib test) due to 22 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:307:5 [INFO] [stdout] | [INFO] [stdout] 291 | fn spawn_server(storage: S, addr: &SocketAddr) -> impl Server [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 297 | let storage = Arc::new(storage); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | [INFO] [stdout] 299 | let new_service = make_service_fn(move |socket: &AddrStream| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 307 | hyper::Server::bind(addr).serve(new_service) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:304:37 [INFO] [stdout] | [INFO] [stdout] 297 | let storage = Arc::new(storage); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 301 | let service = App::new(storage.clone()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | future::ok::<_, Infallible>(Logger::new(socket.remote_addr(), service)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 62 | Ok(bytes.into()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 90 | fn index(req: Request) -> Result, Error> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let template = IndexTemplate { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(Response::builder() [INFO] [stdout] | ____________^ [INFO] [stdout] 97 | | .status(StatusCode::OK) [INFO] [stdout] 98 | | .body(template.render()?.into())?) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 102 | fn not_found(_req: Request) -> Result, Error> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | Ok(Response::builder() [INFO] [stdout] | ____________^ [INFO] [stdout] 104 | | .status(StatusCode::NOT_FOUND) [INFO] [stdout] 105 | | .body("Not found".into())?) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:273:26 [INFO] [stdout] | [INFO] [stdout] 262 | let uri = uri.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 266 | let size = storage.size(&key).await; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | .await) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hyperext.rs:53:32 [INFO] [stdout] | [INFO] [stdout] 53 | .and_then(|scheme| Scheme::try_from(scheme.as_bytes()).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logger.rs:69:18 [INFO] [stdout] | [INFO] [stdout] 62 | fn call(&mut self, req: Request) -> Self::Future { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let method = req.method().clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | let uri = req.uri().clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Box::pin(self.service.call(req).inspect( [INFO] [stdout] | __________________^ [INFO] [stdout] 70 | | move |response| match response { [INFO] [stdout] 71 | | Ok(response) => log::info!( [INFO] [stdout] 72 | | "[{}] {} {} - {} ({})", [INFO] [stdout] ... | [INFO] [stdout] 87 | | }, [INFO] [stdout] 88 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/mod.rs:259:34 [INFO] [stdout] | [INFO] [stdout] 258 | value: LFSObject, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | ) -> Result<(), Self::Error> { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 260 | | self.as_ref().put(key, value).await [INFO] [stdout] 261 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/cached.rs:294:34 [INFO] [stdout] | [INFO] [stdout] 293 | value: LFSObject, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 294 | ) -> Result<(), Self::Error> { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 295 | | let lru = self.lru.clone(); [INFO] [stdout] 296 | | let max_size = self.max_size; [INFO] [stdout] 297 | | let cache = self.cache.clone(); [INFO] [stdout] ... | [INFO] [stdout] 343 | | Ok(()) [INFO] [stdout] 344 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/disk.rs:93:34 [INFO] [stdout] | [INFO] [stdout] 92 | value: LFSObject, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | ) -> Result<(), Self::Error> { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 94 | | let path = self.key_to_path(&key); [INFO] [stdout] 95 | | let dir = path.parent().unwrap().to_path_buf(); [INFO] [stdout] ... | [INFO] [stdout] 128 | | } [INFO] [stdout] 129 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/disk.rs:197:18 [INFO] [stdout] | [INFO] [stdout] 177 | let objects = try_stream! { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | Box::pin(objects.filter_map(move |entry: io::Result<_>| { [INFO] [stdout] | __________________^ [INFO] [stdout] 198 | | // Helper function to be able to use the ?-operator on [INFO] [stdout] 199 | | // `Option` types. [INFO] [stdout] 200 | | fn do_it( [INFO] [stdout] ... | [INFO] [stdout] 249 | | } [INFO] [stdout] 250 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/encrypt.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 49 | stream.map(move |bytes| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let mut bytes = BytesMut::from(bytes?.as_ref()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(bytes.freeze()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/encrypt.rs:83:33 [INFO] [stdout] | [INFO] [stdout] 81 | Ok(self.storage.get(key).await?.map(move |obj| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let (len, stream) = obj.into_parts(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | LFSObject::new(len, Box::pin(xor_stream(chacha, stream))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/encrypt.rs:91:34 [INFO] [stdout] | [INFO] [stdout] 90 | value: LFSObject, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | ) -> Result<(), Self::Error> { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 92 | | // Use the first part of the SHA256 as the nonce. [INFO] [stdout] 93 | | let mut nonce: [u8; 24] = [0; 24]; [INFO] [stdout] 94 | | nonce.copy_from_slice(&key.oid().bytes()[0..24]); [INFO] [stdout] ... | [INFO] [stdout] 103 | | .await [INFO] [stdout] 104 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/retrying.rs:37:22 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(storage: S) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Backend { [INFO] [stdout] 37 | storage: Arc::new(storage), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/retrying.rs:63:34 [INFO] [stdout] | [INFO] [stdout] 62 | value: LFSObject, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | ) -> Result<(), Self::Error> { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 64 | | // Due to their streaming nature, this can't be retried by the server. [INFO] [stdout] 65 | | // The client should retry this if it fails. [INFO] [stdout] 66 | | self.storage.put(key, value).await [INFO] [stdout] 67 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/s3.rs:300:34 [INFO] [stdout] | [INFO] [stdout] 299 | value: LFSObject, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 300 | ) -> Result<(), Self::Error> { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 301 | | let (_len, stream) = value.into_parts(); [INFO] [stdout] 302 | | [INFO] [stdout] 303 | | let mu_response = retry(ExponentialBackoff::default(), || async { [INFO] [stdout] ... | [INFO] [stdout] 403 | | Ok(()) [INFO] [stdout] 404 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/verify.rs:57:22 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(storage: S) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Backend { [INFO] [stdout] 57 | storage: Arc::new(storage), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/verify.rs:106:67 [INFO] [stdout] | [INFO] [stdout] 101 | ... let storage = storage.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | ... async move { storage.delete(&key).await }, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/verify.rs:128:34 [INFO] [stdout] | [INFO] [stdout] 127 | value: LFSObject, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | ) -> Result<(), Self::Error> { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 129 | | let (len, stream) = value.into_parts(); [INFO] [stdout] 130 | | [INFO] [stdout] 131 | | let stream = [INFO] [stdout] ... | [INFO] [stdout] 142 | | .await [INFO] [stdout] 143 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rudolfs` (lib) due to 22 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "d8ef28e1a034237490fb8234060f8cfa0bd0ea4274f65dbc313ff64dc61af0bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d8ef28e1a034237490fb8234060f8cfa0bd0ea4274f65dbc313ff64dc61af0bc", kill_on_drop: false }` [INFO] [stdout] d8ef28e1a034237490fb8234060f8cfa0bd0ea4274f65dbc313ff64dc61af0bc