[INFO] fetching crate rucola-notes 0.4.0... [INFO] checking rucola-notes-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rucola-notes 0.4.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate rucola-notes 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rucola-notes 0.4.0 [INFO] finished tweaking crates.io crate rucola-notes 0.4.0 [INFO] tweaked toml for crates.io crate rucola-notes 0.4.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate rucola-notes 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a1069c0c681baa601eb65a83d73f0bf7b673c97d5e2cd0d69f314cc46f4510b2 [INFO] running `Command { std: "docker" "start" "-a" "a1069c0c681baa601eb65a83d73f0bf7b673c97d5e2cd0d69f314cc46f4510b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a1069c0c681baa601eb65a83d73f0bf7b673c97d5e2cd0d69f314cc46f4510b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a1069c0c681baa601eb65a83d73f0bf7b673c97d5e2cd0d69f314cc46f4510b2", kill_on_drop: false }` [INFO] [stdout] a1069c0c681baa601eb65a83d73f0bf7b673c97d5e2cd0d69f314cc46f4510b2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9c5032ee9851b98496a0259f8c2922310a60b94581deed36c13d2eab1bd5dbf6 [INFO] running `Command { std: "docker" "start" "-a" "9c5032ee9851b98496a0259f8c2922310a60b94581deed36c13d2eab1bd5dbf6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling cc v1.0.106 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling syn v2.0.70 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling option-ext v0.2.0 [INFO] [stderr] Compiling winnow v0.6.13 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling camino v1.1.7 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Compiling dirs-sys v0.4.1 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling directories v5.0.1 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking is-docker v0.2.0 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking deunicode v1.6.0 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Compiling onig_sys v69.8.1 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking slug v0.1.5 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking is-wsl v0.4.0 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking unicode-truncate v1.0.0 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking object v0.36.1 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking entities v1.0.1 [INFO] [stderr] Checking unicode_categories v0.1.1 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking open v5.2.0 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking sysinfo v0.26.9 [INFO] [stderr] Checking whoami v1.5.1 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Compiling darling_core v0.20.9 [INFO] [stderr] Compiling serde_spanned v0.6.6 [INFO] [stderr] Compiling toml_datetime v0.6.6 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling toml_edit v0.22.15 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling clap_derive v4.5.8 [INFO] [stderr] Compiling instability v0.3.2 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Checking pwd v1.4.0 [INFO] [stderr] Checking expanduser v1.2.2 [INFO] [stderr] Compiling darling_macro v0.20.9 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling darling v0.20.9 [INFO] [stderr] Compiling derive_builder_core v0.20.0 [INFO] [stderr] Compiling caseless v0.2.1 [INFO] [stderr] Compiling toml v0.8.14 [INFO] [stderr] Checking onig v6.4.0 [INFO] [stderr] Compiling derive_builder_macro v0.20.0 [INFO] [stderr] Compiling confy v0.6.1 [INFO] [stderr] Compiling rucola-notes v0.4.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking derive_builder v0.20.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking compact_str v0.8.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking syntect v5.2.0 [INFO] [stderr] Checking cargo_metadata v0.14.2 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking clap_builder v4.5.8 [INFO] [stderr] Checking testdir v0.9.1 [INFO] [stderr] Checking ratatui v0.28.0 [INFO] [stderr] Checking clap v4.5.8 [INFO] [stderr] Checking comrak v0.26.0 [INFO] [stderr] Checking tui-textarea v0.6.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:115:15 [INFO] [stdout] | [INFO] [stdout] 115 | match app.update(maybe_keypress) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:99:13 [INFO] [stdout] | [INFO] [stdout] 36 | mut loading_screen_callback: F, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let mut errors = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let tracker = match io::FileTracker::new(&config, vault_path.clone()) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Ok(tracker) => tracker, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let (index, index_errors) = data::NoteIndex::new(tracker, builder.clone()); [INFO] [stdout] | ----- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let index = std::rc::Rc::new(std::cell::RefCell::new(index)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | / Self { [INFO] [stdout] 100 | | select: ui::screen::SelectScreen::new( [INFO] [stdout] 101 | | index.clone(), [INFO] [stdout] 102 | | manager.clone(), [INFO] [stdout] ... | [INFO] [stdout] 112 | | builder, [INFO] [stdout] 113 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:198:12 [INFO] [stdout] | [INFO] [stdout] 140 | let mut index = self.index.borrow_mut(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | let msg = if let Some(display) = &mut self.display { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let msg = msg?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | Ok(msg.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:99:36 [INFO] [stdout] | [INFO] [stdout] 99 | .and_then(|arg_string| expanduser::expanduser(arg_string).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/note.rs:53:19 [INFO] [stdout] | [INFO] [stdout] 53 | path: path.canonicalize().unwrap_or(path.to_path_buf()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/note.rs:57:41 [INFO] [stdout] | [INFO] [stdout] 57 | .flat_map(|node| match &node.data.borrow().value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/note.rs:69:41 [INFO] [stdout] | [INFO] [stdout] 69 | .flat_map(|node| match &node.data.borrow().value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/note_statistics.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 40 | fn to_row(&self, index: data::NoteIndexContainer, styles: &ui::UiStyles) -> Option { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | // generate the stats row for each element [INFO] [stdout] 42 | index.borrow().get(&self.id).map(|note| { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/note_statistics.rs:165:30 [INFO] [stdout] | [INFO] [stdout] 100 | let index = index.borrow(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | tag_count_total: filtered_index [INFO] [stdout] | ______________________________^ [INFO] [stdout] 166 | | .values() [INFO] [stdout] 167 | | .flat_map(|(_, stats)| &stats.tags) [INFO] [stdout] 168 | | .collect::>() [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/note_statistics.rs:273:50 [INFO] [stdout] | [INFO] [stdout] 273 | .flat_map(|note_env| note_env.to_row(index.clone(), styles)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/index.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 38 | mut tracker: io::FileTracker, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let mut errors = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | / Self { [INFO] [stdout] 80 | | inner, [INFO] [stdout] 81 | | tracker, [INFO] [stdout] 82 | | builder, [INFO] [stdout] 83 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/index.rs:48:29 [INFO] [stdout] | [INFO] [stdout] 48 | .filter(|entry| entry.metadata().is_ok_and(|md| md.is_file())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/index.rs:49:37 [INFO] [stdout] | [INFO] [stdout] 49 | .flat_map(|entry| match Note::from_path(entry.path()) { [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/index.rs:136:77 [INFO] [stdout] | [INFO] [stdout] 136 | .ok_or_else(|| error::RucolaError::NotifyEventError(event.clone()))?.to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/file_manager.rs:268:25 [INFO] [stdout] | [INFO] [stdout] 268 | .or_else(|| open::commands(path).pop()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/file_tracker.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 43 | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let watcher = notify::recommended_watcher(move |res| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | vault_path, [INFO] [stdout] 53 | | file_types: types_builder.build()?, [INFO] [stdout] 54 | | watcher, [INFO] [stdout] 55 | | file_change_channel: receiver, [INFO] [stdout] 56 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/html_builder.rs:267:25 [INFO] [stdout] | [INFO] [stdout] 267 | .or_else(|| open::commands(&path).pop()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/screen/display_screen.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 58 | index: data::NoteIndexContainer, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | let index_b = index.borrow(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 105 | | links: [l1blinks, l1links, l2blinks, l2links], [INFO] [stdout] 106 | | note, [INFO] [stdout] 107 | | index, [INFO] [stdout] ... | [INFO] [stdout] 114 | | mode: DisplayMode::Display, [INFO] [stdout] 115 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rucola-notes` (bin "rucola") due to 19 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:115:15 [INFO] [stdout] | [INFO] [stdout] 115 | match app.update(maybe_keypress) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:99:13 [INFO] [stdout] | [INFO] [stdout] 36 | mut loading_screen_callback: F, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let mut errors = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let tracker = match io::FileTracker::new(&config, vault_path.clone()) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Ok(tracker) => tracker, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let (index, index_errors) = data::NoteIndex::new(tracker, builder.clone()); [INFO] [stdout] | ----- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let index = std::rc::Rc::new(std::cell::RefCell::new(index)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | / Self { [INFO] [stdout] 100 | | select: ui::screen::SelectScreen::new( [INFO] [stdout] 101 | | index.clone(), [INFO] [stdout] 102 | | manager.clone(), [INFO] [stdout] ... | [INFO] [stdout] 112 | | builder, [INFO] [stdout] 113 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:198:12 [INFO] [stdout] | [INFO] [stdout] 140 | let mut index = self.index.borrow_mut(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | let msg = if let Some(display) = &mut self.display { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let msg = msg?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | Ok(msg.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:99:36 [INFO] [stdout] | [INFO] [stdout] 99 | .and_then(|arg_string| expanduser::expanduser(arg_string).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/note.rs:53:19 [INFO] [stdout] | [INFO] [stdout] 53 | path: path.canonicalize().unwrap_or(path.to_path_buf()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/note.rs:57:41 [INFO] [stdout] | [INFO] [stdout] 57 | .flat_map(|node| match &node.data.borrow().value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/note.rs:69:41 [INFO] [stdout] | [INFO] [stdout] 69 | .flat_map(|node| match &node.data.borrow().value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/note_statistics.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 40 | fn to_row(&self, index: data::NoteIndexContainer, styles: &ui::UiStyles) -> Option { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | // generate the stats row for each element [INFO] [stdout] 42 | index.borrow().get(&self.id).map(|note| { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/note_statistics.rs:165:30 [INFO] [stdout] | [INFO] [stdout] 100 | let index = index.borrow(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | tag_count_total: filtered_index [INFO] [stdout] | ______________________________^ [INFO] [stdout] 166 | | .values() [INFO] [stdout] 167 | | .flat_map(|(_, stats)| &stats.tags) [INFO] [stdout] 168 | | .collect::>() [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/note_statistics.rs:273:50 [INFO] [stdout] | [INFO] [stdout] 273 | .flat_map(|note_env| note_env.to_row(index.clone(), styles)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/index.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 38 | mut tracker: io::FileTracker, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let mut errors = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | / Self { [INFO] [stdout] 80 | | inner, [INFO] [stdout] 81 | | tracker, [INFO] [stdout] 82 | | builder, [INFO] [stdout] 83 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/index.rs:48:29 [INFO] [stdout] | [INFO] [stdout] 48 | .filter(|entry| entry.metadata().is_ok_and(|md| md.is_file())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/index.rs:49:37 [INFO] [stdout] | [INFO] [stdout] 49 | .flat_map(|entry| match Note::from_path(entry.path()) { [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/index.rs:136:77 [INFO] [stdout] | [INFO] [stdout] 136 | .ok_or_else(|| error::RucolaError::NotifyEventError(event.clone()))?.to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/file_manager.rs:268:25 [INFO] [stdout] | [INFO] [stdout] 268 | .or_else(|| open::commands(path).pop()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/file_tracker.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 43 | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let watcher = notify::recommended_watcher(move |res| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | vault_path, [INFO] [stdout] 53 | | file_types: types_builder.build()?, [INFO] [stdout] 54 | | watcher, [INFO] [stdout] 55 | | file_change_channel: receiver, [INFO] [stdout] 56 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/html_builder.rs:267:25 [INFO] [stdout] | [INFO] [stdout] 267 | .or_else(|| open::commands(&path).pop()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/screen/display_screen.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 58 | index: data::NoteIndexContainer, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | let index_b = index.borrow(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 105 | | links: [l1blinks, l1links, l2blinks, l2links], [INFO] [stdout] 106 | | note, [INFO] [stdout] 107 | | index, [INFO] [stdout] ... | [INFO] [stdout] 114 | | mode: DisplayMode::Display, [INFO] [stdout] 115 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rucola-notes` (bin "rucola" test) due to 19 previous errors [INFO] running `Command { std: "docker" "inspect" "9c5032ee9851b98496a0259f8c2922310a60b94581deed36c13d2eab1bd5dbf6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9c5032ee9851b98496a0259f8c2922310a60b94581deed36c13d2eab1bd5dbf6", kill_on_drop: false }` [INFO] [stdout] 9c5032ee9851b98496a0259f8c2922310a60b94581deed36c13d2eab1bd5dbf6