[INFO] fetching crate rubot 0.3.0... [INFO] checking rubot-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rubot 0.3.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate rubot 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rubot 0.3.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate rubot 0.3.0 [INFO] tweaked toml for crates.io crate rubot 0.3.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate rubot 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fc408d21bedbe5ace1d8121304b2439803ac4858dffbf1d94cf807e6ceeb5f74 [INFO] running `Command { std: "docker" "start" "-a" "fc408d21bedbe5ace1d8121304b2439803ac4858dffbf1d94cf807e6ceeb5f74", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fc408d21bedbe5ace1d8121304b2439803ac4858dffbf1d94cf807e6ceeb5f74", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc408d21bedbe5ace1d8121304b2439803ac4858dffbf1d94cf807e6ceeb5f74", kill_on_drop: false }` [INFO] [stdout] fc408d21bedbe5ace1d8121304b2439803ac4858dffbf1d94cf807e6ceeb5f74 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 19f6dd234c73819b375db92d38173db5a30f1e89fea1565737e1b4ed635abbd6 [INFO] running `Command { std: "docker" "start" "-a" "19f6dd234c73819b375db92d38173db5a30f1e89fea1565737e1b4ed635abbd6", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling serde v1.0.114 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling rayon-core v1.7.1 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.5 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Compiling syn v1.0.33 [INFO] [stderr] Compiling serde_json v1.0.56 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling rayon v1.3.1 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling serde_derive v1.0.114 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking half v1.6.0 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Compiling shakmaty v0.16.3 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking btoi v0.4.2 [INFO] [stderr] Checking plotters v0.2.15 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking criterion-plot v0.4.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking arrayvec v0.5.1 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking tapir v1.0.1 [INFO] [stderr] Checking oorandom v11.1.2 [INFO] [stderr] Checking rubot v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:543:24 [INFO] [stdout] | [INFO] [stdout] 541 | pub fn new(condition: T) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 542 | Self { [INFO] [stdout] 543 | condition: condition.into_run_condition(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alpha_beta/mod.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn select(&mut self, state: &T, condition: U) -> Option { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | self.inner_select(state, condition) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alpha_beta/mod.rs:72:28 [INFO] [stdout] | [INFO] [stdout] 72 | .map(|mut act| act.path.pop().unwrap()) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alpha_beta/mod.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 101 | condition: U, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | ) -> Option> { [INFO] [stdout] 103 | self.inner_select(state, condition) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alpha_beta/mod.rs:315:19 [INFO] [stdout] | [INFO] [stdout] 311 | fn new(state: &T, player: T::Player, unfinished: Vec>) -> Ctxt { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 315 | best: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alpha_beta/mod.rs:317:25 [INFO] [stdout] | [INFO] [stdout] 311 | fn new(state: &T, player: T::Player, unfinished: Vec>) -> Ctxt { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 317 | terminated: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alpha_beta/mod.rs:318:28 [INFO] [stdout] | [INFO] [stdout] 311 | fn new(state: &T, player: T::Player, unfinished: Vec>) -> Ctxt { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | losing_action: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alpha_beta/mod.rs:319:35 [INFO] [stdout] | [INFO] [stdout] 311 | fn new(state: &T, player: T::Player, unfinished: Vec>) -> Ctxt { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 319 | partially_terminated: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alpha_beta/mod.rs:320:25 [INFO] [stdout] | [INFO] [stdout] 311 | fn new(state: &T, player: T::Player, unfinished: Vec>) -> Ctxt { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 320 | path_cache: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alpha_beta/mod.rs:451:40 [INFO] [stdout] | [INFO] [stdout] 451 | .unwrap_or_else(|| self.losing_action.take().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alpha_beta/mod.rs:471:15 [INFO] [stdout] | [INFO] [stdout] 462 | mut action: Action, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 465 | on_cancel: impl FnOnce(&mut Self, Action) -> Action, [INFO] [stdout] | --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 466 | ) -> Option> { [INFO] [stdout] 467 | let mut updated_state = self.state.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 471 | match self.minimax_with_path( [INFO] [stdout] | _______________^ [INFO] [stdout] 472 | | rest.iter().cloned().rev(), [INFO] [stdout] 473 | | updated_state, [INFO] [stdout] 474 | | depth, [INFO] [stdout] ... | [INFO] [stdout] 480 | | condition, [INFO] [stdout] 481 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alpha_beta/mod.rs:646:12 [INFO] [stdout] | [INFO] [stdout] 584 | mut path: impl Iterator, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 585 | game_state: T, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 595 | let action = if let Some(action) = path.next() { [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 605 | let (active, mut game_states) = self.generate_game_states(&game_state); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 606 | [INFO] [stdout] 607 | let mut state = State::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 646 | Ok(state.consume()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/alpha_beta/mod.rs:703:12 [INFO] [stdout] | [INFO] [stdout] 651 | game_state: T, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 680 | let (active, game_states) = self.generate_game_states(&game_state); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 686 | let mut state = State::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 703 | Ok(state.consume()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rubot` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "19f6dd234c73819b375db92d38173db5a30f1e89fea1565737e1b4ed635abbd6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19f6dd234c73819b375db92d38173db5a30f1e89fea1565737e1b4ed635abbd6", kill_on_drop: false }` [INFO] [stdout] 19f6dd234c73819b375db92d38173db5a30f1e89fea1565737e1b4ed635abbd6