[INFO] fetching crate rubo 0.1.6... [INFO] checking rubo-0.1.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rubo 0.1.6 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate rubo 0.1.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rubo 0.1.6 [INFO] finished tweaking crates.io crate rubo 0.1.6 [INFO] tweaked toml for crates.io crate rubo 0.1.6 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate rubo 0.1.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c00bf4d9d0766ad310f0ae3229860f89ddb90756dc87aac547b0c3d85b876228 [INFO] running `Command { std: "docker" "start" "-a" "c00bf4d9d0766ad310f0ae3229860f89ddb90756dc87aac547b0c3d85b876228", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c00bf4d9d0766ad310f0ae3229860f89ddb90756dc87aac547b0c3d85b876228", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c00bf4d9d0766ad310f0ae3229860f89ddb90756dc87aac547b0c3d85b876228", kill_on_drop: false }` [INFO] [stdout] c00bf4d9d0766ad310f0ae3229860f89ddb90756dc87aac547b0c3d85b876228 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a57335b3583f4cd966f7ed860db68d14250f9cc2ea53279072c2d91314e1d277 [INFO] running `Command { std: "docker" "start" "-a" "a57335b3583f4cd966f7ed860db68d14250f9cc2ea53279072c2d91314e1d277", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.124 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Compiling anyhow v1.0.57 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking bytesize v1.1.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking clap_lex v0.1.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v3.1.12 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking globset v0.4.8 [INFO] [stderr] Checking ignore v0.4.18 [INFO] [stderr] Checking rubo v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: found module declaration for lib.rs [INFO] [stdout] --> src/main.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | mod lib; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: lib.rs is the root of this crate's library target [INFO] [stdout] = help: to refer to it from other targets, use the library's name as the path [INFO] [stdout] = note: `#[warn(special_module_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found module declaration for lib.rs [INFO] [stdout] --> src/main.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | mod lib; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: lib.rs is the root of this crate's library target [INFO] [stdout] = help: to refer to it from other targets, use the library's name as the path [INFO] [stdout] = note: `#[warn(special_module_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib/pod/lockfile.rs:111:21 [INFO] [stdout] | [INFO] [stdout] 111 | let mut item = result.get_mut(&pod_name).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib/pod/lockfile.rs:111:21 [INFO] [stdout] | [INFO] [stdout] 111 | let mut item = result.get_mut(&pod_name).unwrap(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Command` is never constructed [INFO] [stdout] --> src/cmd/cd.rs:3:19 [INFO] [stdout] | [INFO] [stdout] 3 | pub(super) struct Command; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `NAME` is never used [INFO] [stdout] --> src/cmd/cd.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 5 | impl Command { [INFO] [stdout] | ------------ associated constant in this implementation [INFO] [stdout] 6 | const NAME: &'static str = "cd"; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Command` is never constructed [INFO] [stdout] --> src/cmd/sed.rs:3:19 [INFO] [stdout] | [INFO] [stdout] 3 | pub(super) struct Command; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `NAME` is never used [INFO] [stdout] --> src/cmd/sed.rs:8:7 [INFO] [stdout] | [INFO] [stdout] 8 | const NAME: &'static str = "sed"; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Command` is never constructed [INFO] [stdout] --> src/cmd/count.rs:12:19 [INFO] [stdout] | [INFO] [stdout] 12 | pub(super) struct Command; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `NAME` is never used [INFO] [stdout] --> src/cmd/count.rs:15:11 [INFO] [stdout] | [INFO] [stdout] 14 | impl Command { [INFO] [stdout] | ------------ associated constant in this implementation [INFO] [stdout] 15 | const NAME: &'static str = "count"; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/tree/mod.rs:146:27 [INFO] [stdout] | [INFO] [stdout] 146 | .and_then(|_| std::fs::read_link(entry.path()).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Command` is never constructed [INFO] [stdout] --> src/cmd/cd.rs:3:19 [INFO] [stdout] | [INFO] [stdout] 3 | pub(super) struct Command; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `NAME` is never used [INFO] [stdout] --> src/cmd/cd.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 5 | impl Command { [INFO] [stdout] | ------------ associated constant in this implementation [INFO] [stdout] 6 | const NAME: &'static str = "cd"; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Command` is never constructed [INFO] [stdout] --> src/cmd/sed.rs:3:19 [INFO] [stdout] | [INFO] [stdout] 3 | pub(super) struct Command; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `NAME` is never used [INFO] [stdout] --> src/cmd/sed.rs:8:7 [INFO] [stdout] | [INFO] [stdout] 8 | const NAME: &'static str = "sed"; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Command` is never constructed [INFO] [stdout] --> src/cmd/count.rs:12:19 [INFO] [stdout] | [INFO] [stdout] 12 | pub(super) struct Command; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `NAME` is never used [INFO] [stdout] --> src/cmd/count.rs:15:11 [INFO] [stdout] | [INFO] [stdout] 14 | impl Command { [INFO] [stdout] | ------------ associated constant in this implementation [INFO] [stdout] 15 | const NAME: &'static str = "count"; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/tree/mod.rs:146:27 [INFO] [stdout] | [INFO] [stdout] 146 | .and_then(|_| std::fs::read_link(entry.path()).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rubo` (bin "rubo" test) due to 2 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rubo` (bin "rubo") due to 2 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a57335b3583f4cd966f7ed860db68d14250f9cc2ea53279072c2d91314e1d277", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a57335b3583f4cd966f7ed860db68d14250f9cc2ea53279072c2d91314e1d277", kill_on_drop: false }` [INFO] [stdout] a57335b3583f4cd966f7ed860db68d14250f9cc2ea53279072c2d91314e1d277