[INFO] fetching crate rual 0.0.2... [INFO] checking rual-0.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rual 0.0.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate rual 0.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rual 0.0.2 [INFO] finished tweaking crates.io crate rual 0.0.2 [INFO] tweaked toml for crates.io crate rual 0.0.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1dc4c71a36812ba2ec9bb0e8b6c7ef0e4faadf019ead4ae5b1fe8b959846d17b [INFO] running `Command { std: "docker" "start" "-a" "1dc4c71a36812ba2ec9bb0e8b6c7ef0e4faadf019ead4ae5b1fe8b959846d17b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1dc4c71a36812ba2ec9bb0e8b6c7ef0e4faadf019ead4ae5b1fe8b959846d17b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1dc4c71a36812ba2ec9bb0e8b6c7ef0e4faadf019ead4ae5b1fe8b959846d17b", kill_on_drop: false }` [INFO] [stdout] 1dc4c71a36812ba2ec9bb0e8b6c7ef0e4faadf019ead4ae5b1fe8b959846d17b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 80c78a594aa367c58fb2253d425d3f3276286302aabe102fab2900d0533ccc31 [INFO] running `Command { std: "docker" "start" "-a" "80c78a594aa367c58fb2253d425d3f3276286302aabe102fab2900d0533ccc31", kill_on_drop: false }` [INFO] [stderr] Checking rual v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Punct` [INFO] [stdout] --> src/lexing/mod.rs:3:30 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::syntax::{Keyword, Punct, Token, TokenType}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `parent` is never read [INFO] [stdout] --> src/execution/mod.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 131 | struct Scope<'t> { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 132 | parent: Option<&'t Scope<'t>>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/execution/mod.rs:137:12 [INFO] [stdout] | [INFO] [stdout] 136 | impl<'t> Scope<'t> { [INFO] [stdout] | ------------------ associated function in this implementation [INFO] [stdout] 137 | pub fn new(parent: &'t Scope) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/execution/mod.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | self.exec_expr(&expr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 58 | let _ = self.exec_expr(&expr); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing/mod.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 90 | let val = if let Some(expr) = self.parse()? { [INFO] [stdout] | --- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(Some(Expr::Declaration { name, val })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing/mod.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 102 | let mut q = Vec::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | Ok(Some(flatten!(rpn of q))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing/mod.rs:144:39 [INFO] [stdout] | [INFO] [stdout] 144 | s.iter().for_each(|&p| q.push(Expr::Op(p))); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing/mod.rs:172:12 [INFO] [stdout] | [INFO] [stdout] 162 | let from = Box::new(self.parse()?.unwrap()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | let to = Box::new(self.parse()?.unwrap()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | Ok(Some(Expr::Range { from, to })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing/mod.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / if $exprs.len() == 1 { [INFO] [stdout] 22 | | $exprs.pop().unwrap() [INFO] [stdout] 23 | | } else { [INFO] [stdout] 24 | | $ctor($exprs) [INFO] [stdout] 25 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] ... [INFO] [stdout] 176 | let mut exprs = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | Ok(flatten!(multiple exprs)) [INFO] [stdout] | ------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `flatten` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rual` (lib) due to 6 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `parent` is never read [INFO] [stdout] --> src/execution/mod.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 131 | struct Scope<'t> { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 132 | parent: Option<&'t Scope<'t>>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/execution/mod.rs:137:12 [INFO] [stdout] | [INFO] [stdout] 136 | impl<'t> Scope<'t> { [INFO] [stdout] | ------------------ associated function in this implementation [INFO] [stdout] 137 | pub fn new(parent: &'t Scope) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/execution/mod.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | self.exec_expr(&expr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 58 | let _ = self.exec_expr(&expr); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing/mod.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 90 | let val = if let Some(expr) = self.parse()? { [INFO] [stdout] | --- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(Some(Expr::Declaration { name, val })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing/mod.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 102 | let mut q = Vec::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | Ok(Some(flatten!(rpn of q))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing/mod.rs:144:39 [INFO] [stdout] | [INFO] [stdout] 144 | s.iter().for_each(|&p| q.push(Expr::Op(p))); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing/mod.rs:172:12 [INFO] [stdout] | [INFO] [stdout] 162 | let from = Box::new(self.parse()?.unwrap()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | let to = Box::new(self.parse()?.unwrap()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | Ok(Some(Expr::Range { from, to })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing/mod.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / if $exprs.len() == 1 { [INFO] [stdout] 22 | | $exprs.pop().unwrap() [INFO] [stdout] 23 | | } else { [INFO] [stdout] 24 | | $ctor($exprs) [INFO] [stdout] 25 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] ... [INFO] [stdout] 176 | let mut exprs = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | Ok(flatten!(multiple exprs)) [INFO] [stdout] | ------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `flatten` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rual` (lib test) due to 6 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "80c78a594aa367c58fb2253d425d3f3276286302aabe102fab2900d0533ccc31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80c78a594aa367c58fb2253d425d3f3276286302aabe102fab2900d0533ccc31", kill_on_drop: false }` [INFO] [stdout] 80c78a594aa367c58fb2253d425d3f3276286302aabe102fab2900d0533ccc31