[INFO] fetching crate rtlola-frontend 0.7.0... [INFO] checking rtlola-frontend-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rtlola-frontend 0.7.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate rtlola-frontend 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rtlola-frontend 0.7.0 [INFO] finished tweaking crates.io crate rtlola-frontend 0.7.0 [INFO] tweaked toml for crates.io crate rtlola-frontend 0.7.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 66 packages to latest compatible versions [INFO] [stderr] Adding fixedbitset v0.2.0 (latest: v0.5.7) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding num v0.3.1 (latest: v0.4.3) [INFO] [stderr] Adding num-bigint v0.3.3 (latest: v0.4.6) [INFO] [stderr] Adding num-complex v0.3.1 (latest: v0.4.6) [INFO] [stderr] Adding num-rational v0.3.2 (latest: v0.4.2) [INFO] [stderr] Adding petgraph v0.5.1 (latest: v0.6.5) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding uom v0.31.1 (latest: v0.36.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 57190c8ea4c672d239906b97c6c052f829187e3e960e8b50926def5a9e6ad854 [INFO] running `Command { std: "docker" "start" "-a" "57190c8ea4c672d239906b97c6c052f829187e3e960e8b50926def5a9e6ad854", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "57190c8ea4c672d239906b97c6c052f829187e3e960e8b50926def5a9e6ad854", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "57190c8ea4c672d239906b97c6c052f829187e3e960e8b50926def5a9e6ad854", kill_on_drop: false }` [INFO] [stdout] 57190c8ea4c672d239906b97c6c052f829187e3e960e8b50926def5a9e6ad854 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 44451f1f37776efea4fcb095299656f206d09976030e3cb38501fcac4631efce [INFO] running `Command { std: "docker" "start" "-a" "44451f1f37776efea4fcb095299656f206d09976030e3cb38501fcac4631efce", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling num-bigint v0.3.3 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking fixedbitset v0.2.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling rtlola-macros v0.1.2 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking rusttyc v0.5.0 [INFO] [stderr] Checking dot v0.1.4 [INFO] [stderr] Checking pest v2.7.11 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking petgraph v0.5.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.3.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking uom v0.31.1 [INFO] [stderr] Checking num v0.3.1 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking rtlola-reporting v0.3.0 [INFO] [stderr] Checking rtlola-parser v0.3.2 [INFO] [stderr] Checking rtlola-hir v0.5.0 [INFO] [stderr] Checking rtlola-frontend v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/lowering.rs:743:14 [INFO] [stdout] | [INFO] [stdout] 743 | &mir::PacingType::Event(mir::ActivationCondition::Stream(mir_a.reference)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | unused_qualifications [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 743 - &mir::PacingType::Event(mir::ActivationCondition::Stream(mir_a.reference)) [INFO] [stdout] 743 + &PacingType::Event(mir::ActivationCondition::Stream(mir_a.reference)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/lowering.rs:780:13 [INFO] [stdout] | [INFO] [stdout] 780 | mir::PacingType::GlobalPeriodic(UOM_Frequency::new::(Rational::from_u8(1).unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 780 - mir::PacingType::GlobalPeriodic(UOM_Frequency::new::(Rational::from_u8(1).unwrap())) [INFO] [stdout] 780 + PacingType::GlobalPeriodic(UOM_Frequency::new::(Rational::from_u8(1).unwrap())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 59 | let hir = parse_to_final_hir(config)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Ok(Mir::from_hir(hir)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:73:8 [INFO] [stdout] | [INFO] [stdout] 72 | let hir = parse_to_final_hir(config)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Ok(FeatureSelector::new(hir)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lowering.rs:402:19 [INFO] [stdout] | [INFO] [stdout] 400 | let ty = Self::lower_value_type(&hir.expr_type(expr.id()).value_ty); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 401 | mir::Expression { [INFO] [stdout] 402 | kind: Self::lower_expression_kind(hir, sr_map, &expr.kind, &ty), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lowering.rs:632:9 [INFO] [stdout] | [INFO] [stdout] 631 | let params = hir.output(sr).expect("is output stream").params(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 632 | / params [INFO] [stdout] 633 | | .map(|parameter| { [INFO] [stdout] 634 | | mir::Parameter { [INFO] [stdout] 635 | | name: parameter.name.clone(), [INFO] [stdout] ... | [INFO] [stdout] 638 | | } [INFO] [stdout] 639 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mir/dependency_graph.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 51 | let mut res_writer = BufWriter::new(res); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | dot::render(self, &mut res_writer).unwrap(); [INFO] [stdout] 53 | String::from_utf8(res_writer.into_inner().unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rtlola-frontend` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 59 | let hir = parse_to_final_hir(config)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Ok(Mir::from_hir(hir)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:73:8 [INFO] [stdout] | [INFO] [stdout] 72 | let hir = parse_to_final_hir(config)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Ok(FeatureSelector::new(hir)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lowering.rs:402:19 [INFO] [stdout] | [INFO] [stdout] 400 | let ty = Self::lower_value_type(&hir.expr_type(expr.id()).value_ty); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 401 | mir::Expression { [INFO] [stdout] 402 | kind: Self::lower_expression_kind(hir, sr_map, &expr.kind, &ty), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lowering.rs:632:9 [INFO] [stdout] | [INFO] [stdout] 631 | let params = hir.output(sr).expect("is output stream").params(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 632 | / params [INFO] [stdout] 633 | | .map(|parameter| { [INFO] [stdout] 634 | | mir::Parameter { [INFO] [stdout] 635 | | name: parameter.name.clone(), [INFO] [stdout] ... | [INFO] [stdout] 638 | | } [INFO] [stdout] 639 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lowering.rs:661:10 [INFO] [stdout] | [INFO] [stdout] 657 | let ast = ParserConfig::for_string(spec.into()) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 660 | let hir = rtlola_hir::fully_analyzed(ast).expect("Invalid AST:"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 661 | (hir.clone(), Mir::from_hir(hir)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lowering.rs:661:23 [INFO] [stdout] | [INFO] [stdout] 657 | let ast = ParserConfig::for_string(spec.into()) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 660 | let hir = rtlola_hir::fully_analyzed(ast).expect("Invalid AST:"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 661 | (hir.clone(), Mir::from_hir(hir)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mir/dependency_graph.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 51 | let mut res_writer = BufWriter::new(res); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | dot::render(self, &mut res_writer).unwrap(); [INFO] [stdout] 53 | String::from_utf8(res_writer.into_inner().unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rtlola-frontend` (lib test) due to 8 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "44451f1f37776efea4fcb095299656f206d09976030e3cb38501fcac4631efce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "44451f1f37776efea4fcb095299656f206d09976030e3cb38501fcac4631efce", kill_on_drop: false }` [INFO] [stdout] 44451f1f37776efea4fcb095299656f206d09976030e3cb38501fcac4631efce