[INFO] fetching crate rtest 0.2.1... [INFO] checking rtest-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rtest 0.2.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate rtest 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rtest 0.2.1 [INFO] removed 2 missing examples [INFO] finished tweaking crates.io crate rtest 0.2.1 [INFO] tweaked toml for crates.io crate rtest 0.2.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate rtest 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bf63f3d0df9c394241ae0463c6f1fcf521cbd7a637fe2ff3d9300f559aec1240 [INFO] running `Command { std: "docker" "start" "-a" "bf63f3d0df9c394241ae0463c6f1fcf521cbd7a637fe2ff3d9300f559aec1240", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bf63f3d0df9c394241ae0463c6f1fcf521cbd7a637fe2ff3d9300f559aec1240", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf63f3d0df9c394241ae0463c6f1fcf521cbd7a637fe2ff3d9300f559aec1240", kill_on_drop: false }` [INFO] [stdout] bf63f3d0df9c394241ae0463c6f1fcf521cbd7a637fe2ff3d9300f559aec1240 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dba9f46c5a24e86f9f998db2499baf0ebddc8c97f696e14c86fd41dc6974925d [INFO] running `Command { std: "docker" "start" "-a" "dba9f46c5a24e86f9f998db2499baf0ebddc8c97f696e14c86fd41dc6974925d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.80 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Checking pin-project-lite v0.2.12 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling rustversion v1.0.15 [INFO] [stderr] Compiling rustix v0.38.7 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking linux-raw-sys v0.4.5 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking gimli v0.27.3 [INFO] [stderr] Compiling thiserror v1.0.44 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking tracing-log v0.1.3 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking object v0.31.1 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking rustls-pki-types v1.5.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking anymap v1.0.0-beta.2 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Compiling axum v0.7.4 [INFO] [stderr] Checking colored v2.0.4 [INFO] [stderr] Compiling cc v1.0.82 [INFO] [stderr] Compiling syn v2.0.59 [INFO] [stderr] Checking clap_builder v4.3.21 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking regex-automata v0.3.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling backtrace v0.3.68 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking addr2line v0.20.0 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking regex v1.9.1 [INFO] [stderr] Compiling darling_core v0.20.8 [INFO] [stderr] Compiling tracing-attributes v0.1.26 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Compiling thiserror-impl v1.0.44 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Compiling darling_macro v0.20.8 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking clap v4.3.21 [INFO] [stderr] Compiling darling v0.20.8 [INFO] [stderr] Compiling rtest-util v0.2.0 [INFO] [stderr] Checking tracing-subscriber v0.3.17 [INFO] [stderr] Compiling rtest-derive v0.2.0 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.4.4 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking rtest v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods `cost` and `name` are never used [INFO] [stdout] --> src/algos/dependency/mod.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 17 | pub trait Process { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 23 | fn cost(&self) -> u64; [INFO] [stdout] | ^^^^ [INFO] [stdout] 24 | fn id(&self) -> ProcessId; [INFO] [stdout] 25 | fn name(&self) -> &str { "" } [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `name` is never used [INFO] [stdout] --> src/algos/dependency/mod.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 30 | pub trait Resource { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] 31 | fn id(&self) -> ResourceId; [INFO] [stdout] 32 | fn name(&self) -> &str { "" } [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algos/dependency/backtrack.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 45 | let empty_hashset = HashSet::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | / possibles [INFO] [stdout] 115 | | .iter() [INFO] [stdout] 116 | | .map(|(p, meta, _)| create_step(*p, meta, &BacktrackReason::Unspecified)) [INFO] [stdout] 117 | | .collect(), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algos/dependency/backtrack.rs:38:26 [INFO] [stdout] | [INFO] [stdout] 38 | algorithm_data: BacktrackingInfo { [INFO] [stdout] | __________________________^ [INFO] [stdout] 39 | | failed_steps: HashSet::new(), [INFO] [stdout] 40 | | reason: reason.clone(), [INFO] [stdout] 41 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algos/dependency/builder.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 29 | let mut result = HashSet::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | result.drain().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/persistence.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 38 | let file = std::fs::File::open(location)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let result_map = ExecutionResultMap::with_records(file_content.executions); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok((result_map, repo_info, args)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/mod.rs:52:81 [INFO] [stdout] | [INFO] [stdout] 52 | let executable_function = CURRENT_EXECUTABLE_FUNCTION.with(move |b| b.borrow_mut().take()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/mod.rs:111:35 [INFO] [stdout] | [INFO] [stdout] 111 | .and_then(|mutex| mutex.into_inner().ok().map(|wrtier| wrtier.into_inner().freeze())); [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner/mod.rs:111:72 [INFO] [stdout] | [INFO] [stdout] 111 | .and_then(|mutex| mutex.into_inner().ok().map(|wrtier| wrtier.into_inner().freeze())); [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rtest` (lib) due to 8 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "dba9f46c5a24e86f9f998db2499baf0ebddc8c97f696e14c86fd41dc6974925d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dba9f46c5a24e86f9f998db2499baf0ebddc8c97f696e14c86fd41dc6974925d", kill_on_drop: false }` [INFO] [stdout] dba9f46c5a24e86f9f998db2499baf0ebddc8c97f696e14c86fd41dc6974925d