[INFO] fetching crate rterm 0.0.9... [INFO] checking rterm-0.0.9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rterm 0.0.9 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate rterm 0.0.9 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rterm 0.0.9 [INFO] finished tweaking crates.io crate rterm 0.0.9 [INFO] tweaked toml for crates.io crate rterm 0.0.9 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate rterm 0.0.9 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e654871e621485d58f648cca7863ad95a45ba0d22338ff2b99308b4b2125d902 [INFO] running `Command { std: "docker" "start" "-a" "e654871e621485d58f648cca7863ad95a45ba0d22338ff2b99308b4b2125d902", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e654871e621485d58f648cca7863ad95a45ba0d22338ff2b99308b4b2125d902", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e654871e621485d58f648cca7863ad95a45ba0d22338ff2b99308b4b2125d902", kill_on_drop: false }` [INFO] [stdout] e654871e621485d58f648cca7863ad95a45ba0d22338ff2b99308b4b2125d902 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 089879e1372b039ff33a861a06fe8b612cf75ba73bc9d5fa736e16c2de288c91 [INFO] running `Command { std: "docker" "start" "-a" "089879e1372b039ff33a861a06fe8b612cf75ba73bc9d5fa736e16c2de288c91", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.0.98 [INFO] [stderr] Compiling proc-macro2 v1.0.84 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling servo-fontconfig-sys v5.1.0 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling x11 v2.21.0 [INFO] [stderr] Compiling rterm v0.0.9 (/opt/rustwide/workdir) [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling freetype-sys v0.13.1 [INFO] [stderr] Compiling expat-sys v2.1.6 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.1 [INFO] [stderr] Checking vte v0.13.0 [INFO] [stderr] Checking servo-fontconfig v0.5.1 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:13:14 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn limit(x: T, min: T, max: T) -> T { [INFO] [stdout] | ---- ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | cmp::min(cmp::max(x, min), max) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/win.rs:214:12 [INFO] [stdout] | [INFO] [stdout] 212 | let ime = Ime::new(dpy, win); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | [INFO] [stdout] 214 | Ok(Win { [INFO] [stdout] | ____________^ [INFO] [stdout] 215 | | visible: true, [INFO] [stdout] 216 | | mode: WinMode::empty(), [INFO] [stdout] ... | [INFO] [stdout] 248 | | ime, [INFO] [stdout] 249 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/x11_wrapper.rs:133:5 [INFO] [stdout] | [INFO] [stdout] 128 | fn cast(v: V) -> T [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | v.try_into().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 62 | let log = match log { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(App { [INFO] [stdout] | ____________^ [INFO] [stdout] 75 | | win: Win::new(term.cols, term.rows, xoff, yoff, font)?, [INFO] [stdout] 76 | | pty: Pty::new(term.cols, term.rows)?, [INFO] [stdout] 77 | | vte: Vte::new(), [INFO] [stdout] 78 | | term, [INFO] [stdout] 79 | | log, [INFO] [stdout] 80 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rterm` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:13:14 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn limit(x: T, min: T, max: T) -> T { [INFO] [stdout] | ---- ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | cmp::min(cmp::max(x, min), max) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/win.rs:214:12 [INFO] [stdout] | [INFO] [stdout] 212 | let ime = Ime::new(dpy, win); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | [INFO] [stdout] 214 | Ok(Win { [INFO] [stdout] | ____________^ [INFO] [stdout] 215 | | visible: true, [INFO] [stdout] 216 | | mode: WinMode::empty(), [INFO] [stdout] ... | [INFO] [stdout] 248 | | ime, [INFO] [stdout] 249 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/x11_wrapper.rs:133:5 [INFO] [stdout] | [INFO] [stdout] 128 | fn cast(v: V) -> T [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | v.try_into().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 62 | let log = match log { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(App { [INFO] [stdout] | ____________^ [INFO] [stdout] 75 | | win: Win::new(term.cols, term.rows, xoff, yoff, font)?, [INFO] [stdout] 76 | | pty: Pty::new(term.cols, term.rows)?, [INFO] [stdout] 77 | | vte: Vte::new(), [INFO] [stdout] 78 | | term, [INFO] [stdout] 79 | | log, [INFO] [stdout] 80 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rterm` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "089879e1372b039ff33a861a06fe8b612cf75ba73bc9d5fa736e16c2de288c91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "089879e1372b039ff33a861a06fe8b612cf75ba73bc9d5fa736e16c2de288c91", kill_on_drop: false }` [INFO] [stdout] 089879e1372b039ff33a861a06fe8b612cf75ba73bc9d5fa736e16c2de288c91