[INFO] fetching crate rsyn 0.0.1... [INFO] checking rsyn-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rsyn 0.0.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate rsyn 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rsyn 0.0.1 [INFO] finished tweaking crates.io crate rsyn 0.0.1 [INFO] tweaked toml for crates.io crate rsyn 0.0.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate rsyn 0.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 583450ddcfc1e3fa4c4ea44c9e45f91a4ba7060dd9fc60c83106d81912191ea2 [INFO] running `Command { std: "docker" "start" "-a" "583450ddcfc1e3fa4c4ea44c9e45f91a4ba7060dd9fc60c83106d81912191ea2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "583450ddcfc1e3fa4c4ea44c9e45f91a4ba7060dd9fc60c83106d81912191ea2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "583450ddcfc1e3fa4c4ea44c9e45f91a4ba7060dd9fc60c83106d81912191ea2", kill_on_drop: false }` [INFO] [stdout] 583450ddcfc1e3fa4c4ea44c9e45f91a4ba7060dd9fc60c83106d81912191ea2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 32c4865f9c1871e28060cd82a7515cc77b3f3a77fa08d129edaa1d9f1e762b37 [INFO] running `Command { std: "docker" "start" "-a" "32c4865f9c1871e28060cd82a7515cc77b3f3a77fa08d129edaa1d9f1e762b37", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.70 [INFO] [stderr] Compiling proc-macro2 v1.0.12 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling syn v1.0.21 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling anyhow v1.0.30 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking unix_mode v0.1.1 [INFO] [stderr] Checking shell-words v1.0.0 [INFO] [stderr] Checking hex v0.4.2 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.2 [INFO] [stderr] Compiling proc-macro-error v1.0.2 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking fern v0.6.0 [INFO] [stderr] Compiling quote v1.0.5 [INFO] [stderr] Checking term_size v0.3.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking regex v1.3.7 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling structopt-derive v0.4.7 [INFO] [stderr] Checking structopt v0.3.14 [INFO] [stderr] Checking rsyn v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: lint `intra_doc_link_resolution_failure` has been removed: use `rustdoc::broken_intra_doc_links` instead [INFO] [stdout] --> src/lib.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | #![warn(intra_doc_link_resolution_failure)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `intra_doc_link_resolution_failure` has been removed: use `rustdoc::broken_intra_doc_links` instead [INFO] [stdout] --> src/lib.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | #![warn(intra_doc_link_resolution_failure)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 61 | r: Box, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | w: Box, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | child: Child, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let mut wv = WriteVarint::new(w); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let mut rv = ReadVarint::new(r); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | let rv = ReadVarint::new(Box::new(DemuxRead::new(rv.take()))); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | [INFO] [stdout] 93 | Ok(Connection { [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | rv, [INFO] [stdout] 95 | | wv, [INFO] [stdout] 96 | | protocol_version, [INFO] [stdout] ... | [INFO] [stdout] 99 | | options, [INFO] [stdout] 100 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/varint.rs:77:15 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn check_for_eof(mut self) -> Result<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | match self.read_u8().and(Ok(())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rsyn` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/client.rs:498:17 [INFO] [stdout] | [INFO] [stdout] 498 | let mut options = client.mut_options(); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 61 | r: Box, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | w: Box, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | child: Child, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let mut wv = WriteVarint::new(w); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let mut rv = ReadVarint::new(r); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | let rv = ReadVarint::new(Box::new(DemuxRead::new(rv.take()))); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | [INFO] [stdout] 93 | Ok(Connection { [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | rv, [INFO] [stdout] 95 | | wv, [INFO] [stdout] 96 | | protocol_version, [INFO] [stdout] ... | [INFO] [stdout] 99 | | options, [INFO] [stdout] 100 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/varint.rs:77:15 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn check_for_eof(mut self) -> Result<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | match self.read_u8().and(Ok(())) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rsyn` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "32c4865f9c1871e28060cd82a7515cc77b3f3a77fa08d129edaa1d9f1e762b37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32c4865f9c1871e28060cd82a7515cc77b3f3a77fa08d129edaa1d9f1e762b37", kill_on_drop: false }` [INFO] [stdout] 32c4865f9c1871e28060cd82a7515cc77b3f3a77fa08d129edaa1d9f1e762b37