[INFO] fetching crate rstorage 1.0.2... [INFO] checking rstorage-1.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rstorage 1.0.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate rstorage 1.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rstorage 1.0.2 [INFO] finished tweaking crates.io crate rstorage 1.0.2 [INFO] tweaked toml for crates.io crate rstorage 1.0.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 61 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding advisory-lock v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding dashmap v5.5.3 (latest: v6.0.1) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9ca236eeb4f63af1779c54246233d95f5d2502bf8732c69eaed92e8e401b2c98 [INFO] running `Command { std: "docker" "start" "-a" "9ca236eeb4f63af1779c54246233d95f5d2502bf8732c69eaed92e8e401b2c98", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9ca236eeb4f63af1779c54246233d95f5d2502bf8732c69eaed92e8e401b2c98", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ca236eeb4f63af1779c54246233d95f5d2502bf8732c69eaed92e8e401b2c98", kill_on_drop: false }` [INFO] [stdout] 9ca236eeb4f63af1779c54246233d95f5d2502bf8732c69eaed92e8e401b2c98 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7de0fe8aa749ca1a2420bfe8fb26bc5e54849da93e8fd3cbc8bd2c34059f474f [INFO] running `Command { std: "docker" "start" "-a" "7de0fe8aa749ca1a2420bfe8fb26bc5e54849da93e8fd3cbc8bd2c34059f474f", kill_on_drop: false }` [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking advisory-lock v0.2.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking simple_wal v0.3.0 [INFO] [stderr] Checking rstorage v1.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `RQuery` [INFO] [stdout] --> src/storage.rs:9:50 [INFO] [stdout] | [INFO] [stdout] 9 | pub use rstorage::rstorage::{RConcurrentStorage, RQuery}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `RQuery` [INFO] [stdout] --> src/storage.rs:9:50 [INFO] [stdout] | [INFO] [stdout] 9 | pub use rstorage::rstorage::{RConcurrentStorage, RQuery}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `WQuery` [INFO] [stdout] --> src/storage.rs:10:50 [INFO] [stdout] | [INFO] [stdout] 10 | pub use wstorage::wstorage::{WConcurrentStorage, WQuery}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `WQuery` [INFO] [stdout] --> src/storage.rs:10:50 [INFO] [stdout] | [INFO] [stdout] 10 | pub use wstorage::wstorage::{WConcurrentStorage, WQuery}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `current_segment_index` is never read [INFO] [stdout] --> src/storage/disk_log.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 14 | struct TmpLogStruct { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 17 | current_segment_index: usize [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/storage/disk_log.rs:39:16 [INFO] [stdout] | [INFO] [stdout] 39 | LogErr(LogError), [INFO] [stdout] | ------ ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 39 | LogErr(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/storage/disk_log.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 40 | IoError(Error), [INFO] [stdout] | ------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 40 | IoError(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `current_segment_index` is never read [INFO] [stdout] --> src/storage/disk_log.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 14 | struct TmpLogStruct { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 17 | current_segment_index: usize [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/storage/disk_log.rs:39:16 [INFO] [stdout] | [INFO] [stdout] 39 | LogErr(LogError), [INFO] [stdout] | ------ ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 39 | LogErr(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/storage/disk_log.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 40 | IoError(Error), [INFO] [stdout] | ------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 40 | IoError(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/disk_log.rs:130:16 [INFO] [stdout] | [INFO] [stdout] 126 | let mut slog = open_last_segment(path, table_name, total_segment_size); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | Ok(Context{ [INFO] [stdout] | ________________^ [INFO] [stdout] 131 | | log: slog.log, [INFO] [stdout] 132 | | [INFO] [stdout] 133 | | path: slog.path, [INFO] [stdout] ... | [INFO] [stdout] 140 | | current_segment_index: 1 [INFO] [stdout] 141 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/disk_log.rs:130:16 [INFO] [stdout] | [INFO] [stdout] 126 | let mut slog = open_last_segment(path, table_name, total_segment_size); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | Ok(Context{ [INFO] [stdout] | ________________^ [INFO] [stdout] 131 | | log: slog.log, [INFO] [stdout] 132 | | [INFO] [stdout] 133 | | path: slog.path, [INFO] [stdout] ... | [INFO] [stdout] 140 | | current_segment_index: 1 [INFO] [stdout] 141 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rstorage` (lib) due to 2 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rstorage` (lib test) due to 2 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7de0fe8aa749ca1a2420bfe8fb26bc5e54849da93e8fd3cbc8bd2c34059f474f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7de0fe8aa749ca1a2420bfe8fb26bc5e54849da93e8fd3cbc8bd2c34059f474f", kill_on_drop: false }` [INFO] [stdout] 7de0fe8aa749ca1a2420bfe8fb26bc5e54849da93e8fd3cbc8bd2c34059f474f