[INFO] fetching crate rstest_test 0.13.0... [INFO] checking rstest_test-0.13.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rstest_test 0.13.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate rstest_test 0.13.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rstest_test 0.13.0 [INFO] finished tweaking crates.io crate rstest_test 0.13.0 [INFO] tweaked toml for crates.io crate rstest_test 0.13.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] [stderr] Adding rstest v0.19.0 (latest: v0.22.0) [INFO] [stderr] Adding rstest_macros v0.19.0 (latest: v0.22.0) [INFO] [stderr] Adding toml_edit v0.21.0 (latest: v0.22.20) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 909910fdcf910241de68579b657883e1e018c774bb5238a2baa146cfae81fe26 [INFO] running `Command { std: "docker" "start" "-a" "909910fdcf910241de68579b657883e1e018c774bb5238a2baa146cfae81fe26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "909910fdcf910241de68579b657883e1e018c774bb5238a2baa146cfae81fe26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "909910fdcf910241de68579b657883e1e018c774bb5238a2baa146cfae81fe26", kill_on_drop: false }` [INFO] [stdout] 909910fdcf910241de68579b657883e1e018c774bb5238a2baa146cfae81fe26 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4cd1c653c64bf57690e8f3211f1f88876e70360a4be86eb3807c83acc76e8bc4 [INFO] running `Command { std: "docker" "start" "-a" "4cd1c653c64bf57690e8f3211f1f88876e70360a4be86eb3807c83acc76e8bc4", kill_on_drop: false }` [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking temp_testdir v0.2.3 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling rstest_macros v0.19.0 [INFO] [stderr] Checking toml_edit v0.21.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking rstest_test v0.13.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prj.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn new>(root: P) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | / Self { [INFO] [stdout] 59 | | root: root.as_ref().to_owned(), [INFO] [stdout] 60 | | name: "project".into(), [INFO] [stdout] 61 | | channel: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 64 | | default_timeout: Default::default(), [INFO] [stdout] 65 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prj.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn subproject>(&self, name: O) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let _guard = self.ws.write().expect("Cannot lock workspace resource"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | self.workspace_add(name.as_ref().to_str().unwrap()); [INFO] [stdout] 81 | / Self { [INFO] [stdout] 82 | | root: self.path(), [INFO] [stdout] 83 | | name: name.as_ref().to_owned(), [INFO] [stdout] 84 | | channel: self.channel.clone(), [INFO] [stdout] ... | [INFO] [stdout] 87 | | default_timeout: Default::default(), [INFO] [stdout] 88 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prj.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 124 | let _guard = self.ws.read().expect("Cannot lock workspace resource"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | Command::new("cargo") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prj.rs:133:15 [INFO] [stdout] | [INFO] [stdout] 132 | fn create(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | match Command::new("cargo") [INFO] [stdout] | _______________^ [INFO] [stdout] 134 | | .current_dir(&self.root) [INFO] [stdout] 135 | | .arg("init") [INFO] [stdout] 136 | | .args(vec!["--edition", "2018"]) [INFO] [stdout] ... | [INFO] [stdout] 141 | | .unwrap() [INFO] [stdout] 142 | | .wait() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prj.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 156 | fn has_test_global_attribute(&self, path: impl AsRef) -> bool { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | read_to_string(&path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prj.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn append_code>(&self, code: S) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | / std::fs::OpenOptions::new() [INFO] [stdout] 177 | | .append(true) [INFO] [stdout] 178 | | .open(self.code_path()) [INFO] [stdout] 179 | | .unwrap() [INFO] [stdout] 180 | | .write_all(code.as_ref().as_ref()) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:249:21 [INFO] [stdout] | [INFO] [stdout] 248 | pub fn ok_with(self, name: S, exactly: bool, occurence: usize) -> Self { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | self.append(TestResult::ok(name, exactly, occurence)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:253:21 [INFO] [stdout] | [INFO] [stdout] 252 | pub fn fail_with(self, name: S, exactly: bool, occurence: usize) -> Self { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | self.append(TestResult::fail(name, exactly, occurence)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rstest_test` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "4cd1c653c64bf57690e8f3211f1f88876e70360a4be86eb3807c83acc76e8bc4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4cd1c653c64bf57690e8f3211f1f88876e70360a4be86eb3807c83acc76e8bc4", kill_on_drop: false }` [INFO] [stdout] 4cd1c653c64bf57690e8f3211f1f88876e70360a4be86eb3807c83acc76e8bc4