[INFO] fetching crate rspotify-model 0.13.3... [INFO] checking rspotify-model-0.13.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rspotify-model 0.13.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate rspotify-model 0.13.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rspotify-model 0.13.3 [INFO] finished tweaking crates.io crate rspotify-model 0.13.3 [INFO] tweaked toml for crates.io crate rspotify-model 0.13.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 49 packages to latest compatible versions [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 811f5ed51d88e6c28389790a6051996a37bdc99a9559509afa58e4b0f0f5411e [INFO] running `Command { std: "docker" "start" "-a" "811f5ed51d88e6c28389790a6051996a37bdc99a9559509afa58e4b0f0f5411e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "811f5ed51d88e6c28389790a6051996a37bdc99a9559509afa58e4b0f0f5411e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "811f5ed51d88e6c28389790a6051996a37bdc99a9559509afa58e4b0f0f5411e", kill_on_drop: false }` [INFO] [stdout] 811f5ed51d88e6c28389790a6051996a37bdc99a9559509afa58e4b0f0f5411e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 19a0fd4194fd1bc47ed4f94b375ed79c7355c084f94e5d1ee29291e45998ab38 [INFO] running `Command { std: "docker" "start" "-a" "19a0fd4194fd1bc47ed4f94b375ed79c7355c084f94e5d1ee29291e45998ab38", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking rspotify-model v0.13.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:79:24 [INFO] [stdout] | [INFO] [stdout] 69 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | disallows: orignal_actions [INFO] [stdout] | ________________________^ [INFO] [stdout] 80 | | .disallows [INFO] [stdout] 81 | | .into_iter() [INFO] [stdout] 82 | | .filter(|(_, value)| *value) [INFO] [stdout] 83 | | .map(|(key, _)| key) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/custom_serde.rs:169:47 [INFO] [stdout] | [INFO] [stdout] 164 | pub fn deserialize<'de, D>(d: D) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | Duration::try_seconds(duration).ok_or(serde::de::Error::invalid_value( [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 170 | | serde::de::Unexpected::Signed(duration), [INFO] [stdout] 171 | | &"an invalid duration in seconds", [INFO] [stdout] 172 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/custom_serde.rs:193:12 [INFO] [stdout] | [INFO] [stdout] 188 | pub fn deserialize<'de, D>(d: D) -> Result, D::Error> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | Ok(scopes.split_whitespace().map(ToOwned::to_owned).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/playlist.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 23 | fn deserialize_null_default<'de, D, T>(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Ok(Option::deserialize(deserializer)?.unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rspotify-model` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:79:24 [INFO] [stdout] | [INFO] [stdout] 69 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | disallows: orignal_actions [INFO] [stdout] | ________________________^ [INFO] [stdout] 80 | | .disallows [INFO] [stdout] 81 | | .into_iter() [INFO] [stdout] 82 | | .filter(|(_, value)| *value) [INFO] [stdout] 83 | | .map(|(key, _)| key) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/custom_serde.rs:169:47 [INFO] [stdout] | [INFO] [stdout] 164 | pub fn deserialize<'de, D>(d: D) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | Duration::try_seconds(duration).ok_or(serde::de::Error::invalid_value( [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 170 | | serde::de::Unexpected::Signed(duration), [INFO] [stdout] 171 | | &"an invalid duration in seconds", [INFO] [stdout] 172 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/custom_serde.rs:193:12 [INFO] [stdout] | [INFO] [stdout] 188 | pub fn deserialize<'de, D>(d: D) -> Result, D::Error> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | Ok(scopes.split_whitespace().map(ToOwned::to_owned).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/playlist.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 23 | fn deserialize_null_default<'de, D, T>(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Ok(Option::deserialize(deserializer)?.unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rspotify-model` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "19a0fd4194fd1bc47ed4f94b375ed79c7355c084f94e5d1ee29291e45998ab38", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19a0fd4194fd1bc47ed4f94b375ed79c7355c084f94e5d1ee29291e45998ab38", kill_on_drop: false }` [INFO] [stdout] 19a0fd4194fd1bc47ed4f94b375ed79c7355c084f94e5d1ee29291e45998ab38