[INFO] fetching crate rspack_style 0.1.16... [INFO] checking rspack_style-0.1.16 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rspack_style 0.1.16 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate rspack_style 0.1.16 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rspack_style 0.1.16 [INFO] finished tweaking crates.io crate rspack_style 0.1.16 [INFO] tweaked toml for crates.io crate rspack_style 0.1.16 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate rspack_style 0.1.16 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3f0a7b68beb95c8316ad9b0dd251fa3fae18b7249aa8a35e6329fd3302379091 [INFO] running `Command { std: "docker" "start" "-a" "3f0a7b68beb95c8316ad9b0dd251fa3fae18b7249aa8a35e6329fd3302379091", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3f0a7b68beb95c8316ad9b0dd251fa3fae18b7249aa8a35e6329fd3302379091", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3f0a7b68beb95c8316ad9b0dd251fa3fae18b7249aa8a35e6329fd3302379091", kill_on_drop: false }` [INFO] [stdout] 3f0a7b68beb95c8316ad9b0dd251fa3fae18b7249aa8a35e6329fd3302379091 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 64cc67bf4e9155e49e135b2b43172f79936112188174d240de4fceb2d3d4d35d [INFO] running `Command { std: "docker" "start" "-a" "64cc67bf4e9155e49e135b2b43172f79936112188174d240de4fceb2d3d4d35d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.95 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling semver v1.0.9 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling serde_json v1.0.81 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.8 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Compiling rustversion v1.0.6 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling unicode-segmentation v1.9.0 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking plotters-backend v0.3.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking regex-syntax v0.6.26 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking plotters-svg v0.3.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking mio v0.8.3 [INFO] [stderr] Checking plotters v0.3.1 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking fasteval v0.2.4 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking criterion-plot v0.4.4 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling strum_macros v0.23.1 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking tokio v1.18.2 [INFO] [stderr] Checking strum v0.23.0 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking uuid v1.1.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking smol_str v0.1.23 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking rspack_style v0.1.16 (/opt/rustwide/workdir) [INFO] [stderr] Checking criterion v0.3.5 [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/token/lib.rs:1:18 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct Token(String); [INFO] [stdout] | ----- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/css/comment.rs:107:38 [INFO] [stdout] | [INFO] [stdout] 107 | if let StyleNode::Comment(cc) = x.deref().clone() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `css::node::StyleNode` does not implement `Deref`, so calling `deref` on `&css::node::StyleNode` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 107 - if let StyleNode::Comment(cc) = x.deref().clone() { [INFO] [stdout] 107 + if let StyleNode::Comment(cc) = x.clone() { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `css::node::StyleNode`, implement `Clone` for it [INFO] [stdout] --> src/css/node.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 + #[derive(Clone)] [INFO] [stdout] 18 | pub enum StyleNode { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/css/parse.rs:46:33 [INFO] [stdout] | [INFO] [stdout] 46 | .map(|x| FileNode { info: x.clone() }) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/css/parse.rs:300:8 [INFO] [stdout] | [INFO] [stdout] 95 | context: ParseContext, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | parent: NodeWeakRef, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | fileinfo: FileWeakRef, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let mut rule_node_list: Vec = vec![]; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let mut var_node_list: Vec = vec![]; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let option = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | let sync_context = context.lock().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | Ok((comment_list, var_node_list, rule_node_list)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/css/select_node.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 32 | parent: NodeWeakRef, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | fileinfo: FileWeakRef, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let obj = NewSelector::new(charlist, start_loc, map, parent, fileinfo); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | Ok(SelectorNode::Select(obj)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/css/select_node.rs:122:21 [INFO] [stdout] | [INFO] [stdout] 122 | .map(|file| file.upgrade().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/css/style_rule.rs:240:8 [INFO] [stdout] | [INFO] [stdout] 234 | let node = ValueNode::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | Ok((node, self.charlist.len() - 1)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/less/codegen.rs:27:60 [INFO] [stdout] | [INFO] [stdout] 27 | if let StyleNode::Var(VarRuleNode::Var(var)) = item.deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `less::node::StyleNode` does not implement `Deref`, so calling `deref` on `&less::node::StyleNode` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 27 - if let StyleNode::Var(VarRuleNode::Var(var)) = item.deref() { [INFO] [stdout] 27 + if let StyleNode::Var(VarRuleNode::Var(var)) = item { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `less::node::StyleNode`, implement `Clone` for it [INFO] [stdout] --> src/less/node.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 + #[derive(Clone)] [INFO] [stdout] 19 | pub enum StyleNode { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/less/codegen.rs:47:60 [INFO] [stdout] | [INFO] [stdout] 47 | if let StyleNode::Var(VarRuleNode::Var(var)) = item.deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `less::node::StyleNode` does not implement `Deref`, so calling `deref` on `&less::node::StyleNode` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 47 - if let StyleNode::Var(VarRuleNode::Var(var)) = item.deref() { [INFO] [stdout] 47 + if let StyleNode::Var(VarRuleNode::Var(var)) = item { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `less::node::StyleNode`, implement `Clone` for it [INFO] [stdout] --> src/less/node.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 + #[derive(Clone)] [INFO] [stdout] 19 | pub enum StyleNode { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/less/comment.rs:107:38 [INFO] [stdout] | [INFO] [stdout] 107 | if let StyleNode::Comment(cc) = x.deref().clone() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `less::node::StyleNode` does not implement `Deref`, so calling `deref` on `&less::node::StyleNode` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 107 - if let StyleNode::Comment(cc) = x.deref().clone() { [INFO] [stdout] 107 + if let StyleNode::Comment(cc) = x.clone() { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `less::node::StyleNode`, implement `Clone` for it [INFO] [stdout] --> src/less/node.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 + #[derive(Clone)] [INFO] [stdout] 19 | pub enum StyleNode { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/less/parse.rs:298:8 [INFO] [stdout] | [INFO] [stdout] 93 | context: ParseContext, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | parent: NodeWeakRef, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | fileinfo: FileWeakRef, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let mut rule_node_list: Vec = vec![]; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let mut var_node_list: Vec = vec![]; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | let option = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | let sync_context = context.lock().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 298 | Ok((comment_list, var_node_list, rule_node_list)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/less/select.rs:926:60 [INFO] [stdout] | [INFO] [stdout] 926 | if let StyleNode::Var(VarRuleNode::Var(var)) = item.deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `less::node::StyleNode` does not implement `Deref`, so calling `deref` on `&less::node::StyleNode` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 926 - if let StyleNode::Var(VarRuleNode::Var(var)) = item.deref() { [INFO] [stdout] 926 + if let StyleNode::Var(VarRuleNode::Var(var)) = item { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `less::node::StyleNode`, implement `Clone` for it [INFO] [stdout] --> src/less/node.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 + #[derive(Clone)] [INFO] [stdout] 19 | pub enum StyleNode { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/less/select.rs:946:60 [INFO] [stdout] | [INFO] [stdout] 946 | if let StyleNode::Var(VarRuleNode::Var(var)) = item.deref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `less::node::StyleNode` does not implement `Deref`, so calling `deref` on `&less::node::StyleNode` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 946 - if let StyleNode::Var(VarRuleNode::Var(var)) = item.deref() { [INFO] [stdout] 946 + if let StyleNode::Var(VarRuleNode::Var(var)) = item { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `less::node::StyleNode`, implement `Clone` for it [INFO] [stdout] --> src/less/node.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 + #[derive(Clone)] [INFO] [stdout] 19 | pub enum StyleNode { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/less/select_node.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 32 | parent: NodeWeakRef, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | fileinfo: FileWeakRef, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let obj = NewSelector::new(charlist, start_loc, map, parent, fileinfo); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | Ok(SelectorNode::Select(obj)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/less/select_node.rs:122:21 [INFO] [stdout] | [INFO] [stdout] 122 | .map(|file| file.upgrade().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/less/style_rule.rs:240:8 [INFO] [stdout] | [INFO] [stdout] 234 | let node = ValueNode::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | Ok((node, self.charlist.len() - 1)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/less/var_node.rs:244:8 [INFO] [stdout] | [INFO] [stdout] 238 | let node = ValueNode::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | Ok((node, self.charlist.len() - 1)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/style_core/applicationn.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(option: ParseOption, application_fold: Option) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let context = Context::new(option, application_fold)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Ok(Application { context }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/style_core/context.rs:211:8 [INFO] [stdout] | [INFO] [stdout] 200 | let filecache = self.filecache.lock().unwrap(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/token/ident.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 64 | let mut base_unit: Option = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(Self::Number(final_value.to_string().into(), base_unit)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rspack_style` (lib) due to 14 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "64cc67bf4e9155e49e135b2b43172f79936112188174d240de4fceb2d3d4d35d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64cc67bf4e9155e49e135b2b43172f79936112188174d240de4fceb2d3d4d35d", kill_on_drop: false }` [INFO] [stdout] 64cc67bf4e9155e49e135b2b43172f79936112188174d240de4fceb2d3d4d35d