[INFO] fetching crate rspack_napi 0.1.0... [INFO] checking rspack_napi-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rspack_napi 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate rspack_napi 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rspack_napi 0.1.0 [INFO] finished tweaking crates.io crate rspack_napi 0.1.0 [INFO] tweaked toml for crates.io crate rspack_napi 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 182 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding dashmap v5.5.3 (latest: v6.0.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding miette v5.10.0 (latest: v7.2.0) [INFO] [stderr] Adding miette-derive v5.10.0 (latest: v7.2.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding owo-colors v3.5.0 (latest: v4.0.0) [INFO] [stderr] Adding ptr_meta v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding ptr_meta_derive v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding supports-color v2.1.0 (latest: v3.0.0) [INFO] [stderr] Adding supports-hyperlinks v2.1.0 (latest: v3.0.0) [INFO] [stderr] Adding supports-unicode v2.1.0 (latest: v3.0.0) [INFO] [stderr] Adding swc_common v0.36.3 (latest: v0.37.5) [INFO] [stderr] Adding swc_core v0.99.6 (latest: v0.102.2) [INFO] [stderr] Adding swc_ecma_ast v0.117.4 (latest: v0.118.2) [INFO] [stderr] Adding swc_ecma_parser v0.148.3 (latest: v0.149.1) [INFO] [stderr] Adding swc_ecma_transforms_base v0.143.3 (latest: v0.145.0) [INFO] [stderr] Adding swc_ecma_utils v0.133.4 (latest: v0.134.2) [INFO] [stderr] Adding swc_ecma_visit v0.103.3 (latest: v0.104.8) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding terminal_size v0.1.17 (latest: v0.3.0) [INFO] [stderr] Adding textwrap v0.15.2 (latest: v0.16.1) [INFO] [stderr] Adding vergen v8.3.2 (latest: v9.0.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0c5e1607e538930054bb07546e5b718d9db75c5f85af851ac0bc603957a7dcce [INFO] running `Command { std: "docker" "start" "-a" "0c5e1607e538930054bb07546e5b718d9db75c5f85af851ac0bc603957a7dcce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0c5e1607e538930054bb07546e5b718d9db75c5f85af851ac0bc603957a7dcce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c5e1607e538930054bb07546e5b718d9db75c5f85af851ac0bc603957a7dcce", kill_on_drop: false }` [INFO] [stdout] 0c5e1607e538930054bb07546e5b718d9db75c5f85af851ac0bc603957a7dcce [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aebf59179d321d910c1f4b240103444f4b53b559b8a686220283c28b07cef8e8 [INFO] running `Command { std: "docker" "start" "-a" "aebf59179d321d910c1f4b240103444f4b53b559b8a686220283c28b07cef8e8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking better_scoped_tls v0.1.1 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking swc_visit v0.6.2 [INFO] [stderr] Compiling Inflector v0.11.4 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling camino v1.1.9 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Compiling psm v0.1.22 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Checking unicode-id-start v1.2.0 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling stacker v0.1.17 [INFO] [stderr] Compiling smartstring v1.0.1 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling vergen v8.3.2 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking typed-arena v2.0.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking ryu-js v1.0.1 [INFO] [stderr] Checking unicode-id v0.3.4 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking supports-hyperlinks v2.1.0 [INFO] [stderr] Checking supports-unicode v2.1.0 [INFO] [stderr] Checking supports-color v2.1.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking regress v0.10.0 [INFO] [stderr] Checking napi-sys v2.4.0 [INFO] [stderr] Checking oneshot v0.1.8 [INFO] [stderr] Checking textwrap v0.15.2 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling ptr_meta_derive v0.1.4 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking ptr_meta v0.1.4 [INFO] [stderr] Compiling swc_macros_common v0.3.13 [INFO] [stderr] Checking backtrace-ext v0.2.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling from_variant v0.1.9 [INFO] [stderr] Compiling swc_eq_ignore_macros v0.1.4 [INFO] [stderr] Compiling ast_node v0.9.9 [INFO] [stderr] Compiling is-macro v0.3.6 [INFO] [stderr] Compiling string_enum v0.4.4 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling miette-derive v5.10.0 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling ctor v0.2.8 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking miette v5.10.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking triomphe v0.1.13 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking ustr-fxhash v1.0.0 [INFO] [stderr] Checking rspack_collections v0.1.0 [INFO] [stderr] Checking hstr v0.2.12 [INFO] [stderr] Checking swc_allocator v0.1.8 [INFO] [stderr] Compiling cargo-platform v0.1.8 [INFO] [stderr] Checking swc_atoms v0.6.7 [INFO] [stderr] Checking napi-h v2.16.1 [INFO] [stderr] Compiling cargo_metadata v0.18.1 [INFO] [stderr] Checking swc_common v0.36.3 [INFO] [stderr] Compiling swc_core v0.99.6 [INFO] [stderr] Checking swc_ecma_ast v0.117.4 [INFO] [stderr] Checking swc_ecma_visit v0.103.3 [INFO] [stderr] Checking swc_ecma_parser v0.148.3 [INFO] [stderr] Checking swc_ecma_utils v0.133.4 [INFO] [stderr] Checking swc_ecma_transforms_base v0.143.3 [INFO] [stderr] Checking rspack_error v0.1.0 [INFO] [stderr] Checking rspack_regex v0.1.0 [INFO] [stderr] Checking rspack_napi v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/js_values/js_value_ref.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(env: Env, value: T) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | let ref_ = env.create_reference(value)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | [INFO] [stdout] 15 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 16 | | ref_, [INFO] [stdout] 17 | | _phantom: PhantomData, [INFO] [stdout] 18 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/js_values/js_value_ref.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 31 | unsafe fn to_napi_value(env: sys::napi_env, val: Self) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | / val [INFO] [stdout] 33 | | .get(Env::from(env)) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadsafe_function.rs:56:8 [INFO] [stdout] | [INFO] [stdout] 50 | let inner = unsafe { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 57 | | inner, [INFO] [stdout] 58 | | env, [INFO] [stdout] 59 | | resolver: unsafe { JsCallback::new(env) }?, [INFO] [stdout] 60 | | _data: PhantomData, [INFO] [stdout] 61 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadsafe_function.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 99 | fn blocking_call(&self, value: T) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | let rx = self.call_with_return(value); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | rx.recv().expect("failed to receive tsfn value") [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadsafe_js_value_ref.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 15 | fn new(env: Env, js_ref: JsValueRef) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 17 | | value_ref: Arc::new(Mutex::new(js_ref)), [INFO] [stdout] 18 | | drop_handle: unsafe { JsCallback::new(env.raw()) }?, [INFO] [stdout] 19 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadsafe_js_value_ref.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 25 | let value_ref = self.value_ref.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | self.drop_handle.call(Box::new(move |env| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 27 | | let _ = value_ref [INFO] [stdout] 28 | | .lock() [INFO] [stdout] 29 | | .expect("should lock `value_ref`") [INFO] [stdout] 30 | | .unref(env); [INFO] [stdout] 31 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadsafe_js_value_ref.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 59 | unsafe fn to_napi_value(env: sys::napi_env, val: Self) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | / val [INFO] [stdout] 61 | | .get(Env::from(env)) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadsafe_js_value_ref.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn new(env: Env, value: T) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let js_ref = JsValueRef::new(env, value)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | [INFO] [stdout] 70 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 71 | | inner: Arc::new(ThreadsafeJsValueRefHandle::new(env, js_ref)?), [INFO] [stdout] 72 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/js_values/js_value_ref.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(env: Env, value: T) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | let ref_ = env.create_reference(value)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | [INFO] [stdout] 15 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 16 | | ref_, [INFO] [stdout] 17 | | _phantom: PhantomData, [INFO] [stdout] 18 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/js_values/js_value_ref.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 31 | unsafe fn to_napi_value(env: sys::napi_env, val: Self) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | / val [INFO] [stdout] 33 | | .get(Env::from(env)) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadsafe_function.rs:56:8 [INFO] [stdout] | [INFO] [stdout] 50 | let inner = unsafe { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 57 | | inner, [INFO] [stdout] 58 | | env, [INFO] [stdout] 59 | | resolver: unsafe { JsCallback::new(env) }?, [INFO] [stdout] 60 | | _data: PhantomData, [INFO] [stdout] 61 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadsafe_function.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 99 | fn blocking_call(&self, value: T) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | let rx = self.call_with_return(value); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | rx.recv().expect("failed to receive tsfn value") [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadsafe_js_value_ref.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 15 | fn new(env: Env, js_ref: JsValueRef) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 17 | | value_ref: Arc::new(Mutex::new(js_ref)), [INFO] [stdout] 18 | | drop_handle: unsafe { JsCallback::new(env.raw()) }?, [INFO] [stdout] 19 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadsafe_js_value_ref.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 25 | let value_ref = self.value_ref.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | self.drop_handle.call(Box::new(move |env| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 27 | | let _ = value_ref [INFO] [stdout] 28 | | .lock() [INFO] [stdout] 29 | | .expect("should lock `value_ref`") [INFO] [stdout] 30 | | .unref(env); [INFO] [stdout] 31 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadsafe_js_value_ref.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 59 | unsafe fn to_napi_value(env: sys::napi_env, val: Self) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | / val [INFO] [stdout] 61 | | .get(Env::from(env)) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadsafe_js_value_ref.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn new(env: Env, value: T) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let js_ref = JsValueRef::new(env, value)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | [INFO] [stdout] 70 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 71 | | inner: Arc::new(ThreadsafeJsValueRefHandle::new(env, js_ref)?), [INFO] [stdout] 72 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rspack_napi` (lib test) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rspack_napi` (lib) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "aebf59179d321d910c1f4b240103444f4b53b559b8a686220283c28b07cef8e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aebf59179d321d910c1f4b240103444f4b53b559b8a686220283c28b07cef8e8", kill_on_drop: false }` [INFO] [stdout] aebf59179d321d910c1f4b240103444f4b53b559b8a686220283c28b07cef8e8