[INFO] fetching crate rslint_regex 0.3.0... [INFO] checking rslint_regex-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rslint_regex 0.3.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate rslint_regex 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rslint_regex 0.3.0 [INFO] finished tweaking crates.io crate rslint_regex 0.3.0 [INFO] tweaked toml for crates.io crate rslint_regex 0.3.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 95 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hashbrown v0.9.1 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding rowan v0.10.6 (latest: v0.15.16) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding smol_str v0.1.24 (latest: v0.2.2) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7291ca6cd8b6a627367e83489cd9d5aeef4e82e8e42398b0479d0bf1dd6692c2 [INFO] running `Command { std: "docker" "start" "-a" "7291ca6cd8b6a627367e83489cd9d5aeef4e82e8e42398b0479d0bf1dd6692c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7291ca6cd8b6a627367e83489cd9d5aeef4e82e8e42398b0479d0bf1dd6692c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7291ca6cd8b6a627367e83489cd9d5aeef4e82e8e42398b0479d0bf1dd6692c2", kill_on_drop: false }` [INFO] [stdout] 7291ca6cd8b6a627367e83489cd9d5aeef4e82e8e42398b0479d0bf1dd6692c2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f22c49df1749a1b184b112dadc5fb9abff8ca2239d40e9cddd25199c28760963 [INFO] running `Command { std: "docker" "start" "-a" "f22c49df1749a1b184b112dadc5fb9abff8ca2239d40e9cddd25199c28760963", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking rslint_regex v0.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ir.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 118 | pub fn from_string(string: impl AsRef) -> Option { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | / Parser::new_from_pattern_and_flags( [INFO] [stdout] 120 | | string.as_ref(), [INFO] [stdout] 121 | | 0, [INFO] [stdout] 122 | | 0, [INFO] [stdout] ... | [INFO] [stdout] 127 | | .parse() [INFO] [stdout] 128 | | .ok() [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:341:12 [INFO] [stdout] | [INFO] [stdout] 330 | let mut node = self.pattern()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | Ok(ir::Regex { [INFO] [stdout] | ____________^ [INFO] [stdout] 342 | | node, [INFO] [stdout] 343 | | flags: self.flags, [INFO] [stdout] 344 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:440:12 [INFO] [stdout] | [INFO] [stdout] 415 | let node = self.alternative()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 416 | let mut nodes = Vec::with_capacity(3); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 440 | Ok(if nodes.len() == 1 { [INFO] [stdout] | ____________^ [INFO] [stdout] 441 | | nodes.pop().unwrap() [INFO] [stdout] 442 | | } else { [INFO] [stdout] 443 | | Node::Disjunction(self.span(start), nodes) [INFO] [stdout] 444 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:458:12 [INFO] [stdout] | [INFO] [stdout] 450 | let mut terms = Vec::with_capacity(5); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 458 | Ok(if terms.is_empty() { [INFO] [stdout] | ____________^ [INFO] [stdout] 459 | | Node::Empty [INFO] [stdout] 460 | | } else if terms.len() == 1 { [INFO] [stdout] 461 | | terms.pop().unwrap() [INFO] [stdout] 462 | | } else { [INFO] [stdout] 463 | | Node::Alternative(self.span(start), terms) [INFO] [stdout] 464 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:504:15 [INFO] [stdout] | [INFO] [stdout] 502 | fn opt_quantifier(&mut self, node: Node, err: bool) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 503 | let start = self.cur; [INFO] [stdout] 504 | match self.quantifier(node.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:563:12 [INFO] [stdout] | [INFO] [stdout] 527 | fn quantifier(&mut self, node: Node) -> Result> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 563 | Ok(Ok(Node::Quantifier( [INFO] [stdout] | ____________^ [INFO] [stdout] 564 | | self.span(start), [INFO] [stdout] 565 | | Box::new(node), [INFO] [stdout] 566 | | quantifier, [INFO] [stdout] 567 | | self.eat('?'), [INFO] [stdout] 568 | | ))) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:714:12 [INFO] [stdout] | [INFO] [stdout] 707 | let inner = Box::new(self.disjunction()?); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 708 | self.eat_err(')')?; [INFO] [stdout] 709 | let group = ir::Group { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 714 | Ok(Node::Group(self.span(start), group)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:923:12 [INFO] [stdout] | [INFO] [stdout] 871 | let mut members = vec![]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 923 | Ok(Node::CharacterClass( [INFO] [stdout] | ____________^ [INFO] [stdout] 924 | | self.span(start), [INFO] [stdout] 925 | | CharacterClass { negated, members }, [INFO] [stdout] 926 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unicode.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | es2018: [ [INFO] [stdout] | _____________^ [INFO] [stdout] 35 | | "C", [INFO] [stdout] 36 | | "Cased_Letter", [INFO] [stdout] 37 | | "Cc", [INFO] [stdout] ... | [INFO] [stdout] 117 | | .copied() [INFO] [stdout] 118 | | .collect(), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unicode.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | es2019: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unicode.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | es2020: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unicode.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | es2018: [ [INFO] [stdout] | _____________^ [INFO] [stdout] 125 | | "Adlam", [INFO] [stdout] 126 | | "Adlm", [INFO] [stdout] 127 | | "Aghb", [INFO] [stdout] ... | [INFO] [stdout] 405 | | .copied() [INFO] [stdout] 406 | | .collect(), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unicode.rs:408:13 [INFO] [stdout] | [INFO] [stdout] 408 | es2019: [ [INFO] [stdout] | _____________^ [INFO] [stdout] 409 | | "Dogr", [INFO] [stdout] 410 | | "Dogra", [INFO] [stdout] 411 | | "Gong", [INFO] [stdout] ... | [INFO] [stdout] 425 | | .copied() [INFO] [stdout] 426 | | .collect(), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unicode.rs:428:13 [INFO] [stdout] | [INFO] [stdout] 428 | es2020: [ [INFO] [stdout] | _____________^ [INFO] [stdout] 429 | | "Elym", [INFO] [stdout] 430 | | "Elymaic", [INFO] [stdout] 431 | | "Hmnp", [INFO] [stdout] ... | [INFO] [stdout] 439 | | .copied() [INFO] [stdout] 440 | | .collect(), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unicode.rs:443:13 [INFO] [stdout] | [INFO] [stdout] 443 | es2018: [ [INFO] [stdout] | _____________^ [INFO] [stdout] 444 | | "AHex", [INFO] [stdout] 445 | | "ASCII", [INFO] [stdout] 446 | | "ASCII_Hex_Digit", [INFO] [stdout] ... | [INFO] [stdout] 538 | | .copied() [INFO] [stdout] 539 | | .collect(), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unicode.rs:541:13 [INFO] [stdout] | [INFO] [stdout] 541 | es2019: ["Extended_Pictographic"].iter().copied().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unicode.rs:543:13 [INFO] [stdout] | [INFO] [stdout] 543 | es2020: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rslint_regex` (lib) due to 18 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "f22c49df1749a1b184b112dadc5fb9abff8ca2239d40e9cddd25199c28760963", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f22c49df1749a1b184b112dadc5fb9abff8ca2239d40e9cddd25199c28760963", kill_on_drop: false }` [INFO] [stdout] f22c49df1749a1b184b112dadc5fb9abff8ca2239d40e9cddd25199c28760963