[INFO] fetching crate rsbx 2.0.0... [INFO] checking rsbx-2.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rsbx 2.0.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate rsbx 2.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rsbx 2.0.0 [INFO] finished tweaking crates.io crate rsbx 2.0.0 [INFO] tweaked toml for crates.io crate rsbx 2.0.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 107 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.4.12 (latest: v0.7.6) [INFO] [stderr] Adding autocfg v0.1.8 (latest: v1.3.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding block-buffer v0.7.3 (latest: v0.10.4) [INFO] [stderr] Adding block-padding v0.1.5 (latest: v0.3.3) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding constant_time_eq v0.1.5 (latest: v0.3.1) [INFO] [stderr] Adding cty v0.1.5 (latest: v0.2.2) [INFO] [stderr] Adding digest v0.8.1 (latest: v0.10.7) [INFO] [stderr] Adding env_logger v0.5.13 (latest: v0.11.5) [INFO] [stderr] Adding generic-array v0.12.4 (latest: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding nom v4.2.3 (latest: v7.1.3) [INFO] [stderr] Adding opaque-debug v0.2.3 (latest: v0.3.1) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding quickcheck v0.7.2 (latest: v1.0.3) [INFO] [stderr] Adding rand v0.5.6 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.6.5 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.2.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (latest: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding reed-solomon-erasure v3.1.1 (latest: v6.0.0) [INFO] [stderr] Adding sha-1 v0.8.2 (latest: v0.10.1) [INFO] [stderr] Adding sha2 v0.8.2 (latest: v0.10.8) [INFO] [stderr] Adding smallvec v0.6.14 (latest: v1.13.2) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding version_check v0.1.5 (latest: v0.9.5) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0c82345c1b6c4b7f019b393c980824967cb50a7e9bfa693da6dd7ad9ddf11d0c [INFO] running `Command { std: "docker" "start" "-a" "0c82345c1b6c4b7f019b393c980824967cb50a7e9bfa693da6dd7ad9ddf11d0c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0c82345c1b6c4b7f019b393c980824967cb50a7e9bfa693da6dd7ad9ddf11d0c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c82345c1b6c4b7f019b393c980824967cb50a7e9bfa693da6dd7ad9ddf11d0c", kill_on_drop: false }` [INFO] [stdout] 0c82345c1b6c4b7f019b393c980824967cb50a7e9bfa693da6dd7ad9ddf11d0c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0183471d1ae235da016d729dfa371c83cd51411c4904a02edaa00731f49c31ad [INFO] running `Command { std: "docker" "start" "-a" "0183471d1ae235da016d729dfa371c83cd51411c4904a02edaa00731f49c31ad", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking generic-array v0.12.4 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking block-padding v0.1.5 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Compiling nom v4.2.3 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling blake2_c v0.3.3 [INFO] [stderr] Compiling reed-solomon-erasure v3.1.1 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking cty v0.1.5 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Compiling rsbx v2.0.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking sha-1 v0.8.2 [INFO] [stderr] Checking sha2 v0.8.2 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking rand_core v0.2.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking ctrlc v3.4.5 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/file_utils.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | ((size + (block_size - 1)) / block_size) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 74 - ((size + (block_size - 1)) / block_size) [INFO] [stdout] 74 + (size + (block_size - 1)) / block_size [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/file_utils.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | ((size + (data_size - 1)) / data_size) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 85 - ((size + (data_size - 1)) / data_size) [INFO] [stdout] 85 + (size + (data_size - 1)) / data_size [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:3:31 [INFO] [stdout] | [INFO] [stdout] 3 | fn round_down_to_multiple(Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:3:43 [INFO] [stdout] | [INFO] [stdout] 3 | fn round_down_to_multiple(Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:4:31 [INFO] [stdout] | [INFO] [stdout] 4 | fn round_up_to_multiple (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:4:43 [INFO] [stdout] | [INFO] [stdout] 4 | fn round_up_to_multiple (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:5:31 [INFO] [stdout] | [INFO] [stdout] 5 | fn ensure_at_least (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:5:43 [INFO] [stdout] | [INFO] [stdout] 5 | fn ensure_at_least (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:6:31 [INFO] [stdout] | [INFO] [stdout] 6 | fn ensure_at_most (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:6:43 [INFO] [stdout] | [INFO] [stdout] 6 | fn ensure_at_most (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/sbx_block/mod.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | (data_shards as u32 <= index_in_set) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 209 - (data_shards as u32 <= index_in_set) [INFO] [stdout] 209 + data_shards as u32 <= index_in_set [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/log.rs:65:31 [INFO] [stdout] | [INFO] [stdout] 65 | fn deserialize(&mut self, &[u8]) -> Result<(), ()>; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &[u8]` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::repairer::RSRepairStats` [INFO] [stdout] --> src/rs_codec/mod.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub use self::repairer::RSRepairStats; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/misc_macros.rs:345:19 [INFO] [stdout] | [INFO] [stdout] 345 | $($expr;)*; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] ::: src/repair_core.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 210 | / print_if!(verbose => param, reporter => [INFO] [stdout] 211 | | "{}", repair_stats;); [INFO] [stdout] | |______________________________________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] = note: this warning originates in the macro `pause_reporter` which comes from the expansion of the macro `print_if` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/misc_macros.rs:345:19 [INFO] [stdout] | [INFO] [stdout] 345 | $($expr;)*; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] ::: src/repair_core.rs:329:25 [INFO] [stdout] | [INFO] [stdout] 329 | / print_if!(verbose => param, reporter => [INFO] [stdout] 330 | | "Replaced invalid metadata block at {} (0x{:X}) with reference block", p, p;); [INFO] [stdout] | |_______________________________________________________________________________________________________________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `pause_reporter` which comes from the expansion of the macro `print_if` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/misc_macros.rs:345:19 [INFO] [stdout] | [INFO] [stdout] 345 | $($expr;)*; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] ::: src/check_core.rs:207:25 [INFO] [stdout] | [INFO] [stdout] 207 | / print_if!(verbose => param, reporter => [INFO] [stdout] 208 | | "Block failed check, version : {}, block size : {}, at byte {} (0x{:X})", [INFO] [stdout] 209 | | ver_usize, [INFO] [stdout] 210 | | block_size, [INFO] [stdout] 211 | | block_pos, [INFO] [stdout] 212 | | block_pos;); [INFO] [stdout] | |_____________________________________________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `pause_reporter` which comes from the expansion of the macro `print_if` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/misc_macros.rs:345:19 [INFO] [stdout] | [INFO] [stdout] 345 | $($expr;)*; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] ::: src/check_core.rs:226:9 [INFO] [stdout] | [INFO] [stdout] 226 | print_if!(verbose not_json => param, reporter, json_printer => "";); [INFO] [stdout] | ------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `pause_reporter` which comes from the expansion of the macro `print_if` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/sbx_block/mod.rs:743:46 [INFO] [stdout] | [INFO] [stdout] 743 | ... pred : Option<&Fn(&Block) -> bool>) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 743 | pred : Option<&dyn Fn(&Block) -> bool>) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/repair_core.rs:159:45 [INFO] [stdout] | [INFO] [stdout] 159 | ... pred : &Fn(&Block) -> bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 159 | pred : &dyn Fn(&Block) -> bool, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp_opt`: use `DateTime::from_timestamp` instead [INFO] [stdout] --> src/time_utils.rs:36:30 [INFO] [stdout] | [INFO] [stdout] 36 | match NaiveDateTime::from_timestamp_opt(secs, 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking quickcheck v0.7.2 [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/file_utils.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | ((size + (block_size - 1)) / block_size) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 74 - ((size + (block_size - 1)) / block_size) [INFO] [stdout] 74 + (size + (block_size - 1)) / block_size [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/file_utils.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | ((size + (data_size - 1)) / data_size) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 85 - ((size + (data_size - 1)) / data_size) [INFO] [stdout] 85 + (size + (data_size - 1)) / data_size [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/file_utils_tests.rs:484:13 [INFO] [stdout] | [INFO] [stdout] 484 | ({ [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 496 | }) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 484 ~ { [INFO] [stdout] 485 | let version = Version::V17; [INFO] [stdout] ... [INFO] [stdout] 495 | && container_size <= container_size_upper_bound [INFO] [stdout] 496 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:3:31 [INFO] [stdout] | [INFO] [stdout] 3 | fn round_down_to_multiple(Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:3:43 [INFO] [stdout] | [INFO] [stdout] 3 | fn round_down_to_multiple(Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:4:31 [INFO] [stdout] | [INFO] [stdout] 4 | fn round_up_to_multiple (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:4:43 [INFO] [stdout] | [INFO] [stdout] 4 | fn round_up_to_multiple (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:5:31 [INFO] [stdout] | [INFO] [stdout] 5 | fn ensure_at_least (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:5:43 [INFO] [stdout] | [INFO] [stdout] 5 | fn ensure_at_least (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:6:31 [INFO] [stdout] | [INFO] [stdout] 6 | fn ensure_at_most (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/integer_utils.rs:6:43 [INFO] [stdout] | [INFO] [stdout] 6 | fn ensure_at_most (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Item` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/sbx_block/mod.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | (data_shards as u32 <= index_in_set) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 209 - (data_shards as u32 <= index_in_set) [INFO] [stdout] 209 + data_shards as u32 <= index_in_set [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/log.rs:65:31 [INFO] [stdout] | [INFO] [stdout] 65 | fn deserialize(&mut self, &[u8]) -> Result<(), ()>; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &[u8]` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::repairer::RSRepairStats` [INFO] [stdout] --> src/rs_codec/mod.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub use self::repairer::RSRepairStats; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/misc_macros.rs:345:19 [INFO] [stdout] | [INFO] [stdout] 345 | $($expr;)*; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] ::: src/repair_core.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 210 | / print_if!(verbose => param, reporter => [INFO] [stdout] 211 | | "{}", repair_stats;); [INFO] [stdout] | |______________________________________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] = note: this warning originates in the macro `pause_reporter` which comes from the expansion of the macro `print_if` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/misc_macros.rs:345:19 [INFO] [stdout] | [INFO] [stdout] 345 | $($expr;)*; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] ::: src/repair_core.rs:329:25 [INFO] [stdout] | [INFO] [stdout] 329 | / print_if!(verbose => param, reporter => [INFO] [stdout] 330 | | "Replaced invalid metadata block at {} (0x{:X}) with reference block", p, p;); [INFO] [stdout] | |_______________________________________________________________________________________________________________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `pause_reporter` which comes from the expansion of the macro `print_if` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/misc_macros.rs:345:19 [INFO] [stdout] | [INFO] [stdout] 345 | $($expr;)*; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] ::: src/check_core.rs:207:25 [INFO] [stdout] | [INFO] [stdout] 207 | / print_if!(verbose => param, reporter => [INFO] [stdout] 208 | | "Block failed check, version : {}, block size : {}, at byte {} (0x{:X})", [INFO] [stdout] 209 | | ver_usize, [INFO] [stdout] 210 | | block_size, [INFO] [stdout] 211 | | block_pos, [INFO] [stdout] 212 | | block_pos;); [INFO] [stdout] | |_____________________________________________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `pause_reporter` which comes from the expansion of the macro `print_if` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/misc_macros.rs:345:19 [INFO] [stdout] | [INFO] [stdout] 345 | $($expr;)*; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] ::: src/check_core.rs:226:9 [INFO] [stdout] | [INFO] [stdout] 226 | print_if!(verbose not_json => param, reporter, json_printer => "";); [INFO] [stdout] | ------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `pause_reporter` which comes from the expansion of the macro `print_if` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/sbx_block/mod.rs:743:46 [INFO] [stdout] | [INFO] [stdout] 743 | ... pred : Option<&Fn(&Block) -> bool>) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 743 | pred : Option<&dyn Fn(&Block) -> bool>) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `round_up_to_multiple` is never used [INFO] [stdout] --> src/integer_utils.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub trait IntegerUtils { [INFO] [stdout] | ------------ associated function in this trait [INFO] [stdout] ... [INFO] [stdout] 4 | fn round_up_to_multiple (Self::Item, Self::Item) -> Self::Item; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block_utils.rs:197:8 [INFO] [stdout] | [INFO] [stdout] 124 | let stats = Arc::new(Mutex::new(ScanStats::new(file_size))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | [INFO] [stdout] 126 | let reporter = ProgressReporter::new(&stats, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let mut block = Block::dummy(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | [INFO] [stdout] 137 | let mut meta_block = None; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let mut data_block = None; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | [INFO] [stdout] 140 | let mut reader = FileReader::new(in_file, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | Ok(match ref_block_choice { [INFO] [stdout] | ________^ [INFO] [stdout] 198 | | RefBlockChoice::Any => match (meta_block, data_block) { [INFO] [stdout] 199 | | (Some(m), _ ) => Some(m), [INFO] [stdout] 200 | | (_ , Some(d)) => Some(d), [INFO] [stdout] ... | [INFO] [stdout] 224 | | } [INFO] [stdout] 225 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sbx_block/mod.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 184 | let mut block = Block::new(Version::V1, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | block.verify_crc(buffer).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:111:24 [INFO] [stdout] | [INFO] [stdout] 100 | let write_flag = Arc::new(AtomicBool::new(true)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let runner_write_flag = Arc::clone(&write_flag); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | stats : Arc::clone(stats), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rs_codec/encoder.rs:70:24 [INFO] [stdout] | [INFO] [stdout] 65 | let par_buf : SmallVec<[SmallVec<[u8; SBX_LARGEST_BLOCK_SIZE]>; 32]> = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | rs_codec : ReedSolomon::new(data_shards, [INFO] [stdout] | ________________________^ [INFO] [stdout] 71 | | parity_shards).unwrap(), [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | let mut v = SmallVec::with_capacity($len); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rs_codec/repairer.rs:202:30 [INFO] [stdout] | [INFO] [stdout] 195 | let buf : SmallVec<[SmallVec<[u8; SBX_LARGEST_BLOCK_SIZE]>; 32]> = [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | smallvec![smallvec![0; block_size]; data_shards + parity_shards]; [INFO] [stdout] 197 | let buf_present : SmallVec<[bool; 32]> = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | rs_codec : ReedSolomon::new(data_shards, [INFO] [stdout] | ______________________________^ [INFO] [stdout] 203 | | parity_shards).unwrap(), [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | let mut v = SmallVec::with_capacity($len); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rs_codec/repairer.rs:208:30 [INFO] [stdout] | [INFO] [stdout] 195 | let buf : SmallVec<[SmallVec<[u8; SBX_LARGEST_BLOCK_SIZE]>; 32]> = [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | smallvec![smallvec![0; block_size]; data_shards + parity_shards]; [INFO] [stdout] 197 | let buf_present : SmallVec<[bool; 32]> = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | ref_block : ref_block.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | let mut v = SmallVec::with_capacity($len); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rs_codec/repairer.rs:210:30 [INFO] [stdout] | [INFO] [stdout] 195 | let buf : SmallVec<[SmallVec<[u8; SBX_LARGEST_BLOCK_SIZE]>; 32]> = [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | smallvec![smallvec![0; block_size]; data_shards + parity_shards]; [INFO] [stdout] 197 | let buf_present : SmallVec<[bool; 32]> = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | json_printer : Arc::clone(json_printer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | let mut v = SmallVec::with_capacity($len); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rs_codec/repairer.rs:343:10 [INFO] [stdout] | [INFO] [stdout] 286 | let mut repaired_blocks = [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | (RSRepairStats { version : self.version, [INFO] [stdout] | __________^ [INFO] [stdout] 344 | | data_par_burst : self.data_par_burst, [INFO] [stdout] 345 | | successful, [INFO] [stdout] 346 | | json_printer : Arc::clone(&self.json_printer), [INFO] [stdout] ... | [INFO] [stdout] 349 | | missing_count : self.missing_count(), [INFO] [stdout] 350 | | present_count : self.present_count(), }, [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode_core.rs:831:8 [INFO] [stdout] | [INFO] [stdout] 505 | let mut reader = FileReader::new(¶m.in_file, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 509 | let mut writer = match param.out_file { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 517 | let stats : Arc>; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 518 | [INFO] [stdout] 519 | let reporter : ProgressReporter; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 520 | [INFO] [stdout] 521 | let mut hash_bytes = None; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 522 | [INFO] [stdout] 523 | let mut block = Block::dummy(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 528 | let recorded_hash = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 829 | let res = stats.lock().unwrap().clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 830 | [INFO] [stdout] 831 | Ok((res, hash_bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode_core.rs:891:8 [INFO] [stdout] | [INFO] [stdout] 838 | let hash_bytes : Option = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 854 | let mut reader = match param.out_file { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 863 | let stats = Arc::new(Mutex::new(HashStats::new(file_size))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 864 | [INFO] [stdout] 865 | let reporter = ProgressReporter::new(&stats, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 891 | Ok(Some(hash_ctx.finish_into_hash_bytes())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode_core.rs:976:8 [INFO] [stdout] | [INFO] [stdout] 896 | let ctrlc_stop_flag = setup_ctrlc_handler(param.json_printer.json_enabled()); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 900 | let (ref_block_pos, ref_block) = get_ref_block!(param, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 956 | let param = Param::new(param.ref_block_choice, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 964 | let (mut stats, hash_res) = decode(¶m, [INFO] [stdout] | ----- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 976 | Ok(Some(stats)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/misc_macros.rs:18:29 [INFO] [stdout] | [INFO] [stdout] 18 | let (ref_block_pos, ref_block) = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Some(x) => x, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repair_core.rs:403:8 [INFO] [stdout] | [INFO] [stdout] 227 | let ctrlc_stop_flag = setup_ctrlc_handler(param.json_printer.json_enabled()); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | let (ref_block_pos, mut ref_block) = get_ref_block!(param, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | let stats = Arc::new(Mutex::new(Stats::new(&ref_block, total_block_count, json_printer))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | [INFO] [stdout] 277 | let mut reader = FileReader::new(¶m.in_file, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | let mut block = Block::dummy(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | [INFO] [stdout] 283 | let reporter = Arc::new(ProgressReporter::new(&stats, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | let mut rs_codec = RSRepairer::new(¶m.json_printer, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | let stats = stats.lock().unwrap().clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 402 | [INFO] [stdout] 403 | Ok(Some(stats)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/misc_macros.rs:18:29 [INFO] [stdout] | [INFO] [stdout] 18 | let (ref_block_pos, ref_block) = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Some(x) => x, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sort_core.rs:239:8 [INFO] [stdout] | [INFO] [stdout] 137 | let ctrlc_stop_flag = setup_ctrlc_handler(param.json_printer.json_enabled()); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | let (ref_block_pos, ref_block) = get_ref_block!(param, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | let stats = Arc::new(Mutex::new(Stats::new(&ref_block, file_size, json_printer))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let mut reader = FileReader::new(¶m.in_file, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | let mut writer = FileWriter::new(¶m.out_file, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let mut block = Block::dummy(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | [INFO] [stdout] 177 | let reporter = Arc::new(ProgressReporter::new(&stats, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | let stats = stats.lock().unwrap().clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | [INFO] [stdout] 239 | Ok(Some(stats)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/misc_macros.rs:18:29 [INFO] [stdout] | [INFO] [stdout] 18 | let (ref_block_pos, ref_block) = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Some(x) => x, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/check_core.rs:233:8 [INFO] [stdout] | [INFO] [stdout] 132 | let ctrlc_stop_flag = setup_ctrlc_handler(param.json_printer.json_enabled()); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let (_, ref_block) = get_ref_block!(param, json_printer, ctrlc_stop_flag); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | let stats = Arc::new(Mutex::new(Stats::new(&ref_block, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let mut reader = FileReader::new(¶m.in_file, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | let mut block = Block::dummy(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | [INFO] [stdout] 151 | let reporter = Arc::new(ProgressReporter::new(&stats, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | let stats = stats.lock().unwrap().clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | [INFO] [stdout] 233 | Ok(Some(stats)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/misc_macros.rs:18:29 [INFO] [stdout] | [INFO] [stdout] 18 | let (ref_block_pos, ref_block) = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Some(x) => x, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_reader.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 78 | let file = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let file = match file { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | Ok(f) => f, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | Err(e) => { return Err(to_err(FileError::new(e.kind(), path))); } [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | }; [INFO] [stdout] 87 | Ok (FileReader { [INFO] [stdout] | _____________^ [INFO] [stdout] 88 | | file : [INFO] [stdout] 89 | | if param.buffered { [INFO] [stdout] 90 | | FileHandle::Buffered(BufReader::new(file)) [INFO] [stdout] ... | [INFO] [stdout] 95 | | write_enabled, [INFO] [stdout] 96 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_writer.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 97 | let file = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | let file = match file { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | Ok(f) => f, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | Err(e) => { return Err(to_err(FileError::new(e.kind(), path))); } [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | }; [INFO] [stdout] 109 | Ok (FileWriter { [INFO] [stdout] | _____________^ [INFO] [stdout] 110 | | file : [INFO] [stdout] 111 | | if param.buffered { [INFO] [stdout] 112 | | FileHandle::Buffered(BufWriter::new(file)) [INFO] [stdout] ... | [INFO] [stdout] 117 | | read_enabled, [INFO] [stdout] 118 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/repair_core.rs:159:45 [INFO] [stdout] | [INFO] [stdout] 159 | ... pred : &Fn(&Block) -> bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 159 | pred : &dyn Fn(&Block) -> bool, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli_decode.rs:93:11 [INFO] [stdout] | [INFO] [stdout] 42 | let mut json_printer = get_json_printer!(matches); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let param = Param::new(get_ref_block_choice!(matches), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | match decode_core::decode_file(¶m) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli_rescue.rs:117:11 [INFO] [stdout] | [INFO] [stdout] 62 | let json_printer = get_json_printer!(matches); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let param = Param::new(in_file, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | match rescue_core::rescue_from_file(¶m) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/cli_macros.rs:274:16 [INFO] [stdout] | [INFO] [stdout] 274 | Ok(x) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli_show.rs:57:11 [INFO] [stdout] | [INFO] [stdout] 38 | let json_printer = get_json_printer!(matches); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let param = Param::new(matches.is_present("show_all"), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | match show_core::show_file(¶m) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli_repair.rs:88:11 [INFO] [stdout] | [INFO] [stdout] 43 | let json_printer = get_json_printer!(matches); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let param = Param::new(in_file, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | match repair_core::repair_file(¶m) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli_check.rs:44:11 [INFO] [stdout] | [INFO] [stdout] 31 | let json_printer = get_json_printer!(matches); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let param = Param::new(get_ref_block_choice!(matches), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | match check_core::check_file(¶m) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli_sort.rs:72:11 [INFO] [stdout] | [INFO] [stdout] 41 | let json_printer = get_json_printer!(matches); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let param = Param::new(get_ref_block_choice!(matches), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | match sort_core::sort_file(¶m) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 22 previous errors; 21 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rsbx` (lib) due to 23 previous errors; 21 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp_opt`: use `DateTime::from_timestamp` instead [INFO] [stdout] --> src/time_utils.rs:36:30 [INFO] [stdout] | [INFO] [stdout] 36 | match NaiveDateTime::from_timestamp_opt(secs, 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block_utils.rs:197:8 [INFO] [stdout] | [INFO] [stdout] 124 | let stats = Arc::new(Mutex::new(ScanStats::new(file_size))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | [INFO] [stdout] 126 | let reporter = ProgressReporter::new(&stats, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let mut block = Block::dummy(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | [INFO] [stdout] 137 | let mut meta_block = None; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let mut data_block = None; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | [INFO] [stdout] 140 | let mut reader = FileReader::new(in_file, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | Ok(match ref_block_choice { [INFO] [stdout] | ________^ [INFO] [stdout] 198 | | RefBlockChoice::Any => match (meta_block, data_block) { [INFO] [stdout] 199 | | (Some(m), _ ) => Some(m), [INFO] [stdout] 200 | | (_ , Some(d)) => Some(d), [INFO] [stdout] ... | [INFO] [stdout] 224 | | } [INFO] [stdout] 225 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sbx_block/mod.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 184 | let mut block = Block::new(Version::V1, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | block.verify_crc(buffer).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:111:24 [INFO] [stdout] | [INFO] [stdout] 100 | let write_flag = Arc::new(AtomicBool::new(true)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let runner_write_flag = Arc::clone(&write_flag); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | stats : Arc::clone(stats), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rs_codec/encoder.rs:70:24 [INFO] [stdout] | [INFO] [stdout] 65 | let par_buf : SmallVec<[SmallVec<[u8; SBX_LARGEST_BLOCK_SIZE]>; 32]> = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | rs_codec : ReedSolomon::new(data_shards, [INFO] [stdout] | ________________________^ [INFO] [stdout] 71 | | parity_shards).unwrap(), [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | let mut v = SmallVec::with_capacity($len); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rs_codec/repairer.rs:202:30 [INFO] [stdout] | [INFO] [stdout] 195 | let buf : SmallVec<[SmallVec<[u8; SBX_LARGEST_BLOCK_SIZE]>; 32]> = [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | smallvec![smallvec![0; block_size]; data_shards + parity_shards]; [INFO] [stdout] 197 | let buf_present : SmallVec<[bool; 32]> = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | rs_codec : ReedSolomon::new(data_shards, [INFO] [stdout] | ______________________________^ [INFO] [stdout] 203 | | parity_shards).unwrap(), [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | let mut v = SmallVec::with_capacity($len); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rs_codec/repairer.rs:208:30 [INFO] [stdout] | [INFO] [stdout] 195 | let buf : SmallVec<[SmallVec<[u8; SBX_LARGEST_BLOCK_SIZE]>; 32]> = [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | smallvec![smallvec![0; block_size]; data_shards + parity_shards]; [INFO] [stdout] 197 | let buf_present : SmallVec<[bool; 32]> = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | ref_block : ref_block.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | let mut v = SmallVec::with_capacity($len); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rs_codec/repairer.rs:210:30 [INFO] [stdout] | [INFO] [stdout] 195 | let buf : SmallVec<[SmallVec<[u8; SBX_LARGEST_BLOCK_SIZE]>; 32]> = [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | smallvec![smallvec![0; block_size]; data_shards + parity_shards]; [INFO] [stdout] 197 | let buf_present : SmallVec<[bool; 32]> = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | json_printer : Arc::clone(json_printer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | let mut v = SmallVec::with_capacity($len); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rs_codec/repairer.rs:343:10 [INFO] [stdout] | [INFO] [stdout] 286 | let mut repaired_blocks = [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | (RSRepairStats { version : self.version, [INFO] [stdout] | __________^ [INFO] [stdout] 344 | | data_par_burst : self.data_par_burst, [INFO] [stdout] 345 | | successful, [INFO] [stdout] 346 | | json_printer : Arc::clone(&self.json_printer), [INFO] [stdout] ... | [INFO] [stdout] 349 | | missing_count : self.missing_count(), [INFO] [stdout] 350 | | present_count : self.present_count(), }, [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode_core.rs:831:8 [INFO] [stdout] | [INFO] [stdout] 505 | let mut reader = FileReader::new(¶m.in_file, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 509 | let mut writer = match param.out_file { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 517 | let stats : Arc>; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 518 | [INFO] [stdout] 519 | let reporter : ProgressReporter; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 520 | [INFO] [stdout] 521 | let mut hash_bytes = None; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 522 | [INFO] [stdout] 523 | let mut block = Block::dummy(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 528 | let recorded_hash = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 829 | let res = stats.lock().unwrap().clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 830 | [INFO] [stdout] 831 | Ok((res, hash_bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode_core.rs:891:8 [INFO] [stdout] | [INFO] [stdout] 838 | let hash_bytes : Option = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 854 | let mut reader = match param.out_file { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 863 | let stats = Arc::new(Mutex::new(HashStats::new(file_size))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 864 | [INFO] [stdout] 865 | let reporter = ProgressReporter::new(&stats, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 891 | Ok(Some(hash_ctx.finish_into_hash_bytes())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode_core.rs:976:8 [INFO] [stdout] | [INFO] [stdout] 896 | let ctrlc_stop_flag = setup_ctrlc_handler(param.json_printer.json_enabled()); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 900 | let (ref_block_pos, ref_block) = get_ref_block!(param, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 956 | let param = Param::new(param.ref_block_choice, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 964 | let (mut stats, hash_res) = decode(¶m, [INFO] [stdout] | ----- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 976 | Ok(Some(stats)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/misc_macros.rs:18:29 [INFO] [stdout] | [INFO] [stdout] 18 | let (ref_block_pos, ref_block) = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Some(x) => x, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repair_core.rs:403:8 [INFO] [stdout] | [INFO] [stdout] 227 | let ctrlc_stop_flag = setup_ctrlc_handler(param.json_printer.json_enabled()); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | let (ref_block_pos, mut ref_block) = get_ref_block!(param, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | let stats = Arc::new(Mutex::new(Stats::new(&ref_block, total_block_count, json_printer))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | [INFO] [stdout] 277 | let mut reader = FileReader::new(¶m.in_file, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | let mut block = Block::dummy(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | [INFO] [stdout] 283 | let reporter = Arc::new(ProgressReporter::new(&stats, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | let mut rs_codec = RSRepairer::new(¶m.json_printer, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | let stats = stats.lock().unwrap().clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 402 | [INFO] [stdout] 403 | Ok(Some(stats)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/misc_macros.rs:18:29 [INFO] [stdout] | [INFO] [stdout] 18 | let (ref_block_pos, ref_block) = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Some(x) => x, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sort_core.rs:239:8 [INFO] [stdout] | [INFO] [stdout] 137 | let ctrlc_stop_flag = setup_ctrlc_handler(param.json_printer.json_enabled()); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | let (ref_block_pos, ref_block) = get_ref_block!(param, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | let stats = Arc::new(Mutex::new(Stats::new(&ref_block, file_size, json_printer))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let mut reader = FileReader::new(¶m.in_file, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | let mut writer = FileWriter::new(¶m.out_file, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let mut block = Block::dummy(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | [INFO] [stdout] 177 | let reporter = Arc::new(ProgressReporter::new(&stats, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | let stats = stats.lock().unwrap().clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | [INFO] [stdout] 239 | Ok(Some(stats)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/misc_macros.rs:18:29 [INFO] [stdout] | [INFO] [stdout] 18 | let (ref_block_pos, ref_block) = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Some(x) => x, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/check_core.rs:233:8 [INFO] [stdout] | [INFO] [stdout] 132 | let ctrlc_stop_flag = setup_ctrlc_handler(param.json_printer.json_enabled()); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let (_, ref_block) = get_ref_block!(param, json_printer, ctrlc_stop_flag); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | let stats = Arc::new(Mutex::new(Stats::new(&ref_block, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let mut reader = FileReader::new(¶m.in_file, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | let mut block = Block::dummy(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | [INFO] [stdout] 151 | let reporter = Arc::new(ProgressReporter::new(&stats, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | let stats = stats.lock().unwrap().clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | [INFO] [stdout] 233 | Ok(Some(stats)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/misc_macros.rs:18:29 [INFO] [stdout] | [INFO] [stdout] 18 | let (ref_block_pos, ref_block) = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Some(x) => x, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_reader.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 78 | let file = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let file = match file { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | Ok(f) => f, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | Err(e) => { return Err(to_err(FileError::new(e.kind(), path))); } [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | }; [INFO] [stdout] 87 | Ok (FileReader { [INFO] [stdout] | _____________^ [INFO] [stdout] 88 | | file : [INFO] [stdout] 89 | | if param.buffered { [INFO] [stdout] 90 | | FileHandle::Buffered(BufReader::new(file)) [INFO] [stdout] ... | [INFO] [stdout] 95 | | write_enabled, [INFO] [stdout] 96 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_writer.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 97 | let file = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | let file = match file { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | Ok(f) => f, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | Err(e) => { return Err(to_err(FileError::new(e.kind(), path))); } [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | }; [INFO] [stdout] 109 | Ok (FileWriter { [INFO] [stdout] | _____________^ [INFO] [stdout] 110 | | file : [INFO] [stdout] 111 | | if param.buffered { [INFO] [stdout] 112 | | FileHandle::Buffered(BufWriter::new(file)) [INFO] [stdout] ... | [INFO] [stdout] 117 | | read_enabled, [INFO] [stdout] 118 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli_decode.rs:93:11 [INFO] [stdout] | [INFO] [stdout] 42 | let mut json_printer = get_json_printer!(matches); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let param = Param::new(get_ref_block_choice!(matches), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | match decode_core::decode_file(¶m) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli_rescue.rs:117:11 [INFO] [stdout] | [INFO] [stdout] 62 | let json_printer = get_json_printer!(matches); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let param = Param::new(in_file, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | match rescue_core::rescue_from_file(¶m) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/cli_macros.rs:274:16 [INFO] [stdout] | [INFO] [stdout] 274 | Ok(x) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli_show.rs:57:11 [INFO] [stdout] | [INFO] [stdout] 38 | let json_printer = get_json_printer!(matches); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let param = Param::new(matches.is_present("show_all"), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | match show_core::show_file(¶m) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli_repair.rs:88:11 [INFO] [stdout] | [INFO] [stdout] 43 | let json_printer = get_json_printer!(matches); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let param = Param::new(in_file, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | match repair_core::repair_file(¶m) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli_check.rs:44:11 [INFO] [stdout] | [INFO] [stdout] 31 | let json_printer = get_json_printer!(matches); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let param = Param::new(get_ref_block_choice!(matches), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | match check_core::check_file(¶m) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli_sort.rs:72:11 [INFO] [stdout] | [INFO] [stdout] 41 | let json_printer = get_json_printer!(matches); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let param = Param::new(get_ref_block_choice!(matches), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | match sort_core::sort_file(¶m) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 22 previous errors; 21 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rsbx` (lib test) due to 23 previous errors; 21 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0183471d1ae235da016d729dfa371c83cd51411c4904a02edaa00731f49c31ad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0183471d1ae235da016d729dfa371c83cd51411c4904a02edaa00731f49c31ad", kill_on_drop: false }` [INFO] [stdout] 0183471d1ae235da016d729dfa371c83cd51411c4904a02edaa00731f49c31ad