[INFO] fetching crate rsa_keygen 1.0.9... [INFO] checking rsa_keygen-1.0.9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rsa_keygen 1.0.9 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate rsa_keygen 1.0.9 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rsa_keygen 1.0.9 [INFO] finished tweaking crates.io crate rsa_keygen 1.0.9 [INFO] tweaked toml for crates.io crate rsa_keygen 1.0.9 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate rsa_keygen 1.0.9 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ae8ab130246e32a6a806c86b8ab897637e9d7040cb1ba02f530f34262af11606 [INFO] running `Command { std: "docker" "start" "-a" "ae8ab130246e32a6a806c86b8ab897637e9d7040cb1ba02f530f34262af11606", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ae8ab130246e32a6a806c86b8ab897637e9d7040cb1ba02f530f34262af11606", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae8ab130246e32a6a806c86b8ab897637e9d7040cb1ba02f530f34262af11606", kill_on_drop: false }` [INFO] [stdout] ae8ab130246e32a6a806c86b8ab897637e9d7040cb1ba02f530f34262af11606 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ca5bfdeddb1df9736786bba7e714a0da9b3f43b3336a3f5688a3d596b31f0562 [INFO] running `Command { std: "docker" "start" "-a" "ca5bfdeddb1df9736786bba7e714a0da9b3f43b3336a3f5688a3d596b31f0562", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking num-iter v0.1.44 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking tiny-bip39 v1.0.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking rsa v0.9.6 [INFO] [stderr] Checking rsa_keygen v1.0.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `io::Read` [INFO] [stdout] --> src/rsa_keygen.rs:11:15 [INFO] [stdout] | [INFO] [stdout] 11 | use std::{fs, io::Read}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `io::Read` [INFO] [stdout] --> src/rsa_keygen.rs:11:15 [INFO] [stdout] | [INFO] [stdout] 11 | use std::{fs, io::Read}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `priv_key` [INFO] [stdout] --> src/rsa_keygen.rs:206:10 [INFO] [stdout] | [INFO] [stdout] 206 | let (priv_key, pub_key) = keypair_from_seedphrase(&seedphrase).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_priv_key` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `priv_key1` [INFO] [stdout] --> src/rsa_keygen.rs:207:10 [INFO] [stdout] | [INFO] [stdout] 207 | let (priv_key1, pub_key1) = keypair_from_seedphrase(&seedphrase).unwrap(); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_priv_key1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pub_key` [INFO] [stdout] --> src/rsa_keygen.rs:215:20 [INFO] [stdout] | [INFO] [stdout] 215 | let (priv_key, pub_key) = keypair_from_seedphrase(&seedphrase).unwrap(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pub_key` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pub_key1` [INFO] [stdout] --> src/rsa_keygen.rs:216:21 [INFO] [stdout] | [INFO] [stdout] 216 | let (priv_key1, pub_key1) = keypair_from_seedphrase(&seedphrase).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pub_key1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `priv_key1` [INFO] [stdout] --> src/rsa_keygen.rs:225:10 [INFO] [stdout] | [INFO] [stdout] 225 | let (priv_key1, pub_key1) = keypair_from_private_key(&priv_key); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_priv_key1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rsa_keygen.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 49 | let mnemonic = Mnemonic::from_phrase(seedphrase.as_str(), Language::English).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let mut seed = Seed::new(&mnemonic, ""); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let priv_key = RsaPrivateKey::new(&mut rng, 2048).map_err(|err| err.to_string())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let pub_key = RsaPublicKey::from(&priv_key); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | [INFO] [stdout] 58 | Ok((priv_key, pub_key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rsa_keygen.rs:105:8 [INFO] [stdout] | [INFO] [stdout] 102 | let seedphrase = generate_seedphrase(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let keypair = keypair_from_seedphrase(&seedphrase).map_err(|err| err.to_string())?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | [INFO] [stdout] 105 | Ok((seedphrase, keypair)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rsa_keygen.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 49 | let mnemonic = Mnemonic::from_phrase(seedphrase.as_str(), Language::English).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let mut seed = Seed::new(&mnemonic, ""); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let priv_key = RsaPrivateKey::new(&mut rng, 2048).map_err(|err| err.to_string())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let pub_key = RsaPublicKey::from(&priv_key); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | [INFO] [stdout] 58 | Ok((priv_key, pub_key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rsa_keygen.rs:105:8 [INFO] [stdout] | [INFO] [stdout] 102 | let seedphrase = generate_seedphrase(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let keypair = keypair_from_seedphrase(&seedphrase).map_err(|err| err.to_string())?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | [INFO] [stdout] 105 | Ok((seedphrase, keypair)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rsa_keygen` (lib test) due to 3 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rsa_keygen` (lib) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "ca5bfdeddb1df9736786bba7e714a0da9b3f43b3336a3f5688a3d596b31f0562", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca5bfdeddb1df9736786bba7e714a0da9b3f43b3336a3f5688a3d596b31f0562", kill_on_drop: false }` [INFO] [stdout] ca5bfdeddb1df9736786bba7e714a0da9b3f43b3336a3f5688a3d596b31f0562