[INFO] fetching crate rs_poker 3.0.0-beta.25... [INFO] checking rs_poker-3.0.0-beta.25 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rs_poker 3.0.0-beta.25 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate rs_poker 3.0.0-beta.25 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-5-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate rs_poker 3.0.0-beta.25 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate rs_poker 3.0.0-beta.25 [INFO] tweaked toml for crates.io crate rs_poker 3.0.0-beta.25 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate rs_poker 3.0.0-beta.25 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f4034370501fb7525e1355c8f1766e2896e840ea00657f7e5f9b8cb26e137f19 [INFO] running `Command { std: "docker" "start" "-a" "f4034370501fb7525e1355c8f1766e2896e840ea00657f7e5f9b8cb26e137f19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f4034370501fb7525e1355c8f1766e2896e840ea00657f7e5f9b8cb26e137f19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4034370501fb7525e1355c8f1766e2896e840ea00657f7e5f9b8cb26e137f19", kill_on_drop: false }` [INFO] [stdout] f4034370501fb7525e1355c8f1766e2896e840ea00657f7e5f9b8cb26e137f19 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d68cc252989d2765ff2daf4bc58f0294683e26081538d88db04f80492a5a795d [INFO] running `Command { std: "docker" "start" "-a" "d68cc252989d2765ff2daf4bc58f0294683e26081538d88db04f80492a5a795d", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling serde_json v1.0.118 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking clap_builder v4.5.8 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking clap v4.5.8 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling test-log-macros v0.2.16 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking test-log v0.2.16 [INFO] [stderr] Checking uuid v1.9.1 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking rs_poker v3.0.0-beta.25 (/opt/rustwide/workdir) [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/holdem/parse.rs:580:12 [INFO] [stdout] | [INFO] [stdout] 577 | let unique_hands: HashSet = all_hands.into_iter().flatten().collect(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 580 | Ok(unique_hands.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arena/competition/holdem_competition.rs:87:12 [INFO] [stdout] | [INFO] [stdout] 67 | let mut sims = VecDeque::with_capacity(self.max_sim_history); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | Ok(sims.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arena/competition/sim_gen.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 47 | let agents = self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let historians = self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | / HoldemSimulationBuilder::default() [INFO] [stdout] 59 | | .agents(agents) [INFO] [stdout] 60 | | .historians(historians) [INFO] [stdout] 61 | | .game_state(game_state) [INFO] [stdout] 62 | | .rng(rng) [INFO] [stdout] 63 | | .build() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arena/competition/tournament.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn build(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | // Make sure that the needed properties are set [INFO] [stdout] 110 | let agent_builders = self [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let historian_builders = self.historian_generators.unwrap_or_default(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | // Return everything [INFO] [stdout] 119 | Ok(SingleTableTournament { [INFO] [stdout] | ____________^ [INFO] [stdout] 120 | | agent_generators: agent_builders, [INFO] [stdout] 121 | | historian_generators: historian_builders, [INFO] [stdout] 122 | | starting_game_state, [INFO] [stdout] 123 | | panic_on_historian_error: self.panic_on_historian_error, [INFO] [stdout] 124 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arena/sim_builder.rs:168:12 [INFO] [stdout] | [INFO] [stdout] 143 | pub fn build(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | let agents = self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | Ok(HoldemSimulation { [INFO] [stdout] | ____________^ [INFO] [stdout] 169 | | agents, [INFO] [stdout] 170 | | game_state, [INFO] [stdout] 171 | | deck, [INFO] [stdout] ... | [INFO] [stdout] 174 | | panic_on_historian_error: self.panic_on_historian_error, [INFO] [stdout] 175 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arena/simulation.rs:633:23 [INFO] [stdout] | [INFO] [stdout] 632 | .filter_map(|mut historian| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 633 | match historian.record_action(&self.id, &self.game_state, action.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rs_poker` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "d68cc252989d2765ff2daf4bc58f0294683e26081538d88db04f80492a5a795d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d68cc252989d2765ff2daf4bc58f0294683e26081538d88db04f80492a5a795d", kill_on_drop: false }` [INFO] [stdout] d68cc252989d2765ff2daf4bc58f0294683e26081538d88db04f80492a5a795d