[INFO] fetching crate rs_merkle 1.4.2... [INFO] checking rs_merkle-1.4.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rs_merkle 1.4.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate rs_merkle 1.4.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rs_merkle 1.4.2 [INFO] finished tweaking crates.io crate rs_merkle 1.4.2 [INFO] tweaked toml for crates.io crate rs_merkle 1.4.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 17 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1ee7e3c6bba2a902af3c6f2aa0ff16024de8ab5d2b42923f43ba6bcdff0699b6 [INFO] running `Command { std: "docker" "start" "-a" "1ee7e3c6bba2a902af3c6f2aa0ff16024de8ab5d2b42923f43ba6bcdff0699b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1ee7e3c6bba2a902af3c6f2aa0ff16024de8ab5d2b42923f43ba6bcdff0699b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ee7e3c6bba2a902af3c6f2aa0ff16024de8ab5d2b42923f43ba6bcdff0699b6", kill_on_drop: false }` [INFO] [stdout] 1ee7e3c6bba2a902af3c6f2aa0ff16024de8ab5d2b42923f43ba6bcdff0699b6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 94b9e005c8670d986bcd51b8b08d3cdb497ec9a260e4b3c9a66f808acf8e1d1e [INFO] running `Command { std: "docker" "start" "-a" "94b9e005c8670d986bcd51b8b08d3cdb497ec9a260e4b3c9a66f808acf8e1d1e", kill_on_drop: false }` [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking rs_merkle v1.4.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/common.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn combinations(vec: Vec) -> Vec> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | combine(Vec::new(), vec, Vec::new()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/common.rs:42:30 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn combinations(vec: Vec) -> Vec> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | combine(Vec::new(), vec, Vec::new()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rs_merkle` (test "common") due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `TestData48` is never constructed [INFO] [stdout] --> tests/common.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct TestData48 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `setup_sha384` is never used [INFO] [stdout] --> tests/common.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn setup_sha384() -> TestData48 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/common.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn combinations(vec: Vec) -> Vec> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | combine(Vec::new(), vec, Vec::new()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/common.rs:42:30 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn combinations(vec: Vec) -> Vec> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | combine(Vec::new(), vec, Vec::new()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rs_merkle` (test "merkle_proof_test") due to 3 previous errors; 2 warnings emitted [INFO] [stdout] warning: field `leaf_values` is never read [INFO] [stdout] --> tests/common.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct TestData { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 8 | pub leaf_values: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `leaf_values` is never read [INFO] [stdout] --> tests/common.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct TestData48 { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 14 | pub leaf_values: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `combine` is never used [INFO] [stdout] --> tests/common.rs:19:4 [INFO] [stdout] | [INFO] [stdout] 19 | fn combine(active: Vec, rest: Vec, mut combinations: Vec>) -> Vec> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `combinations` is never used [INFO] [stdout] --> tests/common.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn combinations(vec: Vec) -> Vec> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ProofTestCases` is never constructed [INFO] [stdout] --> tests/common.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | pub struct ProofTestCases { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ProofTestCases` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MerkleProofTestCase` is never constructed [INFO] [stdout] --> tests/common.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 80 | pub struct MerkleProofTestCase { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MerkleProofTestCase` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> tests/common.rs:86:8 [INFO] [stdout] | [INFO] [stdout] 85 | impl MerkleProofTestCase { [INFO] [stdout] | ------------------------ associated function in this implementation [INFO] [stdout] 86 | fn new(leaf_hashes_to_prove: Vec<[u8; 32]>, leaf_indices_to_prove: Vec) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `setup_proof_test_cases` is never used [INFO] [stdout] --> tests/common.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn setup_proof_test_cases() -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/common.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn combinations(vec: Vec) -> Vec> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | combine(Vec::new(), vec, Vec::new()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/common.rs:42:30 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn combinations(vec: Vec) -> Vec> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | combine(Vec::new(), vec, Vec::new()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rs_merkle` (test "merkle_tree_test") due to 3 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "94b9e005c8670d986bcd51b8b08d3cdb497ec9a260e4b3c9a66f808acf8e1d1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "94b9e005c8670d986bcd51b8b08d3cdb497ec9a260e4b3c9a66f808acf8e1d1e", kill_on_drop: false }` [INFO] [stdout] 94b9e005c8670d986bcd51b8b08d3cdb497ec9a260e4b3c9a66f808acf8e1d1e