[INFO] fetching crate rs_handstrength 0.4.3... [INFO] checking rs_handstrength-0.4.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rs_handstrength 0.4.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate rs_handstrength 0.4.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rs_handstrength 0.4.3 [INFO] finished tweaking crates.io crate rs_handstrength 0.4.3 [INFO] tweaked toml for crates.io crate rs_handstrength 0.4.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 07a42ee476d9687dda182e54b6b25482a4f212c4dda0584b4c8e2c74fc1b2fc6 [INFO] running `Command { std: "docker" "start" "-a" "07a42ee476d9687dda182e54b6b25482a4f212c4dda0584b4c8e2c74fc1b2fc6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "07a42ee476d9687dda182e54b6b25482a4f212c4dda0584b4c8e2c74fc1b2fc6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "07a42ee476d9687dda182e54b6b25482a4f212c4dda0584b4c8e2c74fc1b2fc6", kill_on_drop: false }` [INFO] [stdout] 07a42ee476d9687dda182e54b6b25482a4f212c4dda0584b4c8e2c74fc1b2fc6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d13a27e571775805f07d3dbce68a9806c551359d315c3567873d73d2c8372df5 [INFO] running `Command { std: "docker" "start" "-a" "d13a27e571775805f07d3dbce68a9806c551359d315c3567873d73d2c8372df5", kill_on_drop: false }` [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Checking rs_handstrength v0.4.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `GroupBy` [INFO] [stdout] --> src/pf_rank.rs:1:28 [INFO] [stdout] | [INFO] [stdout] 1 | use itertools::{Itertools, GroupBy}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Suit` [INFO] [stdout] --> src/pf_rank.rs:3:25 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::card::{Card, Suit}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `GroupBy` [INFO] [stdout] --> src/pf_rank.rs:1:28 [INFO] [stdout] | [INFO] [stdout] 1 | use itertools::{Itertools, GroupBy}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `insta::assert_debug_snapshot` [INFO] [stdout] --> src/tests/test_equity.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | use insta::assert_debug_snapshot; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `black_box` [INFO] [stdout] --> src/tests/test_equity.rs:6:25 [INFO] [stdout] | [INFO] [stdout] 6 | use test::{Bencher, black_box}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hithc` [INFO] [stdout] --> src/get_nut_rank.rs:83:10 [INFO] [stdout] | [INFO] [stdout] 83 | let (hithc, rankhc) = is_subset(hand, can_hc, relative); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_hithc` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cal_eq_start` [INFO] [stdout] --> src/equity.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | let cal_eq_start = std::time::Instant::now(); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cal_eq_start` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cal_eq_end` [INFO] [stdout] --> src/equity.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | let cal_eq_end = std::time::Instant::now(); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cal_eq_end` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/can_str.rs:46:29 [INFO] [stdout] | [INFO] [stdout] 46 | .filter(|&val| !board_candidates.iter().map(|card| card.value).collect::>().contains(val)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rs_handstrength` (lib) due to 2 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `hithc` [INFO] [stdout] --> src/get_nut_rank.rs:83:10 [INFO] [stdout] | [INFO] [stdout] 83 | let (hithc, rankhc) = is_subset(hand, can_hc, relative); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_hithc` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cal_eq_start` [INFO] [stdout] --> src/equity.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | let cal_eq_start = std::time::Instant::now(); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cal_eq_start` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cal_eq_end` [INFO] [stdout] --> src/equity.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | let cal_eq_end = std::time::Instant::now(); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cal_eq_end` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `equities` [INFO] [stdout] --> src/tests/test_equity.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | let equities = equity(&hands, &community_cards); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_equities` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `equities` [INFO] [stdout] --> src/tests/test_equity.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | let equities = equity(&hands, &community_cards); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_equities` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `strflush1` is never used [INFO] [stdout] --> src/tests/can_have_strflush.rs:77:8 [INFO] [stdout] | [INFO] [stdout] 77 | fn strflush1() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `fh_with_trips_board` is never used [INFO] [stdout] --> src/tests/can_have_fullhouse.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | fn fh_with_trips_board() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `fh_with_trips_pair_board` is never used [INFO] [stdout] --> src/tests/can_have_fullhouse.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 27 | fn fh_with_trips_pair_board() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `fh_with_trips_pair_above_board` is never used [INFO] [stdout] --> src/tests/can_have_fullhouse.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 45 | fn fh_with_trips_pair_above_board() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `fh_with_pair_board` is never used [INFO] [stdout] --> src/tests/can_have_fullhouse.rs:63:8 [INFO] [stdout] | [INFO] [stdout] 63 | fn fh_with_pair_board() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `no_flush` is never used [INFO] [stdout] --> src/tests/can_flush.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | fn no_flush() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `nopair_board` is never used [INFO] [stdout] --> src/tests/can_have_twopairs.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | fn nopair_board() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `nopair_board` is never used [INFO] [stdout] --> src/tests/can_have_pair.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | fn nopair_board() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `pair1_board` is never used [INFO] [stdout] --> src/tests/can_have_pair.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 20 | fn pair1_board() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/can_str.rs:46:29 [INFO] [stdout] | [INFO] [stdout] 46 | .filter(|&val| !board_candidates.iter().map(|card| card.value).collect::>().contains(val)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rs_handstrength` (lib test) due to 2 previous errors; 17 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d13a27e571775805f07d3dbce68a9806c551359d315c3567873d73d2c8372df5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d13a27e571775805f07d3dbce68a9806c551359d315c3567873d73d2c8372df5", kill_on_drop: false }` [INFO] [stdout] d13a27e571775805f07d3dbce68a9806c551359d315c3567873d73d2c8372df5