[INFO] fetching crate rs3270 0.1.2... [INFO] checking rs3270-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rs3270 0.1.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate rs3270 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rs3270 0.1.2 [INFO] finished tweaking crates.io crate rs3270 0.1.2 [INFO] tweaked toml for crates.io crate rs3270 0.1.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ba538d95d8d3ea45819f3d1c31fd763dd21d9c403ae73eaf9c642bb17a5699df [INFO] running `Command { std: "docker" "start" "-a" "ba538d95d8d3ea45819f3d1c31fd763dd21d9c403ae73eaf9c642bb17a5699df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ba538d95d8d3ea45819f3d1c31fd763dd21d9c403ae73eaf9c642bb17a5699df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba538d95d8d3ea45819f3d1c31fd763dd21d9c403ae73eaf9c642bb17a5699df", kill_on_drop: false }` [INFO] [stdout] ba538d95d8d3ea45819f3d1c31fd763dd21d9c403ae73eaf9c642bb17a5699df [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a4ecc50a301c6a08cd9042eafe33b98240aba794f4741e297196dd236a84ea14 [INFO] running `Command { std: "docker" "start" "-a" "a4ecc50a301c6a08cd9042eafe33b98240aba794f4741e297196dd236a84ea14", kill_on_drop: false }` [INFO] [stderr] Checking rs3270 v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::client_interface` [INFO] [stdout] --> src/mainframe_provider.rs:212:9 [INFO] [stdout] | [INFO] [stdout] 212 | use crate::client_interface; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `MoveCursorToNextField_is_successful` should have a snake case name [INFO] [stdout] --> src/client_interface.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 94 | [<$command_name:camel _is_successful>]: RefCell> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `move_cursor_to_next_field_is_successful` [INFO] [stdout] ... [INFO] [stdout] 543 | / command!(MoveCursorToNextField, [INFO] [stdout] 544 | | command: { [INFO] [stdout] 545 | | format!("Tab") [INFO] [stdout] 546 | | } [INFO] [stdout] 547 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] = note: this warning originates in the macro `command` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `MoveCursorToPreviousField_is_successful` should have a snake case name [INFO] [stdout] --> src/client_interface.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 94 | [<$command_name:camel _is_successful>]: RefCell> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `move_cursor_to_previous_field_is_successful` [INFO] [stdout] ... [INFO] [stdout] 549 | / command!(MoveCursorToPreviousField, [INFO] [stdout] 550 | | command: { [INFO] [stdout] 551 | | format!("BackTab") [INFO] [stdout] 552 | | } [INFO] [stdout] 553 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `command` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `MoveCursorToFirstField_is_successful` should have a snake case name [INFO] [stdout] --> src/client_interface.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 94 | [<$command_name:camel _is_successful>]: RefCell> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `move_cursor_to_first_field_is_successful` [INFO] [stdout] ... [INFO] [stdout] 555 | / command!(MoveCursorToFirstField, [INFO] [stdout] 556 | | command: { [INFO] [stdout] 557 | | String::from("Home") [INFO] [stdout] 558 | | } [INFO] [stdout] 559 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `command` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `SendEnterKey_is_successful` should have a snake case name [INFO] [stdout] --> src/client_interface.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 94 | [<$command_name:camel _is_successful>]: RefCell> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `send_enter_key_is_successful` [INFO] [stdout] ... [INFO] [stdout] 561 | / command!(SendEnterKey, [INFO] [stdout] 562 | | command: { [INFO] [stdout] 563 | | format!("Enter") [INFO] [stdout] 564 | | } [INFO] [stdout] 565 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `command` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `ClearTextFromField_is_successful` should have a snake case name [INFO] [stdout] --> src/client_interface.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 94 | [<$command_name:camel _is_successful>]: RefCell> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `clear_text_from_field_is_successful` [INFO] [stdout] ... [INFO] [stdout] 567 | / command!(ClearTextFromField, [INFO] [stdout] 568 | | command: { [INFO] [stdout] 569 | | format!("DeleteField") [INFO] [stdout] 570 | | } [INFO] [stdout] 571 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `command` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `MoveCursorToFieldEnd_is_successful` should have a snake case name [INFO] [stdout] --> src/client_interface.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 94 | [<$command_name:camel _is_successful>]: RefCell> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `move_cursor_to_field_end_is_successful` [INFO] [stdout] ... [INFO] [stdout] 573 | / command!(MoveCursorToFieldEnd, [INFO] [stdout] 574 | | command: { [INFO] [stdout] 575 | | format!("FieldEnd") [INFO] [stdout] 576 | | } [INFO] [stdout] 577 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `command` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mainframe_provider.rs:25:31 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(command_executor: T) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | MainframeProvider { [INFO] [stdout] 25 | client_interface: RefCell::new(command_executor) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rs3270` (lib) due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: structure field `MoveCursorToNextField_is_successful` should have a snake case name [INFO] [stdout] --> src/client_interface.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 94 | [<$command_name:camel _is_successful>]: RefCell> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `move_cursor_to_next_field_is_successful` [INFO] [stdout] ... [INFO] [stdout] 543 | / command!(MoveCursorToNextField, [INFO] [stdout] 544 | | command: { [INFO] [stdout] 545 | | format!("Tab") [INFO] [stdout] 546 | | } [INFO] [stdout] 547 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] = note: this warning originates in the macro `command` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `MoveCursorToPreviousField_is_successful` should have a snake case name [INFO] [stdout] --> src/client_interface.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 94 | [<$command_name:camel _is_successful>]: RefCell> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `move_cursor_to_previous_field_is_successful` [INFO] [stdout] ... [INFO] [stdout] 549 | / command!(MoveCursorToPreviousField, [INFO] [stdout] 550 | | command: { [INFO] [stdout] 551 | | format!("BackTab") [INFO] [stdout] 552 | | } [INFO] [stdout] 553 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `command` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `MoveCursorToFirstField_is_successful` should have a snake case name [INFO] [stdout] --> src/client_interface.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 94 | [<$command_name:camel _is_successful>]: RefCell> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `move_cursor_to_first_field_is_successful` [INFO] [stdout] ... [INFO] [stdout] 555 | / command!(MoveCursorToFirstField, [INFO] [stdout] 556 | | command: { [INFO] [stdout] 557 | | String::from("Home") [INFO] [stdout] 558 | | } [INFO] [stdout] 559 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `command` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `SendEnterKey_is_successful` should have a snake case name [INFO] [stdout] --> src/client_interface.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 94 | [<$command_name:camel _is_successful>]: RefCell> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `send_enter_key_is_successful` [INFO] [stdout] ... [INFO] [stdout] 561 | / command!(SendEnterKey, [INFO] [stdout] 562 | | command: { [INFO] [stdout] 563 | | format!("Enter") [INFO] [stdout] 564 | | } [INFO] [stdout] 565 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `command` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `ClearTextFromField_is_successful` should have a snake case name [INFO] [stdout] --> src/client_interface.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 94 | [<$command_name:camel _is_successful>]: RefCell> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `clear_text_from_field_is_successful` [INFO] [stdout] ... [INFO] [stdout] 567 | / command!(ClearTextFromField, [INFO] [stdout] 568 | | command: { [INFO] [stdout] 569 | | format!("DeleteField") [INFO] [stdout] 570 | | } [INFO] [stdout] 571 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `command` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `MoveCursorToFieldEnd_is_successful` should have a snake case name [INFO] [stdout] --> src/client_interface.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 94 | [<$command_name:camel _is_successful>]: RefCell> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `move_cursor_to_field_end_is_successful` [INFO] [stdout] ... [INFO] [stdout] 573 | / command!(MoveCursorToFieldEnd, [INFO] [stdout] 574 | | command: { [INFO] [stdout] 575 | | format!("FieldEnd") [INFO] [stdout] 576 | | } [INFO] [stdout] 577 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `command` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `is_previous_still_running` should have an upper case name [INFO] [stdout] --> src/client_interface.rs:722:12 [INFO] [stdout] | [INFO] [stdout] 722 | static is_previous_still_running: Mutex = Mutex::new(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `IS_PREVIOUS_STILL_RUNNING` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mainframe_provider.rs:25:31 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(command_executor: T) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | MainframeProvider { [INFO] [stdout] 25 | client_interface: RefCell::new(command_executor) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `cached_client` should have an upper case name [INFO] [stdout] --> src/mainframe_provider.rs:216:12 [INFO] [stdout] | [INFO] [stdout] 216 | static cached_client: Mutex> = Mutex::new(None); [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper case: `CACHED_CLIENT` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `is_previous_still_running` should have an upper case name [INFO] [stdout] --> src/mainframe_provider.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 217 | static is_previous_still_running: Mutex = Mutex::new(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `IS_PREVIOUS_STILL_RUNNING` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rs3270` (lib test) due to 2 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a4ecc50a301c6a08cd9042eafe33b98240aba794f4741e297196dd236a84ea14", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4ecc50a301c6a08cd9042eafe33b98240aba794f4741e297196dd236a84ea14", kill_on_drop: false }` [INFO] [stdout] a4ecc50a301c6a08cd9042eafe33b98240aba794f4741e297196dd236a84ea14