[INFO] fetching crate rs-usbtmc 0.1.1... [INFO] checking rs-usbtmc-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rs-usbtmc 0.1.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate rs-usbtmc 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rs-usbtmc 0.1.1 [INFO] finished tweaking crates.io crate rs-usbtmc 0.1.1 [INFO] tweaked toml for crates.io crate rs-usbtmc 0.1.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 15 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8789ea98c810856f04bc15cc7cc1786e756f69145a78bd322e1ab81ab666292b [INFO] running `Command { std: "docker" "start" "-a" "8789ea98c810856f04bc15cc7cc1786e756f69145a78bd322e1ab81ab666292b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8789ea98c810856f04bc15cc7cc1786e756f69145a78bd322e1ab81ab666292b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8789ea98c810856f04bc15cc7cc1786e756f69145a78bd322e1ab81ab666292b", kill_on_drop: false }` [INFO] [stdout] 8789ea98c810856f04bc15cc7cc1786e756f69145a78bd322e1ab81ab666292b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 65269733b829bcfbec8700a9901051e32ccff2c7a598195e17e6abeab3dd1bde [INFO] running `Command { std: "docker" "start" "-a" "65269733b829bcfbec8700a9901051e32ccff2c7a598195e17e6abeab3dd1bde", kill_on_drop: false }` [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling rusb v0.9.4 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling libusb1-sys v0.7.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking rs-usbtmc v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `interrupt_ep` is never read [INFO] [stdout] --> src/types.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 121 | pub struct UsbtmcEndpoints { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 127 | pub interrupt_ep: Option, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UsbtmcEndpoints` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `bcd_version`, `accepts_indicator_pulse_request`, `is_talk_only`, and `is_listen_only` are never read [INFO] [stdout] --> src/types.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 135 | pub struct Capabilities { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 136 | pub bcd_version: u16, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 137 | /// Can accept a control command for pulse [INFO] [stdout] 138 | pub accepts_indicator_pulse_request: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 139 | /// Only sends data to the controller [INFO] [stdout] 140 | pub is_talk_only: bool, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 141 | /// Only accepts data from the controller [INFO] [stdout] 142 | pub is_listen_only: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Capabilities` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:141:12 [INFO] [stdout] | [INFO] [stdout] 97 | let mut context = rusb::Context::new()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | // attempt to open the device [INFO] [stdout] 99 | let (device, mut handle) = match init::open_device(&mut context, vid, pid) { [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | Some(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let handle: Handle = Handle::new(handle); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let timeout: Timeout = Timeout::new(DEFAULT_TIMEOUT_DURATION); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let btag = BTag::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | Ok(UsbtmcClient { [INFO] [stdout] | ____________^ [INFO] [stdout] 142 | | handle, [INFO] [stdout] 143 | | mode, [INFO] [stdout] 144 | | timeout, [INFO] [stdout] ... | [INFO] [stdout] 147 | | endpoints, [INFO] [stdout] 148 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:21:16 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(handle: DeviceHandle) -> Handle { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Handle(Arc::new(Mutex::new(handle))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rs-usbtmc` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `interrupt_ep` is never read [INFO] [stdout] --> src/types.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 121 | pub struct UsbtmcEndpoints { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 127 | pub interrupt_ep: Option, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UsbtmcEndpoints` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `bcd_version`, `accepts_indicator_pulse_request`, `is_talk_only`, and `is_listen_only` are never read [INFO] [stdout] --> src/types.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 135 | pub struct Capabilities { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 136 | pub bcd_version: u16, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 137 | /// Can accept a control command for pulse [INFO] [stdout] 138 | pub accepts_indicator_pulse_request: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 139 | /// Only sends data to the controller [INFO] [stdout] 140 | pub is_talk_only: bool, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 141 | /// Only accepts data from the controller [INFO] [stdout] 142 | pub is_listen_only: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Capabilities` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:141:12 [INFO] [stdout] | [INFO] [stdout] 97 | let mut context = rusb::Context::new()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | // attempt to open the device [INFO] [stdout] 99 | let (device, mut handle) = match init::open_device(&mut context, vid, pid) { [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | Some(res) => res, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let handle: Handle = Handle::new(handle); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let timeout: Timeout = Timeout::new(DEFAULT_TIMEOUT_DURATION); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let btag = BTag::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | Ok(UsbtmcClient { [INFO] [stdout] | ____________^ [INFO] [stdout] 142 | | handle, [INFO] [stdout] 143 | | mode, [INFO] [stdout] 144 | | timeout, [INFO] [stdout] ... | [INFO] [stdout] 147 | | endpoints, [INFO] [stdout] 148 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:21:16 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(handle: DeviceHandle) -> Handle { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Handle(Arc::new(Mutex::new(handle))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rs-usbtmc` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "65269733b829bcfbec8700a9901051e32ccff2c7a598195e17e6abeab3dd1bde", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "65269733b829bcfbec8700a9901051e32ccff2c7a598195e17e6abeab3dd1bde", kill_on_drop: false }` [INFO] [stdout] 65269733b829bcfbec8700a9901051e32ccff2c7a598195e17e6abeab3dd1bde