[INFO] fetching crate rs-store 0.10.2... [INFO] checking rs-store-0.10.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rs-store 0.10.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate rs-store 0.10.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-5-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate rs-store 0.10.2 [INFO] finished tweaking crates.io crate rs-store 0.10.2 [INFO] tweaked toml for crates.io crate rs-store 0.10.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate rs-store 0.10.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3b7832ab75daddd588303601c15995793b3f30668d16466ce6662ef3c472ac67 [INFO] running `Command { std: "docker" "start" "-a" "3b7832ab75daddd588303601c15995793b3f30668d16466ce6662ef3c472ac67", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3b7832ab75daddd588303601c15995793b3f30668d16466ce6662ef3c472ac67", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b7832ab75daddd588303601c15995793b3f30668d16466ce6662ef3c472ac67", kill_on_drop: false }` [INFO] [stdout] 3b7832ab75daddd588303601c15995793b3f30668d16466ce6662ef3c472ac67 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 64e3202f74bafe9ffaa65a8daebe2f55eac973b7a49618e85c7677fada98afed [INFO] running `Command { std: "docker" "start" "-a" "64e3202f74bafe9ffaa65a8daebe2f55eac973b7a49618e85c7677fada98afed", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.83 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.65 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking rs-store v0.10.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:90:39 [INFO] [stdout] | [INFO] [stdout] 88 | reducer: Box + Send + Sync>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | ) -> Arc> { [INFO] [stdout] 90 | Self::new_with_state(reducer, Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 95 | reducer: Box + Send + Sync>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | state: State, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | ) -> Arc> { [INFO] [stdout] 98 | Self::new_with_name(reducer, state, "store".into()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:174:18 [INFO] [stdout] | [INFO] [stdout] 167 | subscriber: Arc + Send + Sync>, [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | let subscribers = self.subscribers.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | Box::new(SubscriptionImpl { [INFO] [stdout] | __________________^ [INFO] [stdout] 175 | | unsubscribe: Box::new(move || { [INFO] [stdout] 176 | | let mut subscribers = subscribers.lock().unwrap(); [INFO] [stdout] 177 | | subscribers.retain(|s| !Arc::ptr_eq(s, &subscriber)); [INFO] [stdout] 178 | | }), [INFO] [stdout] 179 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:269:23 [INFO] [stdout] | [INFO] [stdout] 266 | thunk: Box>) + Send>, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 267 | ) -> thread::JoinHandle<()> { [INFO] [stdout] 268 | let self_clone = self.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 270 | | let dispatcher = Arc::new(&self_clone as &dyn Dispatcher); [INFO] [stdout] 271 | | thunk(dispatcher); [INFO] [stdout] 272 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 90 | let (sender, receiver) = channel::bounded(capacity); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | ( [INFO] [stdout] 92 | / SenderChannel { [INFO] [stdout] 93 | | sender, [INFO] [stdout] 94 | | receiver: receiver.clone(), [INFO] [stdout] 95 | | policy, [INFO] [stdout] 96 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 90 | let (sender, receiver) = channel::bounded(capacity); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | ReceiverChannel { receiver }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rs-store` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:90:39 [INFO] [stdout] | [INFO] [stdout] 88 | reducer: Box + Send + Sync>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | ) -> Arc> { [INFO] [stdout] 90 | Self::new_with_state(reducer, Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 95 | reducer: Box + Send + Sync>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | state: State, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | ) -> Arc> { [INFO] [stdout] 98 | Self::new_with_name(reducer, state, "store".into()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:174:18 [INFO] [stdout] | [INFO] [stdout] 167 | subscriber: Arc + Send + Sync>, [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | let subscribers = self.subscribers.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | Box::new(SubscriptionImpl { [INFO] [stdout] | __________________^ [INFO] [stdout] 175 | | unsubscribe: Box::new(move || { [INFO] [stdout] 176 | | let mut subscribers = subscribers.lock().unwrap(); [INFO] [stdout] 177 | | subscribers.retain(|s| !Arc::ptr_eq(s, &subscriber)); [INFO] [stdout] 178 | | }), [INFO] [stdout] 179 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:269:23 [INFO] [stdout] | [INFO] [stdout] 266 | thunk: Box>) + Send>, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 267 | ) -> thread::JoinHandle<()> { [INFO] [stdout] 268 | let self_clone = self.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 270 | | let dispatcher = Arc::new(&self_clone as &dyn Dispatcher); [INFO] [stdout] 271 | | thunk(dispatcher); [INFO] [stdout] 272 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 90 | let (sender, receiver) = channel::bounded(capacity); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | ( [INFO] [stdout] 92 | / SenderChannel { [INFO] [stdout] 93 | | sender, [INFO] [stdout] 94 | | receiver: receiver.clone(), [INFO] [stdout] 95 | | policy, [INFO] [stdout] 96 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 90 | let (sender, receiver) = channel::bounded(capacity); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | ReceiverChannel { receiver }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rs-store` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "64e3202f74bafe9ffaa65a8daebe2f55eac973b7a49618e85c7677fada98afed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64e3202f74bafe9ffaa65a8daebe2f55eac973b7a49618e85c7677fada98afed", kill_on_drop: false }` [INFO] [stdout] 64e3202f74bafe9ffaa65a8daebe2f55eac973b7a49618e85c7677fada98afed